Commit Graph

4060 Commits

Author SHA1 Message Date
Ward Fisher
1d9bd601bd Merge branch 'remove_x_int64' of https://github.com/wkliao/netcdf-c into v4.5.0-release-branch 2017-06-07 12:20:29 -06:00
Ward Fisher
d7559717a6 Merge branch 'fix_leak_in_NC4_put_propattr' of https://github.com/rouault/netcdf-c into v4.5.0-release-branch 2017-06-07 12:04:31 -06:00
Even Rouault
d02e3c952b Fix memory leak in NC4_put_propattr()
Current code only frees char* text in error cases. It should
also free it in success case.

Otherwise Valgrind reports a leak:

==28536== 64 bytes in 1 blocks are definitely lost in loss record 4 of 13
==28536==    at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==28536==    by 0xE673496: NC4_buildpropinfo (nc4info.c:239)
==28536==    by 0xE67313B: NC4_put_propattr (nc4info.c:162)
==28536==    by 0xE65BF35: nc4_create_file (nc4file.c:468)
==28536==    by 0xE65C0AC: NC4_create (nc4file.c:564)
==28536==    by 0xE608A08: NC_create (dfile.c:1773)
==28536==    by 0xE607E6A: nc__create (dfile.c:511)
==28536==    by 0xE607E23: nc_create (dfile.c:440)

Credit to OSS Fuzz
2017-06-07 10:48:38 +02:00
Wei-keng Liao
29ae0b72fe X_INT64_MIN, X_INT64_MAX, and X_UINT64_MAX should be used internally 2017-06-06 18:20:26 -05:00
Dennis Heimbigner
30846cfff1 Cmake 2017-06-06 16:21:04 -06:00
Dennis Heimbigner
8f2f9b74e3 re: pull request https://github.com/Unidata/netcdf-c/pull/364
This is a follow-on in that the old utf8 code was still being
used in ncgen to convert utf8->utf16 when converting cdl to Java
(see genj.c).

The new code apparently has no utf16 support, but it does have
utf32 support. Converting utf32 -> utf16 can be approximated by
truncating the 32bits to 16 bits, unless the top 16 bits are
not zero. This latter condition is unlikely to be common because
it implies use of some rather obscure characters.

So solution is to convert to utf32 and truncate to 16 bits to
get utf16. An error is reported if the high-order truncated 16
bits are not zero. If we get complaints, then I will figure out
how to convert full utf32 to a utf16 pair.

Also removed the old code from ncgen.
2017-06-06 15:23:59 -06:00
Ward Fisher
b039216c42 Made memory free method conditional, based on if H5free_memory is available in libhdf5 or not. In support of code contributed by Greg Sjaardema . See https://github.com/Unidata/netcdf-c/pull/411 for more information. 2017-06-06 11:33:05 -06:00
Greg Sjaardema
ebed788181 Use H5free_memory instead of free
The documentation for `H5Tget_member_name` states that the memory returned should be freed by `H5free_memory` instead of `free`.  I was getting test failure until I changed this to call H5free_memory on a Mac OS Sierra system with hdf5-1.9.236
2017-06-06 13:22:02 -04:00
Ward Fisher
ecd40e688b Removed old unused file, static html version was moved into static/ subdirectory 2017-06-06 10:48:15 -06:00
Ward Fisher
ff8b93a1d6 Bumped release date. 2017-06-05 10:32:06 -06:00
Ward Fisher
c0d9c7c306 Merge branch 'master' into fix-find-ncxx-configs 2017-06-02 10:52:45 -06:00
Ward Fisher
89ebc2b778 Fixed an issue on visual studio which can result in a race state (more or less) when dap4 AND hdf4 support is enabled. 2017-06-01 14:48:23 -06:00
Ward Fisher
cc08dfd03e Removed an unnecessary template file. 2017-06-01 14:14:09 -06:00
Ward Fisher
81b0ab959a Fixed a missing file. 2017-06-01 14:13:54 -06:00
Ward Fisher
bad0058410 Corrected a missed string. 2017-06-01 13:40:04 -06:00
Ward Fisher
ec33411c6c Bumped revision information to next version. 2017-06-01 13:35:39 -06:00
Ward Fisher
cebc9301ec Merge branch 'gh410' 2017-06-01 11:16:11 -06:00
Ward Fisher
f1f7224f93 Corrected a false positive. 2017-06-01 09:36:54 -06:00
Ward Fisher
1f96a66414 hdf4 chunking file rename 2017-06-01 09:15:41 -06:00
Ward Fisher
a077289464 Refactored hdf4 chunking test a little bit. 2017-06-01 09:11:52 -06:00
Ward Fisher
08f7d06eb6 Refactoring hdf4 chunking test in similar fashion to hdf5 compatibility test. Files are linked via AC_CONFIG_LINKS instead of shuffling things around in a shell script. 2017-06-01 09:02:31 -06:00
Ward Fisher
128fb5611a Trying distcleanfiles experiment. 2017-06-01 08:53:31 -06:00
Ward Fisher
df872ac1bc Continued refactoring. 2017-05-31 16:34:46 -06:00
Ward Fisher
ef450c40a0 Refactoring test_common.sh template. 2017-05-31 16:16:41 -06:00
Ward Fisher
ebd1fca32a Working on reformulating test_common.sh 2017-05-31 15:42:59 -06:00
Ward Fisher
05e2ff3881 Sorting out hdf4 chunk tests. 2017-05-31 15:09:26 -06:00
Ward Fisher
5699a32376 Updated cleanfiles list on Makefile.am 2017-05-31 15:01:02 -06:00
Ward Fisher
9823d73c44 Corrected a logic error. 2017-05-31 14:04:53 -06:00
Ward Fisher
03c67cb4ff Updated src path in hdf4 chunk test. 2017-05-31 13:38:22 -06:00
Ward Fisher
9a8af9184a Copying files as needed for hdf4 tests. 2017-05-31 11:25:35 -06:00
Ward Fisher
1a2716b230 Changed the shell for a test to bash to catch a missing utility in some environments. 2017-05-31 11:00:04 -06:00
Ward Fisher
a2d7a09d04 Merge branch 'gh410' of github.com:Unidata/netcdf-c into gh410 2017-05-31 09:43:59 -06:00
Ward Fisher
237594806e Updated release notes in support of https://github.com/Unidata/netcdf-c/issues/410 2017-05-31 09:42:06 -06:00
Ward Fisher
f4151c97f2 Reverted changes to X_get_size_t, in order to correct an issue 2017-05-31 09:40:59 -06:00
Ward Fisher
5b6e31f610 Deleted some old files. 2017-05-31 09:22:11 -06:00
Ward Fisher
7144cfb3e0 More debugging info. 2017-05-30 16:09:43 -06:00
Ward Fisher
fb457f2001 Moved error code to common shell. 2017-05-30 15:11:39 -06:00
Ward Fisher
310f1f8e33 Added flag to tst_dimsizes.sh to dump on error. 2017-05-30 14:29:21 -06:00
Ward Fisher
c0c9c60025 Additional tweaking. 2017-05-30 13:52:56 -06:00
DennisHeimbigner
a0cc0a195b Update install.md 2017-05-30 13:51:33 -06:00
Ward Fisher
26f8ebda46 Computed new interace version flags. 2017-05-30 13:05:31 -06:00
Peter Hill
2fec785794 Fix method of finding ncxx[4]-config for non-bash shells
`type -p` is a bashism, and might not work with other shells
2017-05-30 11:13:27 +01:00
Ward Fisher
02a6585eae Corrected some typos. 2017-05-24 15:49:18 -06:00
Ward Fisher
6e0f17f0ac Updated release notes in support of the fix for https://github.com/Unidata/netcdf-c/issues/339 2017-05-24 14:46:08 -06:00
Ward Fisher
37e3f0a6eb Removed redundant scripts. 2017-05-24 14:41:55 -06:00
Ward Fisher
7902b56a45 Added missing scripts. 2017-05-24 14:37:54 -06:00
Ward Fisher
cc496d0c6f Corrected a typo. 2017-05-24 14:33:55 -06:00
Ward Fisher
59ded4a82c Moving some tests around so that 'make check' works properly, in support of https://github.com/Unidata/netcdf-c/issues/339 2017-05-24 14:25:22 -06:00
Ward Fisher
f710b29d44 Updated release notes. 2017-05-24 14:03:50 -06:00
Ward Fisher
68f5e3a2d6 No idea how this was possibly working, previously. 2017-05-23 16:55:29 -06:00