Commit Graph

6034 Commits

Author SHA1 Message Date
Ed Hartnett
8ae5ebf6bc remove unneeded params from function 2018-11-16 08:26:09 -07:00
Ed Hartnett
0289029508 merged master 2018-11-15 17:04:45 -07:00
Ward Fisher
38e6fc6026
Merge pull request #1203 from Unidata/v4.6.2-release-branch.wif
V4.6.2 release branch
2018-11-15 17:02:25 -07:00
Ed Hartnett
60a33b9e8b removed hdf5 stuff from NC_FIELD_INFO_T 2018-11-15 16:46:22 -07:00
Ed Hartnett
8aa4577bef merged ejh_next_7 2018-11-15 16:40:14 -07:00
Ward Fisher
a41dd76abe Merge branch 'ejh_static_szip' of https://github.com/NetCDF-World-Domination-Council/netcdf-c into v4.6.2-release-branch.wif 2018-11-15 15:50:33 -07:00
Ward Fisher
ce78cf2d73
Merge branch 'master' into MT-for-MSVC-release 2018-11-15 15:49:05 -07:00
Ward Fisher
572121d3dc
Merge pull request #1201 from Unidata/v4.6.2-release-branch.wif
V4.6.2 release branch.wif
2018-11-15 14:12:40 -07:00
Ward Fisher
9dd9a19142 Merge remote-tracking branch 'origin/ncgenmem.dmh' into v4.6.2-release-branch.wif 2018-11-15 10:51:59 -07:00
Ward Fisher
9e1a8565c2 Merge branch 'tmptmp' into v4.6.2-release-branch.wif 2018-11-15 10:32:18 -07:00
Ward Fisher
462bfbe15f Corrected whitespace issue on OSX 2018-11-15 10:32:07 -07:00
Dennis Heimbigner
b89e3f50d0 Fix introduced alert https://lgtm.com/projects/g/Unidata/netcdf-c/rev/pr-5fdf9cb537c1a981abb3838fdfb061b1088636f0
by removing offending, unused global variable.
2018-11-15 10:31:36 -07:00
Ward Fisher
53dc9022be Merge remote-tracking branch 'origin/ncgenmem.dmh' into tmptmp 2018-11-15 10:20:08 -07:00
Ward Fisher
6de931cec2 Merge branch 'fix_warnings' of https://github.com/gsjaardema/netcdf-c into v4.6.2-release-branch.wif 2018-11-15 10:02:52 -07:00
Ward Fisher
907ed8d95f
Merge branch 'master' into fix_warnings 2018-11-15 10:02:09 -07:00
Dennis Heimbigner
751300ec59 Fix more memory leaks in netcdf-c library
This is a follow up to PR https://github.com/Unidata/netcdf-c/pull/1173

Sorry that it is so big, but leak suppression can be complex.

This PR fixes all remaining memory leaks -- as determined by
-fsanitize=address, and with the exceptions noted below.

Unfortunately. there remains a significant leak that I cannot
solve. It involves vlens, and it is unclear if the leak is
occurring in the netcdf-c library or the HDF5 library.

I have added a check_PROGRAM to the ncdump directory to show the
problem.  The program is called tst_vlen_demo.c To exercise it,
build the netcdf library with -fsanitize=address enabled. Then
go into ncdump and do a "make clean check".  This should build
tst_vlen_demo without actually executing it.  Then do the
command "./tst_vlen_demo" to see the output of the memory
checker.  Note the the lost malloc is deep in the HDF5 library
(in H5Tvlen.c).

I am temporarily working around this error in the following way.
1. I modified several test scripts to not execute known vlen tests
   that fail as described above.
2. Added an environment variable called NC_VLEN_NOTEST.
   If set, then those specific tests are suppressed.

This should mean that the --disable-utilities option to
./configure should not need to be set to get a memory leak clean
build.  This should allow for detection of any new leaks.

Note: I used an environment variable rather than a ./configure
option to control the vlen tests. This is because it is
temporary (I hope) and because it is a bit tricky for shell
scripts to access ./configure options.

Finally, as before, this only been tested with netcdf-4 and hdf5 support.
2018-11-15 10:00:38 -07:00
Ward Fisher
b0b87b6fd4 Merge branch 'patch-28' of https://github.com/gsjaardema/netcdf-c into v4.6.2-release-branch.wif 2018-11-15 09:56:16 -07:00
Ward Fisher
619f0f1bdf
Merge branch 'master' into patch-28 2018-11-14 13:16:24 -07:00
Ward Fisher
bec178002a Merge branch 'patch-27' of https://github.com/gsjaardema/netcdf-c into v4.6.2-release-branch.wif 2018-11-14 11:29:07 -07:00
Ed Hartnett
e270359952 merged master 2018-11-14 11:17:30 -07:00
Ward Fisher
e9626207ad
Merge branch 'master' into patch-27 2018-11-14 11:14:41 -07:00
Ward Fisher
57847bb5cf Merge remote-tracking branch 'origin/ncgenjava.dmh' into v4.6.2-release-branch.wif 2018-11-14 11:10:16 -07:00
Greg Sjaardema
cd011cd1bb Eliminate compiler warnings (and code error) 2018-11-14 11:00:47 -07:00
Ed Hartnett
cebf4f3a32 fixed static hdf5 lib problems, changed tarball name 2018-11-14 10:36:27 -07:00
Greg Sjaardema
a519c12f52
Remove extra argument
Removes extra argument to match function prototype in `NC_Dispatch` as described in #1196
2018-11-14 10:35:58 -07:00
Ed Hartnett
fda69e6b23 moving rest of var stuff 2018-11-13 17:05:50 -07:00
Ed Hartnett
6a66ecd3d0 moving rest of var stuff 2018-11-13 17:03:11 -07:00
Ed Hartnett
d7fe095066 moving rest of var stuff 2018-11-13 16:59:07 -07:00
Ed Hartnett
d7aac4501b removing hid_t from NC_VAR_INFO_T 2018-11-13 16:10:49 -07:00
Ed Hartnett
4045588516 removing hid_t from NC_VAR_INFO_T 2018-11-13 16:10:34 -07:00
Ed Hartnett
f6def4a089 moving some fill value handling to libhdf5 2018-11-13 15:37:49 -07:00
Ed Hartnett
9fee4db86b more var changes 2018-11-13 12:37:53 -07:00
Ed Hartnett
55ab435849 more var changes 2018-11-13 11:44:27 -07:00
Ed Hartnett
6c135d0c24 more var changes 2018-11-13 11:39:45 -07:00
Ed Hartnett
25fe9e8364 more var changes 2018-11-13 11:36:25 -07:00
Ed Hartnett
67317bf5a0 more var work 2018-11-13 11:30:23 -07:00
Ed Hartnett
1d951f6d04 more var changes to libhdf5 from libsrc4 2018-11-13 11:14:36 -07:00
Ed Hartnett
e1eeb309a1 more var changes to libhdf5 from libsrc4 2018-11-13 11:08:10 -07:00
Ed Hartnett
192a9b1b9e moving hdf5-specific var stuff 2018-11-13 10:18:29 -07:00
Ed Hartnett
a9a0e5ba39 moving hdf5-specific var stuff 2018-11-13 10:04:55 -07:00
Ed Hartnett
18ca0e4e9a changing var to libhdf5 info 2018-11-13 09:58:32 -07:00
Ed Hartnett
49e0c1dc87 setting values in libhdf5 version of var hdf5-specific info 2018-11-13 09:00:15 -07:00
Ed Hartnett
f7e6746c7c fixed hDF4 memory freeing of format specific var info 2018-11-13 07:47:24 -07:00
Ed Hartnett
87ddebac4b setting values for var hdf5 info 2018-11-13 07:31:59 -07:00
Ed Hartnett
421eb32ea0 allocating storage for var hdf5 info 2018-11-13 06:34:09 -07:00
Ed Hartnett
d994a28139 allocating storage for var hdf5 info 2018-11-13 06:26:36 -07:00
Ed Hartnett
ce43b7d772 free hdf5-specific var info and cleanup 2018-11-13 05:58:54 -07:00
Ed Hartnett
f7cb5ead1c moving var hdf5-specific info into libhdf5 2018-11-13 05:44:39 -07:00
Ed Hartnett
578ddb2a28 cleaning up nc4internal.h 2018-11-13 05:27:46 -07:00
Ed Hartnett
286e276390 cleaning up nc4internal.h 2018-11-13 05:18:00 -07:00