mirror/netcdf-c
2
0
Fork 0
mirror of https://github.com/Unidata/netcdf-c.git synced 2025-02-05 16:20:10 +08:00
Code Issues Packages Projects Releases Wiki Activity
3,865 Commits 92 Branches 75 Tags 90 MiB
b3418d2cd6
Commit Graph

3865 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Even Rouault
b3418d2cd6 Fix undefined left shift in ncx_get_size_t() 
Running a build on the .nc file corresponding to the below ncdump output
with -fsanitize=undefined raises

libsrc/ncx.c:4722:26: runtime error: left shift of 255 by 24 places cannot be represented in type 'int'

This is due to *cp being promoted to int before doing the left shift, instead
of the intended unsigned. So do the cast to unsigned internally rather than
externally

ncdump file to reproduce:

netcdf temp {
dimensions:
	y = UNLIMITED ; // (0 currently)
	x = 109067 ;
variables:
	byte t(y, x, x) ;
data:
}

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=2265

Credit to OSS Fuzz
 2017-06-15 12:46:37 +02:00
Ward Fisher
92270070d5 Merge branch 'nc_get_filelen' of https://github.com/wkliao/netcdf-c into v4.5.0-release-branch 2017-06-09 12:50:11 -06:00
Ward Fisher
12d224eeef Corrected an issue in support of https://github.com/Unidata/netcdf-c/issues/420 2017-06-09 12:46:37 -06:00
Wei-keng Liao
308c2f764e struct stat.st_size is of type off_t 2017-06-09 02:51:06 -05:00
Ward Fisher
b73c81697c Removed a line in configure.ac that is potentially redundant and throws an error on some systems. In support of https://github.com/Unidata/netcdf-c/issues/413 2017-06-08 12:38:43 -06:00
Ward Fisher
4097dd9826 Change to address issue reported in https://github.com/Unidata/netcdf-c/issues/413 2017-06-08 11:55:00 -06:00
Ward Fisher
af91d03bac Merge branch 'fix-find-ncxx-configs' of https://github.com/ZedThree/netcdf-c into v4.5.0-release-branch 2017-06-07 17:20:16 -06:00
Ward Fisher
40f616488c Corrected release notes again. 2017-06-07 17:14:04 -06:00
Ward Fisher
4d941f5f02 Corrected release notes. 2017-06-07 15:27:11 -06:00
Ward Fisher
3a0b0d5339 Replaced sed with configure_ac_files, since sed may not be available. 2017-06-07 13:21:07 -06:00
Ward Fisher
6da1539ff9 Removed software.md from dist file. 2017-06-07 12:58:23 -06:00
Ward Fisher
1d9bd601bd Merge branch 'remove_x_int64' of https://github.com/wkliao/netcdf-c into v4.5.0-release-branch 2017-06-07 12:20:29 -06:00
Ward Fisher
d7559717a6 Merge branch 'fix_leak_in_NC4_put_propattr' of https://github.com/rouault/netcdf-c into v4.5.0-release-branch 2017-06-07 12:04:31 -06:00
Even Rouault
d02e3c952b Fix memory leak in NC4_put_propattr() 
Current code only frees char* text in error cases. It should
also free it in success case.

Otherwise Valgrind reports a leak:

==28536== 64 bytes in 1 blocks are definitely lost in loss record 4 of 13
==28536==    at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==28536==    by 0xE673496: NC4_buildpropinfo (nc4info.c:239)
==28536==    by 0xE67313B: NC4_put_propattr (nc4info.c:162)
==28536==    by 0xE65BF35: nc4_create_file (nc4file.c:468)
==28536==    by 0xE65C0AC: NC4_create (nc4file.c:564)
==28536==    by 0xE608A08: NC_create (dfile.c:1773)
==28536==    by 0xE607E6A: nc__create (dfile.c:511)
==28536==    by 0xE607E23: nc_create (dfile.c:440)

Credit to OSS Fuzz
 2017-06-07 10:48:38 +02:00
Wei-keng Liao
29ae0b72fe X_INT64_MIN, X_INT64_MAX, and X_UINT64_MAX should be used internally 2017-06-06 18:20:26 -05:00
Ward Fisher
b039216c42 Made memory free method conditional, based on if H5free_memory is available in libhdf5 or not. In support of code contributed by Greg Sjaardema . See https://github.com/Unidata/netcdf-c/pull/411 for more information. 2017-06-06 11:33:05 -06:00
Greg Sjaardema
ebed788181 Use H5free_memory instead of free 
The documentation for `H5Tget_member_name` states that the memory returned should be freed by `H5free_memory` instead of `free`.  I was getting test failure until I changed this to call H5free_memory on a Mac OS Sierra system with hdf5-1.9.236
 2017-06-06 13:22:02 -04:00
Ward Fisher
ecd40e688b Removed old unused file, static html version was moved into static/ subdirectory 2017-06-06 10:48:15 -06:00
Ward Fisher
ff8b93a1d6 Bumped release date. 2017-06-05 10:32:06 -06:00
Ward Fisher
c0d9c7c306 Merge branch 'master' into fix-find-ncxx-configs 2017-06-02 10:52:45 -06:00
Ward Fisher
89ebc2b778 Fixed an issue on visual studio which can result in a race state (more or less) when dap4 AND hdf4 support is enabled. 2017-06-01 14:48:23 -06:00
Ward Fisher
cc08dfd03e Removed an unnecessary template file. 2017-06-01 14:14:09 -06:00
Ward Fisher
81b0ab959a Fixed a missing file. 2017-06-01 14:13:54 -06:00
Ward Fisher
bad0058410 Corrected a missed string. 2017-06-01 13:40:04 -06:00
Ward Fisher
ec33411c6c Bumped revision information to next version. 2017-06-01 13:35:39 -06:00
Ward Fisher
cebc9301ec Merge branch 'gh410' 2017-06-01 11:16:11 -06:00
Ward Fisher
f1f7224f93 Corrected a false positive. 2017-06-01 09:36:54 -06:00
Ward Fisher
1f96a66414 hdf4 chunking file rename 2017-06-01 09:15:41 -06:00
Ward Fisher
a077289464 Refactored hdf4 chunking test a little bit. 2017-06-01 09:11:52 -06:00
Ward Fisher
08f7d06eb6 Refactoring hdf4 chunking test in similar fashion to hdf5 compatibility test. Files are linked via AC_CONFIG_LINKS instead of shuffling things around in a shell script. 2017-06-01 09:02:31 -06:00
Ward Fisher
128fb5611a Trying distcleanfiles experiment. 2017-06-01 08:53:31 -06:00
Ward Fisher
df872ac1bc Continued refactoring. 2017-05-31 16:34:46 -06:00
Ward Fisher
ef450c40a0 Refactoring test_common.sh template. 2017-05-31 16:16:41 -06:00
Ward Fisher
ebd1fca32a Working on reformulating test_common.sh 2017-05-31 15:42:59 -06:00
Ward Fisher
05e2ff3881 Sorting out hdf4 chunk tests. 2017-05-31 15:09:26 -06:00
Ward Fisher
5699a32376 Updated cleanfiles list on Makefile.am 2017-05-31 15:01:02 -06:00
Ward Fisher
9823d73c44 Corrected a logic error. 2017-05-31 14:04:53 -06:00
Ward Fisher
03c67cb4ff Updated src path in hdf4 chunk test. 2017-05-31 13:38:22 -06:00
Ward Fisher
9a8af9184a Copying files as needed for hdf4 tests. 2017-05-31 11:25:35 -06:00
Ward Fisher
1a2716b230 Changed the shell for a test to bash to catch a missing utility in some environments. 2017-05-31 11:00:04 -06:00
Ward Fisher
a2d7a09d04 Merge branch 'gh410' of github.com:Unidata/netcdf-c into gh410 2017-05-31 09:43:59 -06:00
Ward Fisher
237594806e Updated release notes in support of https://github.com/Unidata/netcdf-c/issues/410 2017-05-31 09:42:06 -06:00
Ward Fisher
f4151c97f2 Reverted changes to X_get_size_t, in order to correct an issue 2017-05-31 09:40:59 -06:00
Ward Fisher
5b6e31f610 Deleted some old files. 2017-05-31 09:22:11 -06:00
Ward Fisher
7144cfb3e0 More debugging info. 2017-05-30 16:09:43 -06:00
Ward Fisher
fb457f2001 Moved error code to common shell. 2017-05-30 15:11:39 -06:00
Ward Fisher
310f1f8e33 Added flag to tst_dimsizes.sh to dump on error. 2017-05-30 14:29:21 -06:00
Ward Fisher
c0c9c60025 Additional tweaking. 2017-05-30 13:52:56 -06:00
Ward Fisher
26f8ebda46 Computed new interace version flags. 2017-05-30 13:05:31 -06:00
Peter Hill
2fec785794 Fix method of finding ncxx[4]-config for non-bash shells 
`type -p` is a bashism, and might not work with other shells
 2017-05-30 11:13:27 +01:00