Commit Graph

6114 Commits

Author SHA1 Message Date
Ward Fisher
6e4e3ac7bc Merge remote-tracking branch 'origin/doublefree.dmh' into pr-aggregation.wif 2018-11-28 13:29:09 -07:00
Ward Fisher
0f72f42d3a Merge branch 'ejh_next_17' of https://github.com/NetCDF-World-Domination-Council/netcdf-c into pr-aggregation.wif 2018-11-28 13:28:26 -07:00
Ward Fisher
7cec43e286 Merge remote-tracking branch 'origin/gh803.wif' into pr-aggregation.wif 2018-11-28 13:26:39 -07:00
Dennis Heimbigner
82e46ef594 Update nc_test/tst_inmemory to cover more cases
re: pull request https://github.com/Unidata/netcdf-c/pull/1219

This pr should go in after or at the same time as 1219.
It updates nc_test/tst_inmemory to add a test to cover
the case fixed in 1219. It also disables a couple of tests
that no longer are relevant.
2018-11-27 19:20:19 -07:00
Ward Fisher
6d35f430a6 Updated release notes. 2018-11-27 16:13:49 -07:00
Ward Fisher
a068892ace Merge branch 'master' into gh803.wif 2018-11-27 16:09:35 -07:00
Ward Fisher
a8673c3dfe Moving provenance info out so that it doesn't depend on netCDF4 support to display. 2018-11-27 16:09:17 -07:00
Greg Sjaardema
e33506030d Modify test to increase code coverage
By increasing the DIM1 size, the created in-memory file will be
larger than the default memory allocation size (4096), so the code
will have to reallocate the memory which results in more code coverage.
2018-11-27 14:00:43 -07:00
Greg Sjaardema
01dd260618 Revert "Temporarily disable test"
This reverts commit c6cfbb032c.
2018-11-27 12:29:18 -07:00
Greg Sjaardema
0ba4aa9487 Revert "Try disabling the test that is actually failing..."
This reverts commit e5c1084f26.
2018-11-27 12:29:16 -07:00
Greg Sjaardema
fc795c58fa Revert "One more try..."
This reverts commit b0fd3ea1a4.
2018-11-27 12:29:13 -07:00
Greg Sjaardema
a42545baa7 Revert "Disable test in autotools also"
This reverts commit 72ab483f65.
2018-11-27 12:28:43 -07:00
Ward Fisher
c1dfe92dab TEMPORARILY turned on printing out hidden attributes for classic and 64-bit offset files while I figure out why they were turned off in the first place. 2018-11-26 18:14:24 -07:00
Ward Fisher
4144f03a44 Added a stanza to not copy _NCProperties atttribute from an old file to a new file, and instead use the properties appropriate for the newly created file. 2018-11-26 17:56:44 -07:00
Ed Hartnett
c638c8de92 cleanup 2018-11-26 11:22:32 -07:00
Ed Hartnett
f9d3fff2c3 rest of removal of lazy att code from libsrc4 2018-11-26 11:11:56 -07:00
Ed Hartnett
016f675fad more separation of lazy att reads from libsrc4 2018-11-26 10:44:48 -07:00
Ed Hartnett
38a59a32f8 separation of lazy atts from libsrc4 2018-11-26 10:28:48 -07:00
Ed Hartnett
ba3bc50015 separation of lazy atts from libsrc4 2018-11-26 10:24:37 -07:00
Ed Hartnett
c56b1cecd4 moving lazy att code to libhdf5 2018-11-26 10:18:24 -07:00
Ed Hartnett
c710b42707 moving lazy att code to libhdf5 2018-11-26 10:14:03 -07:00
Ed Hartnett
cc18944fa7 moved lazy atts handling for nc_inq_attid() 2018-11-26 09:58:31 -07:00
Ed Hartnett
d97824d3e6 moved lazy atts handling for nc_inq_att() 2018-11-26 09:51:28 -07:00
Ed Hartnett
ff0d526404 adding hdf5dispatch.h to git 2018-11-26 08:26:28 -07:00
Ed Hartnett
8e7fc913cb moving lazy atts code to libhdf5 2018-11-26 08:24:18 -07:00
Ed Hartnett
1df4bb1762 moving lazy atts code to libhdf5 2018-11-26 08:21:32 -07:00
Ed Hartnett
1f64c66cdf rename HDF5 dispatch functions to start with NC4_HDF5 2018-11-26 08:13:57 -07:00
Ed Hartnett
aade08ee22 moving checking for lazy att reads to libhdf5 2018-11-26 07:49:58 -07:00
Ed Hartnett
8bb644204e added hdf5dispatch.c to cmake build 2018-11-26 06:00:38 -07:00
Ed Hartnett
0e9784a867 more changes to separate HDF5 from libsrc4 initialization 2018-11-26 05:44:59 -07:00
Ed Hartnett
6f969b0117 separate HDF5 initialization 2018-11-26 05:35:44 -07:00
Ed Hartnett
e8ab6286e3 header file cleanup 2018-11-26 05:20:35 -07:00
Ed Hartnett
64b45b5e75 changes in support of separating HDF5 and libsrc4 2018-11-26 04:40:33 -07:00
Ed Hartnett
9b90c7744e changes in support of separating HDF5 and libsrc4 2018-11-26 04:35:00 -07:00
Ed Hartnett
6dbcc42eb6 changes in support of separating HDF5 and libsrc4 2018-11-26 04:31:23 -07:00
Ed Hartnett
730c7bed2b turned dap4 test back on 2018-11-21 17:54:29 -07:00
Dennis Heimbigner
ab848a3aeb
Forgot to change realloc -> H5resize_memory in H5Zbzip2.c 2018-11-21 16:19:14 -07:00
Ed Hartnett
f6c3093fb3 moved convert function to libsrc4 2018-11-21 14:49:52 -07:00
Greg Sjaardema
72ab483f65
Disable test in autotools also
Still disabling test...
2018-11-21 11:48:25 -07:00
Greg Sjaardema
b0fd3ea1a4
One more try...
Disable test in autotools build also...
2018-11-21 11:36:08 -07:00
Greg Sjaardema
e5c1084f26
Try disabling the test that is actually failing... 2018-11-21 10:43:42 -07:00
Greg Sjaardema
c6cfbb032c
Temporarily disable test
Test is failing, but unrelated to the change in the pull request.  Temporarily disable so PR build tests will succeed
2018-11-21 10:25:31 -07:00
Ed Hartnett
3f4b48fc6a temporarily turned off dap4_test/test_remote.sh 2018-11-21 09:17:44 -07:00
Ed Hartnett
f2ecde100c temporarily turned off dap4_test/test_remote.sh 2018-11-21 08:34:22 -07:00
Ed Hartnett
5a1836bebb temporarily turned off dap4_test/test_remote.sh 2018-11-21 08:26:21 -07:00
Ed Hartnett
26db90e4e3 changes 2018-11-21 07:39:05 -07:00
Ed Hartnett
c1ffb92a7f checking return value for HDF5 function call 2018-11-20 15:43:34 -07:00
Greg Sjaardema
6ae132e81c
Eliminate double-free in realloc'd memory
If `memio->memory` is freed, then there is a double-free error since that pointer was either already freed in the realloc call, or it is the same pointer as newmen and should not be freed.   The documentation of realloc(3) states:
```
If the area pointed to was moved, a free(ptr) is done.
```

I'm not sure why I haven't hit this before, but I had a couple of my tests start throwing `double-free` errors and valgrind confirmed that the pointer had already been freed at the point of the realloc call.
2018-11-20 15:28:01 -07:00
Ed Hartnett
8dc1ffea38 removing HDF5 type info from libsrc4 2018-11-20 14:26:11 -07:00
Ed Hartnett
ab963e3d41 removing HDF5 type info from libsrc4 2018-11-20 14:24:40 -07:00