Commit Graph

7226 Commits

Author SHA1 Message Date
Dennis Heimbigner
b0e0d81aa9 Fix reclamation of the ->format_XXX_info fields
nc4internal.c contains code to free the format_XXX_info
fields. Since these are format specific, this code
was moved to the dispatch code (libhdf5 and libhdf4
in the current case).

Additionally, there are some fields in nc4internal.h (e.g.
dimscale fields) that are specific to HDF5 and have been moved
to the corresponding HDF5 data structures and code.

Misc. other changes:
1. NC_VAR_INFO_T->hdf5_name renamed to alt_name to avoid
   implying it is necessarily HDF5 specific.
2. prefix NC_FILE_INFO_T with an instance of NC_OBJ for consistency.
   this also requires wrapping move_in_NCList() to keep
   hdr.id consistent.
2020-03-29 12:48:59 -06:00
Ward Fisher
be2f7ca7b8
Merge pull request #1679 from NOAA-GSD/ejh_cache_test
fixed documentation of cache int functions
2020-03-25 16:57:53 -06:00
Edward Hartnett
e7b9b1b587 fixed documentation of cache int functions 2020-03-24 15:02:42 -06:00
Ward Fisher
74afd13f44
Merge pull request #1671 from NOAA-GSD/ejh_hdf5_1_12_0
build library with hdf5 1 12 0
2020-03-24 14:33:14 -06:00
Ward Fisher
05c67d9421
Merge pull request #1674 from NOAA-GSD/ejh_deflate_bug
now pass 0 for deflate_level if deflate not in use
2020-03-18 16:47:03 -06:00
Edward Hartnett
9b6215936b updated documentation of nc_inq_var_deflate() to describe behavior of deflate_level when deflate not in use 2020-03-17 10:33:53 -06:00
Edward Hartnett
edea5e3552 now pass 0 for deflate_level if deflate not in use 2020-03-16 11:01:13 -06:00
Edward Hartnett
1361deffa3
Merge branch 'master' into ejh_hdf5_1_12_0 2020-03-12 16:03:09 -06:00
Ward Fisher
0251ce7101
Merge pull request #1670 from DennisHeimbigner/daperr.dmh
Force error report when DAP gets error response.
2020-03-11 16:10:49 -06:00
Ward Fisher
d92556590f
Merge pull request #1669 from Unidata/gh1668.wif
Add test to #1668
2020-03-11 15:02:23 -06:00
Ward Fisher
825978be6e Updated release notes in support of https://github.com/Unidata/netcdf-c/issues/1666, https://github.com/Unidata/netcdf-c/issues/1668 and https://github.com/Unidata/netcdf-c/issues/1669 2020-03-11 13:52:52 -06:00
Dennis Heimbigner
7cd29598e6 Force error report when DAP gets error response.
re: https://github.com/Unidata/netcdf-c/issues/1667

Make DAP (2 and 4) forcibly report an error message
when an error response is received from the DAP servlet.
2020-03-11 13:36:20 -06:00
Ward Fisher
d7e6e50c51 Fix typo for distcheck. 2020-03-11 13:33:25 -06:00
Ward Fisher
f8f5f8b1f7 Permissions error on unicode directory test script. 2020-03-11 13:19:01 -06:00
Ward Fisher
7db8b501d8 Typo in Makefile.am 2020-03-11 13:15:32 -06:00
Ward Fisher
eed4788520 Added cleanup to test script. 2020-03-11 13:04:44 -06:00
Ward Fisher
d84dc3a634 Merge branch 'utf8.dmh' of https://github.com/DennisHeimbigner/netcdf-c into gh1668.wif 2020-03-11 12:59:56 -06:00
Ward Fisher
060921eafd Syntax fix 2020-03-11 12:58:56 -06:00
Ward Fisher
1fcec23957 Adding test in support of https://github.com/Unidata/netcdf-c/pulls/1668 2020-03-11 12:49:33 -06:00
Dennis Heimbigner
1bce6b9b5c Fix open/create of UTF8 names
re: issue https://github.com/Unidata/netcdf-c/issues/1666

The code in NC_open and NC_create (in dfile.c)
was using improperly testing for leading whitespace chars.
It was treating UTF-8 as whitespace.

Fix is to do tests using unsigned char.
2020-03-11 11:25:57 -06:00
Ward Fisher
acce5eec88
Merge pull request #1663 from NOAA-GSD/ejh_refactor_storage
refactor storage in NC_VAR_INFO_T
2020-03-09 15:44:30 -06:00
Edward Hartnett
2ef818eed0 change to trigger CI 2020-03-09 09:52:08 -06:00
Edward Hartnett
99f486c988 updated release notes 2020-03-09 07:18:43 -06:00
Edward Hartnett
6fa5e677b3 merged in ejh_hdf5_1_12 2020-03-09 07:06:05 -06:00
Edward Hartnett
b29f9f34a0 whitespace cleanup 2020-03-08 09:10:07 -06:00
Edward Hartnett
00cec4b3ab final removal of fields contiguous/compact from NC_VAR_INFO_T 2020-03-08 07:37:23 -06:00
Edward Hartnett
4c7e162f34 less use of contiguous/compact field 2020-03-08 07:31:21 -06:00
Edward Hartnett
21d2458afe fixed HDF4 use of contiguous 2020-03-08 07:28:30 -06:00
Edward Hartnett
053752440b stop setting contiguous field in nc4hdf5.c 2020-03-08 07:18:52 -06:00
Edward Hartnett
04eafff166 stop setting contiguous field in hdf5filter.c 2020-03-08 07:18:11 -06:00
Edward Hartnett
5574317db7 stop setting contiguous/compact fields at file open 2020-03-08 07:17:01 -06:00
Edward Hartnett
fcceec60a4 now using storage everywhere 2020-03-08 07:13:07 -06:00
Edward Hartnett
61357cfd4d more use of storage field 2020-03-08 07:09:15 -06:00
Edward Hartnett
1761850795 continuing to switch to storage field 2020-03-08 07:05:51 -06:00
Edward Hartnett
b98a37e0b3 using storage field in nc4var.c 2020-03-08 06:38:44 -06:00
Edward Hartnett
119e8e9465 using storage in hdf5filter.c 2020-03-08 06:31:34 -06:00
Edward Hartnett
8dec9f6c99 now setting storage field when setting var storage 2020-03-08 06:29:49 -06:00
Edward Hartnett
d87a073a34 starting to use storage field when opening file 2020-03-08 06:21:08 -06:00
Edward Hartnett
ddb44b5abb added storage to NC_VAR_INFO_T, removed unneeded test code 2020-03-07 05:08:12 -07:00
Ward Fisher
34c3b85fc0
Merge pull request #1662 from NOAA-GSD/ejh_scalar_chunking
Return error on attempt to set chunking on scalar var
2020-03-06 14:07:18 -07:00
Edward Hartnett
0c419ec582 removed commented-out code 2020-03-06 09:57:33 -07:00
Edward Hartnett
7004bbc2d5 updated documentation 2020-03-06 09:54:26 -07:00
Ward Fisher
4a24a78aa3
Merge pull request #1661 from gsjaardema/patch-38
Better finding of the hdf5.h include path
2020-03-05 16:46:35 -07:00
Ward Fisher
fa0cd583ef
Merge pull request #1659 from NOAA-GSD/ejh_storage
Fix parallel build error in tst_mode.c caused by returning errors for attempts to set filters on scalar vars
2020-03-05 16:45:33 -07:00
Greg Sjaardema
aca7b5cc2e
Better finding of the hdf5.h include path
The `FIND_PATH` function has a non-intuitive order in which is searches for include paths and the original form could find a system-installed version of HDF5 even though the developer specified an explicit path via `HDF5_INCLUDE_DIR`.  See https://cmake.org/cmake/help/latest/command/find_path.html for more information.

The form in this patch is the recommended method from that page for changing the default search order to find the explicitly specified path *first*


> The default search order is designed to be most-specific to least-specific for common use cases. Projects may override the order by simply calling the command multiple times and using the NO_* options:
```
find_path (<VAR> NAMES name PATHS paths... NO_DEFAULT_PATH)
find_path (<VAR> NAMES name)
```
> Once one of the calls succeeds the result variable will be set and stored in the cache so that no call will search again.
2020-03-05 14:44:38 -07:00
Ward Fisher
018a83adfc
Merge pull request #1660 from gsjaardema/patch-37
Add missing ERR macro on tests
2020-03-04 16:16:58 -07:00
Greg Sjaardema
404b0a3ed7
Add missing ERR macro on tests
A few of the tests were missing a call to the ERR macro.
2020-03-04 13:31:47 -07:00
Edward Hartnett
bb09d4ee19 clarified release notes 2020-03-03 12:04:50 -07:00
Edward Hartnett
502336c2c7 now return NC_EINVAL on attempt to set chunking on scalar var 2020-03-03 11:57:16 -07:00
Edward Hartnett
c484f8f3d0 fixed tst_mode to not attempt to set filters on scalars 2020-03-03 07:44:37 -07:00