Commit Graph

554 Commits

Author SHA1 Message Date
Wei-keng Liao
cb7aafa805 fix issue 791: validate ncid for classic files 2018-01-25 00:03:19 -06:00
Ward Fisher
7f1f02c96d Additional tweaks for make dist. 2018-01-24 18:05:30 -07:00
Ward Fisher
d0339c8902 Merge branch 'pr-catchup' into v4.6.0-release-branch 2018-01-24 15:51:24 -06:00
Ward Fisher
ca814c17f0 Added fenceposts for filter testing. 2018-01-23 18:18:58 -06:00
Dennis Heimbigner
3e47f5f300 Rebuilt the filter parameter handling code to use a common
parser everywhere.
2018-01-23 16:00:11 -07:00
Ward Fisher
aac9fad1c4 Merge branch 'ejh_develop_3' of https://github.com/NetCDF-World-Domination-Council/netcdf-c into pr-catchup 2018-01-23 15:32:19 -06:00
Wei-keng Liao
d0c2015ced fix tst_converts.c when enable-erange-fill is set 2018-01-20 15:44:04 -06:00
Ed Hartnett
c329298dc5 merged 760 2018-01-20 07:31:42 -07:00
Ed Hartnett
ef65bdf9af merged 786 2018-01-20 06:06:25 -07:00
Ed Hartnett
da928c1b83 merged 780 2018-01-20 06:05:34 -07:00
Ed Hartnett
9fcc6b62fd merged 769 2018-01-20 06:05:17 -07:00
Dennis Heimbigner
22ebecab23 Use an explicit can_apply function for filters 2018-01-19 18:45:56 -07:00
Dennis Heimbigner
991c4c6d16 Add some extra nccopy filter debug output 2018-01-19 12:06:02 -07:00
Dennis Heimbigner
e723d7dfed Merge branch 'plugins.dmh' of https://github.com/Unidata/netcdf-c into plugins.dmh 2018-01-19 10:58:46 -07:00
Ed Hartnett
986673ff49 attempted to fix parallel build issue 2018-01-19 06:53:04 -07:00
Ed Hartnett
2f7625d19a more test development 2018-01-19 05:19:15 -07:00
Ed Hartnett
196a0b574a more test development 2018-01-19 05:11:07 -07:00
Ed Hartnett
4be1fd82e6 further test development 2018-01-19 04:16:59 -07:00
Ed Hartnett
bc1f103c3d cleaned up h5 checks in nc4grp.c 2018-01-19 03:37:49 -07:00
Ed Hartnett
3f83998b26
Merge branch 'master' into ejh_rename2 2018-01-18 16:05:04 -07:00
Ward Fisher
0f5fc7222b
Merge branch 'master' into plugins.dmh 2018-01-18 15:46:50 -07:00
Ed Hartnett
126d34da1d more tests, error handling 2018-01-18 07:36:52 -07:00
Ed Hartnett
38c7cddf8f further test development, added documentation for uncommitted user-defined types, fixed check of return value 2018-01-18 06:47:50 -07:00
Ed Hartnett
466fac5381 more test development 2018-01-18 05:57:33 -07:00
Ed Hartnett
001483505f rehabilitated tst_types.c 2018-01-18 05:34:52 -07:00
Dennis Heimbigner
090fc98ac9 Merge branch 'plugins.dmh' of https://github.com/Unidata/netcdf-c into plugins.dmh 2018-01-17 19:48:10 -07:00
Dennis Heimbigner
8d8dff9a2a Add some temporary debugging output 2018-01-17 19:47:54 -07:00
Ward Fisher
62abc6af09 Updated CMakeLists.txt to correct an issue seen on OSX when using cmake and running 'make test' directly from nc_test4 2018-01-17 14:00:52 -07:00
Ed Hartnett
9949a11155 removed some unneeded HDF4 checks, added some needed parameter checks 2018-01-17 09:09:58 -07:00
Ward Fisher
ac5aabc3fc Tweaked for parallel autoconf tests with filters. 2018-01-16 17:49:21 -07:00
Ward Fisher
f7b4c61c69 Updated test for OSX 2018-01-16 17:07:52 -07:00
Ward Fisher
606b782adf Corrected a build issue on OSX 2018-01-16 16:39:58 -07:00
Ed Hartnett
e6f82ae397 further test development 2018-01-16 14:57:40 -07:00
Ed Hartnett
3af0e84314 test development 2018-01-16 14:38:09 -07:00
Ed Hartnett
3a0385da3e test development 2018-01-16 14:36:47 -07:00
Dennis Heimbigner
70068d7d32 With Ward's help, I figured out how to
obviate the need for build type under
cmake+Visual-studio. This simplified
findplugin.in.
2018-01-16 13:28:30 -07:00
Dennis Heimbigner
99fccab359 1. Keep up to date by merging master
2. Fixed plugin building (nc_test4/hdf5plugins)
   to be done properly by cmake and automake.
4. Duplicated part of the nc_test4 filter test code
   in examples/C

An incomplete and untested set of hooks exist
for OS-X in nc_test4/findplugins.in. They need testing.
2018-01-16 11:00:09 -07:00
Ed Hartnett
3626c776ae test development 2018-01-16 09:43:41 -07:00
Ed Hartnett
0862d6d7ce removed MPE calls 2018-01-16 09:23:36 -07:00
Ed Hartnett
d77ac20af4 more test cleanup 2018-01-16 08:14:43 -07:00
Ed Hartnett
f603ab2163 more test cleanup 2018-01-16 08:09:14 -07:00
Ed Hartnett
ba518b80a7 more test cleanup 2018-01-16 08:09:03 -07:00
Ed Hartnett
f716ac8549 more test cleanup 2018-01-16 08:06:23 -07:00
Ed Hartnett
1bd6387e5e clean up of test 2018-01-16 08:04:00 -07:00
Ed Hartnett
de150aec4e clean up of test 2018-01-16 08:03:15 -07:00
Ed Hartnett
3fa3d3f9f9 ported rename fix changes from branch ejh_fill_values for easy merging 2018-01-05 06:01:22 -07:00
Levi Naden
978e83d28a Fix another test typo 2018-01-02 11:43:15 -05:00
Levi Naden
6a24ca4366 Fix typo 2018-01-02 11:39:09 -05:00
Levi Naden
f6fc9c183b Allow multiple vars with different chunks on the same unlimited dim
Fix #299
The conditions to make this error are the following:
* Two variables with different chunk sizes
* Both variables write on the same unlimited dimension
* The first variable has already written data when the second variable is created
2018-01-02 11:37:01 -05:00
Ward Fisher
77cca75977
Merge branch 'master' into ejh_more_tests 2017-12-07 20:24:43 -07:00
Ward Fisher
0ef6f3415a Making tst_hdf4_read_var.sh dependent on tst_interops2. 2017-12-06 15:07:54 -07:00
Ed Hartnett
ea49cc1d3f merged ejh_notbuilt_errors 2017-12-04 13:23:31 -07:00
Ed Hartnett
2066232dc0 more tests, more interanl documentation 2017-12-03 06:05:37 -07:00
Ed Hartnett
bf6dab14e0 fixed error value from nc4_find_g_var_nc() when ncid is bad 2017-12-03 04:06:56 -07:00
Ed Hartnett
9e4c564656 more tests 2017-12-02 18:00:22 -07:00
Ed Hartnett
8055c1cede more tests 2017-12-02 17:43:46 -07:00
Ed Hartnett
996e39373f more test 2017-12-02 15:52:49 -07:00
Ed Hartnett
1cf8177f45 more test 2017-12-02 15:43:40 -07:00
Ed Hartnett
ea63ff526f more tests 2017-12-02 08:05:17 -07:00
Ed Hartnett
bfeb8d4e0b more testing 2017-12-02 07:38:01 -07:00
Ed Hartnett
7cd344f7b0 removed redundant check in NC4_def_var() 2017-12-02 07:23:23 -07:00
Ed Hartnett
6c3aa79684 more testing of nc_set_var_chunk_cache_ints 2017-12-02 07:15:19 -07:00
Ed Hartnett
d840bc7160 starting adding testing for _int() functions for caching 2017-12-02 06:52:13 -07:00
Ed Hartnett
300236cd8c more tests 2017-12-01 15:08:22 -07:00
Ed Hartnett
58f422e2a8 more tests 2017-12-01 14:33:32 -07:00
Ed Hartnett
acbd3e259e more tests 2017-12-01 13:58:13 -07:00
Ed Hartnett
ded01e0aba more tests 2017-12-01 13:15:58 -07:00
Ed Hartnett
a8e9c196e2 more tests, fixed documentation warnings 2017-12-01 13:02:59 -07:00
Ed Hartnett
42c482d33c more tests 2017-12-01 11:20:09 -07:00
Ed Hartnett
ce1df112a5 more testing for nc4var.c functions 2017-12-01 09:38:32 -07:00
Ed Hartnett
2023ed6b7c fixed problems with bad inputs to nc_def_Var 2017-12-01 09:08:12 -07:00
Ed Hartnett
34c9248e6f
Merge branch 'master' into ejh_notbuilt_errors 2017-11-28 17:16:56 +00:00
Ed Hartnett
3c5404ccf7
Merge branch 'master' into ejh_ncfunc_testing 2017-11-28 00:04:38 +00:00
Ed Hartnett
ce97137318 removed properties from tst_interops3 which is no longer a test in CMake build 2017-11-26 09:07:34 -07:00
Ed Hartnett
bebe7e1e9d merged master 2017-11-26 07:06:02 -07:00
Nehal J Wani
1b91bd89d4
Fix build on pre-C99 compilers
- Make sure that the variables are declared at the top of the block.
 - Add fix to enable inline for various compilers
2017-11-26 01:47:54 +05:30
Ed Hartnett
8011fab382 now run tst_large2, also cleaned up some more warnings 2017-11-24 10:50:07 -07:00
Ed Hartnett
273b1d5bf9 merged ejh_check_test 2017-11-24 10:12:54 -07:00
Ed Hartnett
fa7f17a8c8 got cmake working with HDF4 format test 2017-11-24 06:05:55 -07:00
Ed Hartnett
b4bccb60b3 fixing test order problem 2017-11-23 07:18:12 -07:00
Ed Hartnett
60d1d6271d fixing order in CMake 2017-11-23 04:52:19 -07:00
Ed Hartnett
843db9798f finally got my distcheck act together by moving hdf4 file test to nc_test4 2017-11-23 04:41:03 -07:00
Ward Fisher
394ee6a1e0 Corrected typo, more enhancements in CMakeLists.txt 2017-11-22 13:34:56 -07:00
Ed Hartnett
d64550d3f0
Merge branch 'master' into ejh_notbuilt_errors 2017-11-22 17:14:24 +00:00
Ed Hartnett
3a48f59de3 removed legacy test that was no longer being run 2017-11-21 19:46:05 -07:00
Ed Hartnett
c8a2d53d34 fixes HDF4 build with cmake 2017-11-20 08:25:47 -07:00
Ed Hartnett
eecade6af9
Merge branch 'master' into ejh_notbuilt_errors 2017-11-18 21:24:11 +00:00
Ed Hartnett
d7c1dd82c3 fixed hdf4 test that should not run if utilities not built 2017-11-18 07:36:24 -07:00
Ed Hartnett
3b0c301d76 moved tst_bug324 in Cmake build from ncdump to nc_test4 2017-11-16 11:57:39 -07:00
Ed Hartnett
4f43b80320 moved test from ncdump to nc_test4 2017-11-16 11:30:35 -07:00
Ed Hartnett
7a2d62afe4 merging branches into develop 2017-11-15 11:26:29 -07:00
Ed Hartnett
83c2395238 merging branches into develop 2017-11-15 11:25:42 -07:00
Ed Hartnett
2baf95e09d
Merge branch 'master' into ejh_turn_tests_on 2017-11-15 03:40:56 -07:00
Ed Hartnett
92a995e521
Merge branch 'master' into ejh_large_file_test_3 2017-11-15 03:39:42 -07:00
Ed Hartnett
e928964e9e
Merge branch 'master' into ejh_notbuilt_errors 2017-11-15 03:38:49 -07:00
Ed Hartnett
0e58aa412d fixed memory leak in tst_filterparser 2017-11-14 09:05:35 -07:00
Ward Fisher
16d6f94f30 Merge branch 'master' into filters.dmh 2017-11-13 11:15:02 -07:00
Ed Hartnett
03753c0344 now return NC_ENOTBUILT for not built library features 2017-11-13 08:09:15 -07:00
Ed Hartnett
cb32451cf5 turned on some commented out test code 2017-11-10 05:01:32 -07:00
Ed Hartnett
df31f07830
Merge branch 'master' into ejh_make_j_3 2017-11-10 02:53:07 -07:00
Ward Fisher
a9dde277d7 Merge branch 'ejh_enum_mem_fix' of https://github.com/NetCDF-World-Domination-Council/netcdf-c into more_ejh_pulls 2017-11-09 16:11:17 -07:00
Ed Hartnett
e792d992b1 fixed names of output files to enable parallel builds 2017-11-09 07:21:00 -07:00
Ed Hartnett
b9911d6e6f took out most uses of EXTRA_TESTS, returned it to disabled by default 2017-11-08 13:25:23 -07:00
Ed Hartnett
6653eeaf7f
Merge branch 'master' into ejh_turn_tests_on 2017-11-07 18:35:16 -07:00
Ed Hartnett
a72d5b4d16
Merge branch 'master' into ejh_enum_mem_fix 2017-11-07 18:34:55 -07:00
Ward Fisher
e7fee3ee53 Corrected an issue encountered by the default compiler on ARM. 2017-11-07 15:19:07 -07:00
Ward Fisher
b92ae0cdbc Merge branch 'ejh_fix_use_cdf' of https://github.com/NetCDF-World-Domination-Council/netcdf-c into more_ejh_pulls 2017-11-07 14:14:10 -07:00
Ed Hartnett
c58bc3e41c fixed warnings 2017-11-06 06:06:47 -07:00
Ed Hartnett
7af77fd6a9
Merge branch 'master' into ejh_turn_tests_on 2017-11-05 10:09:08 -07:00
Ed Hartnett
6ce15853d6 fixed ENABLE_CDF5 issue in some tests 2017-11-05 09:06:48 -07:00
Ed Hartnett
7872785cf0
Merge branch 'master' into ejh_enum_mem_fix 2017-11-03 19:44:40 -06:00
Ward Fisher
f98635be1b Merge remote-tracking branch 'origin/h5offset.dmh' into dmh_multi_merge 2017-11-03 12:40:52 -06:00
Ed Hartnett
b257353b18 fixed commented out tests 2017-11-03 08:14:08 -06:00
Ed Hartnett
406e979fb4 fixed tst_enums memory issue 2017-11-01 04:31:12 -06:00
Ed Hartnett
86f35ea6db
Merge branch 'master' into ejh_more_mem_3 2017-10-30 07:34:52 -06:00
Dennis Heimbigner
2d77e6451b Master merge 2017-10-28 14:06:39 -06:00
Dennis Heimbigner
261ed4c99d Merge branch 'master' into h5offset.dmh 2017-10-27 12:33:17 -06:00
Ed Hartnett
9f72f5adf4 fixed memory error in tst_fills2.c 2017-10-27 06:26:36 -06:00
Ed Hartnett
22d3d152f0 removed tst_h_atts2.c 2017-10-26 04:55:30 -06:00
Ed Hartnett
30ef103a95 moved tests from tst_h_atts2 into tst_xplatform2 2017-10-26 04:49:57 -06:00
Ward Fisher
8e30bb9a1c Merge branch 'ejh_test_mem_leak' of https://github.com/NetCDF-World-Domination-Council/netcdf-c into merge_small_pulls 2017-10-25 11:01:25 -06:00
Ward Fisher
fb38f81243 Merge branch 'ejh_ncdump' of https://github.com/NetCDF-World-Domination-Council/netcdf-c into merge_small_pulls 2017-10-25 11:00:20 -06:00
Dennis Heimbigner
9983b9d911 re e-support UBS-599337
re pull request https://github.com/Unidata/netcdf-c/pull/405
re pull request https://github.com/Unidata/netcdf-c/pull/446

Notes:
1. This branch is a cleanup of the magic.dmh branch.
2. magic.dmh was originally merged, but caused problems with parallel IO.
   It was re-issued as pull request https://github.com/Unidata/netcdf-c/pull/446.
3. This branch + pull request replace any previous pull requests and magic.dmh branch.

Given an otherwise valid netCDF file that has a corrupted header,
the netcdf library currently crashes. Instead, it should return
NC_ENOTNC.

Additionally, the NC_check_file_type code does not do the
forward search required by hdf5 files. It currently only looks
at file position 0 instead of 512, 1024, 2048,... Also, it turns
out that the HDF4 magic number is assumed to always be at the
beginning of the file (unlike HDF5).
The change is localized to libdispatch/dfile.c See
https://support.hdfgroup.org/release4/doc/DSpec_html/DS.pdf

Also, it turns out that the code in NC_check_file_type is duplicated
(mostly) in the function libsrc4/nc4file.c#nc_check_for_hdf.

This branch does the following.
1. Make NC_check_file_type return NC_ENOTNC instead of crashing.
2. Remove nc_check_for_hdf and centralize all file format checking
   NC_check_file_type.
3. Add proper forward search for HDF5 files (but not HDF4 files)
   to look for the magic number at offsets of 0, 512, 1024...
4. Add test tst_hdf5_offset.sh. This tests that hdf5 files with
   an offset are properly recognized. It does so by prefixing
   a legal file with some number of zero bytes: 512, 1024, etc.
5. Off-topic: Added -N flag to ncdump to force a specific output dataset name.
2017-10-24 16:25:09 -06:00
Ed Hartnett
1e3831f98d fixed memory leak and warnings in test 2017-10-24 12:54:29 -06:00
Ed Hartnett
6363cae315 fixed warnings 2017-10-24 12:18:20 -06:00
Ed Hartnett
d6eb9f9f5c fix for tst_vars.c memory overflow 2017-10-24 09:20:41 -06:00
Dennis Heimbigner
0b87770dab add files to git 2017-10-10 16:38:35 -06:00
Dennis Heimbigner
111248e067 Changed to make little-endian the standard for 64-bit parameters 2017-10-10 11:21:01 -06:00
Dennis Heimbigner
5ff3909704 Fix bug in nc4file.c where it improperly handled filters with more than 4 parameters. 2017-10-09 21:24:56 -06:00
Dennis Heimbigner
733da154c5 1. Keep up to date by merging master
2. Factored out the parameter string parsing for ncgen and nccopy
   int libdispatch/dfilter.c + include/ncfilter.h
3. Allow a parameter string to use constant types other than
   unsigned int. See docs/filters.md for details.
4. Moved the old content of  include/netcdf_filter.h into include/netcdf.h
   and removed include/netcdf_filter.h as no longer needed.
5. Force the test filter (bzip2) in nc_test4/filter_test to
   be built using BUILT_SOURCES.
2017-10-08 15:56:45 -06:00
Dennis Heimbigner
3cc3b6a4a1 add known szip file against which to test 2017-09-04 18:37:13 -06:00
Dennis Heimbigner
dab3d0da8e Fix CMake problem with executable naming 2017-08-30 12:06:23 -06:00
Dennis Heimbigner
d8d4ed627a master merge 2017-08-29 18:05:46 -06:00
Dennis Heimbigner
2e1e39ca8c Add a general szip test script 2017-08-28 18:11:24 -06:00
Dennis Heimbigner
e2b2d6cf6c Add more comprehensive tests 2017-08-28 14:56:01 -06:00
Dennis Heimbigner
99e4250d6d Get szip working under cmake 2017-08-27 20:38:37 -06:00
Dennis Heimbigner
9afef60648 Add tst_szip to Cmake 2017-08-27 15:51:45 -06:00
Dennis Heimbigner
ed44fd7306 Add szip support via libaec 2017-08-27 13:35:20 -06:00
Dennis Heimbigner
5085df7595 1. Add discussion of parameter encoding, esp in face of byte-order,
to docs/filter.md
2. Moved location of filter.md in documentation
3. Add a template file as the basis for building new filters.
4. Did some test case cleanup
2017-08-21 19:54:06 -06:00
Dennis Heimbigner
86fc8745dc merge master and resolve conflicts 2017-08-12 15:50:31 -06:00
Dennis Heimbigner
7f31358ee2 As a result of helping a user trying to build the filter test on
a linux variant system, I made some changes to (one hopes)
incorporate some improvements in documenting and building this test.
2017-07-25 15:57:00 -06:00
Ward Fisher
f1f7224f93 Corrected a false positive. 2017-06-01 09:36:54 -06:00
Ward Fisher
1f96a66414 hdf4 chunking file rename 2017-06-01 09:15:41 -06:00
Ward Fisher
a077289464 Refactored hdf4 chunking test a little bit. 2017-06-01 09:11:52 -06:00
Ward Fisher
08f7d06eb6 Refactoring hdf4 chunking test in similar fashion to hdf5 compatibility test. Files are linked via AC_CONFIG_LINKS instead of shuffling things around in a shell script. 2017-06-01 09:02:31 -06:00
Ward Fisher
128fb5611a Trying distcleanfiles experiment. 2017-06-01 08:53:31 -06:00
Ward Fisher
df872ac1bc Continued refactoring. 2017-05-31 16:34:46 -06:00
Ward Fisher
05e2ff3881 Sorting out hdf4 chunk tests. 2017-05-31 15:09:26 -06:00
Ward Fisher
5699a32376 Updated cleanfiles list on Makefile.am 2017-05-31 15:01:02 -06:00
Ward Fisher
9823d73c44 Corrected a logic error. 2017-05-31 14:04:53 -06:00