mirror/netcdf-c
2
0
Fork 0
mirror of https://github.com/Unidata/netcdf-c.git synced 2025-01-12 15:45:21 +08:00
Code Issues Packages Projects Releases Wiki Activity
8,777 Commits 90 Branches 75 Tags 88 MiB
9c33cfc62c
Commit Graph

276 Commits

Author SHA1 Message Date
Ward Fisher
8c91f7e57c Coverity 711708, first instance. 2014-08-22 15:25:27 -06:00
Ward Fisher
a28b123ca4 Coverity: 1198196 2014-08-08 15:22:46 -06:00
Ward Fisher
6c071be031 Corrected issues where functions were not available in Windows. Specifically strndup. Also accomodated an included needed for getcwd. 2014-08-07 17:03:27 -06:00
Ward Fisher
948eb1f357 Coverity: 1204252 2014-08-01 10:55:34 -06:00
Ward Fisher
db67d9a6f6 Coverity 1152156 2014-07-31 16:42:28 -06:00
Ward Fisher
02a7d451bc Coverity 711880 Case #2 2014-07-29 11:28:44 -06:00
Ward Fisher
171dd2fc8e Coverity issue 711880 2014-07-29 11:24:25 -06:00
Ward Fisher
2cce056ce9 Addressed coverity issue 711901 2014-07-29 10:50:01 -06:00
Ward Fisher
37c5338a86 Fixed a static-analysis identified issue related to a variable without a value. 2014-07-09 13:08:14 -06:00
Dennis Heimbigner
39a5bf5efa Modify ncdap_test/test_nstride_cached.c 
to use a dataset on remotetest instead
of an external server.
 2014-07-01 10:39:18 -06:00
Dennis Heimbigner
645da599da conflicts 2014-06-26 16:42:13 -06:00
Dennis Heimbigner
641c982c8c synch with git/oc 2014-06-26 16:40:08 -06:00
dmh
ecec75fcb2 make0 2014-06-25 22:18:22 -06:00
Ward Fisher
7f812b367e Manual merge of pull request https://github.com/Unidata/netcdf-c/pull/64 contributed by nschloe. Assorted CMake improvements. 2014-06-11 15:51:31 -06:00
dmh
ed068ef643 Fix misc. typos from previous commit 2014-06-02 14:02:34 -06:00
dmh
774428f2fd There are a number of cases in the oc code 
where a procedure is defined to return int
and really returns OCerror. This causes
problems in AIX. Fixed those I could find.
 2014-05-08 14:13:51 -06:00
dmh
ed5a504417 Fix int/enum conversion bug: re esupport (TXX-867549) 2014-05-06 13:10:59 -06:00
Ward Fisher
e599edaec1 Fixed a declaration error in Visual Studio. 2014-04-23 13:29:39 -06:00
Ward Fisher
a8aac6f568 Corrected a null dereference error. 2014-04-18 19:13:34 -06:00
Ward Fisher
b34956e06e Fixed clang-reported issue: dereference of undefined pointer value. 2014-04-18 17:02:58 -06:00
dmh
98d27e838d [NCF-299] 
When a .dodsrc file is present, and
specifies user name and password,
it is being ignored after the first time.

Fix required a major rewrite of ocrc.c because
it was mishandling a number of .dodsrc entries.
 2014-04-16 14:08:12 -06:00
dmh
4346b01c19 note jna problem 2014-04-15 21:25:44 -06:00
dmh
fb00c88763 fix bugs introduced by previous coverity fixes 2014-04-07 14:01:40 -06:00
dmh
389d2ea394 fix some coverity complaints 2014-04-07 13:00:47 -06:00
Ward Fisher
76e5e0f1fa Addressed several minor issues revealed by static analysis (coverity, clang). Mostly to do with extreme corner cases in which a null pointer would be dereferenced, or dereferencing a non-null (but non-initialized) pointer would result in garbage. 2014-03-28 17:11:26 -06:00
Ward Fisher
de08275c1c Added checks for CURLOPT_USERNAME and CURLOPT_PASSWORD. If they are not found, CURLOPT_USERPWD is used instead. This is important because, on some Windows systems, libcurl does not provide CURLOPT_USERNAME or CURLOPT_PASSWORD. 2014-03-17 15:57:44 -06:00
dmh
b524e151ef Remove last vestiges of thredds-test 2014-03-14 14:07:35 -06:00
dmh
c7086dd04b Add support to detect authorization errors to DAP 2014-03-11 11:58:22 -06:00
dmh
a189b98b0b 1. Any test that references nctestserver/NC_findtestserver 
should be under ENABLE_DAP_REMOTE_TESTS.
   Fixed to make sure that this is so.
   Also attempted to fix ncdap_test/CMakeLists.txt,
   but probably got it wrong.
   HT to Nico Schlomer.
2. Attempted to reduce the number of conversion errors
   when -Wconversion is set. Fixed oc2, but
   rest of netcdf remains to be done.
   HT to Nico Schlomer.
3. When doing #2, I discovered an error in ncgen.y
   that has remained hidden. This required some other
   test case fixes.
 2014-03-08 20:41:30 -07:00
Ward Fisher
fcb0eb2df6 Corrected an error preventing netcdf from compiling. 2014-03-03 15:36:19 -07:00
dmh
ba726d55ce synch with oc2.0 2014-03-03 13:43:47 -07:00
Quincey Koziol
d033f9f6ff Clean up Coverity warnings from last checkin. 2014-02-20 08:24:55 -06:00
Quincey Koziol
4bfd9b27a0 Merge remote-tracking branch 'upstream/master' 
Conflicts:
	libdap2/common34.c
	oc2/ocutil.c
 2014-02-11 17:26:09 -06:00
dmh
8541a32175 [NCF-284]/ ZQX-155900 
Some servers do not properly
implement the current DAP2 spec.
It turns out that this server is one of those:
    http://nomads.ncep.noaa.gov:9090/
When a reference such as this is made:
    http://nomads.ncep.noaa.gov:9090/dods/gens/gens20140123/gep_all_12z?prmslmsl[0][0][0][0:359]
tt is returning this:
Dataset {
    float prmslmsl[ens=1][time=1][lat=1][lon=360];
} gens%2fgens20140123%2fgep_all_12z;

when it should be returning this:
Dataset {
  Structure {
    float prmslmsl[ens=1][time=1][lat=1][lon=360];
  } prmslmsl;
} gens%2fgens20140123%2fgep_all_12z;

The reason is that when picking fields out of a grid,
one must maintain the fully qualified name, so the grid
is converted to an enclosing structure.

It turns out that the problem was that
when I create the new structure node, I was
improperly linking it into the existing graph.
This caused a null pointer failure.
Fix is to make sure the relevant field (node->root)
is set.
 2014-01-24 13:26:00 -07:00
dmh
75adeae78b add some debug info about packet contents 2014-01-21 13:04:52 -07:00
dmh
0fa9dc98eb synch oc 2014-01-21 12:50:15 -07:00
Ward Fisher
2957645985 Addressed a coverity issue of minor importance. 2014-01-15 12:48:21 -07:00
Quincey Koziol
cd71eb525c Corrected "BAIL" macros to avoid infinite loop when logging is disabled and an 
error occurs after an "exit:" label.

Corrected a dozen Coverity errors (mainly allocation issues, along with a few
    other things):
        711711, 711802, 711803, 711905, 970825, 996123, 996124, 1025787,
        1047274, 1130013, 1130014, 1139538

Refactored internal fill-value code to correctly handle string types, and
    especially to allow NULL pointers and null strings (ie. "") to be
    distinguished.  The code now avoids partially aliasing the two together
    (which only happened on the 'write' side of things and wasn't reflected on
    the 'read' side, adding to the previous confusion).

    Probably still weak on handling fill-values of variable-length and compound
    datatypes.

Refactored the recursive metadata reads a bit more, to process HDF5 named
    datatypes and datasets immediately, avoiding chewing up memory for those
    types of objects, etc.

Finished uncommenting and updating the nc_test4/tst_fills2.c code (as I'm
    proceeding alphabetically through the nc_test4 code files).
 2013-12-29 01:12:43 -06:00
Ward Fisher
0af7499eb4 Added a couple items to .gitignore. 
Corrected an issue reported by Coverity static analysis where memory was allocated but was not freed.
 2013-12-04 16:02:43 -07:00
Quincey Koziol
e66e6e2b3a Merge remote-tracking branch 'upstream/master' 2013-11-30 23:24:44 -06:00
Ward Fisher
d484b9ac33 Corrected two possible ‘uninitialized variable’, ‘dereference null pointer’ bugs identified via clang static analysis. 2013-11-27 17:03:59 -06:00
Ward Fisher
1d007eb101 Addressed a number of minor bugs reported by Clang. 2013-11-20 13:37:21 -07:00
dmh
d6061db87d define mode_t when under windows 2013-11-15 15:41:17 -07:00
dmh
baed147ba4 [NCF-277] 
Fix Http Basic Authorization.
The problem is really in oc2.0.
In order for it to work,
the CURLOPT_COOKIEJAR must have
a non-null value. The code
was already there, but not being
used for some reason.
1. fixed cookiejar code in oc2.0
2. synched oc2.0 with netcdf-c/oc2
3. added a test case
 2013-11-15 11:38:54 -07:00
dmh
2bc308432d sync with oc2.0 2013-11-14 15:13:20 -07:00
Quincey Koziol
7a4479be6b Minor cleanups to reduce warnings in headers, and switch from MPI_BYTE to MPI_INT 
for MPI_Allreduce() call.
 2013-09-14 13:19:58 -05:00
Ward Fisher
71e8ed54cd Addressed Coverity issue 711904, 'Insecure temporary file'. 2013-08-14 11:21:18 -06:00
Ward Fisher
f51f97546b Addressed Coverity issue 752015, resource leak. 2013-08-14 09:51:10 -06:00
Ward Fisher
f43bf8f1da Addressed a handful of issues identified by 
Coverity static analysis.
 2013-08-05 20:36:33 +00:00
Dennis Heimbigner
beba09e70b 1. The duplicate name checking in oc2 was 
effectively o(n cubed); modified to be
   o(n squared).
2. If the list of prefetched variables is too long,
   (something on the order of 400 variables), then
   the server may reject it. Modified code so that
   in the case that the set of prefetch'd vars is
   the in fact all variables, it does not create a long
   request. This does not actually solve the problem
   if the prefetch list is long, but not all inclusive.
 2013-07-27 20:54:50 +00:00
Dennis Heimbigner
fcecd1a2bc 1. The duplicate name checking in oc2 was 
effectively o(n cubed); modified to be
   o(n squared).
2. If the list of prefetched variables is too long,
   (something on the order of 400 variables), then
   the server may reject it. Modified code so that
   in the case that the set of prefetch'd vars is
   the in fact all variables, it does not create a long
   request. This does not actually solve the problem
   if the prefetch list is long, but not all inclusive.
 2013-07-27 20:20:13 +00:00
Dennis Heimbigner
9979a2fa60 Synch with oc2.0 2013-06-26 21:46:54 +00:00
Dennis Heimbigner
628aed80d9 1. synch changes with oc2.0 
2. Fix a bug in ncgen to
   catch a special case of a malformed
   datalist.
 2013-06-26 18:55:30 +00:00
Ward Fisher
33d3d06971 Added initial 'make dist', 'make distcheck' support to 
CMake-based builds.
 2013-06-03 16:42:04 +00:00
Ward Fisher
da16fc1cde Fixed an issue with Windows builds 
not compiling due to how
ssize_t was being detected/defined.
 2013-05-24 21:19:07 +00:00
Dennis Heimbigner
228e8439d2 1. The code to parse a constraint 
was losing the initial double quote
for a quoted string.
2. The code in ncuri.c was not properly
   handling occurrences of e.g. %xx
 2013-05-16 21:37:58 +00:00
Dennis Heimbigner
254c0e7c96 Historically 
ncgen3 and ncgen
have treated 
uppercase atomic types
the same as lower case.
Change so upper case are no
longer allowed.

Also, synch oc.
 2013-05-15 17:37:04 +00:00
Dennis Heimbigner
de34ed2d5b merge from netcdf/trunk prior to merge back to trunk 2013-05-11 19:37:38 +00:00
Dennis Heimbigner
3b0fb5bd82 Synch oc2 with baseline oc2.0 2013-05-11 19:36:31 +00:00
Dennis Heimbigner
c583f91992 merge with trunk and fix conflicts 2013-05-10 17:04:28 +00:00
Ward Fisher
10807379c3 Merging from CMake branch in preparation for 4.3.0 release. 2013-04-29 20:15:57 +00:00
Ward Fisher
67f96188ff Merged latest from netCDF-cmake branch in preparation for 4.3.0 release. 2013-04-23 21:50:07 +00:00
Ward Fisher
b113f6f8b6 Merged a handful of changes from netcdf-cmake branch. 
Addressed the following coverity issues:

711762
711763
711766
711788
711933
711934
711935
 2013-04-16 23:02:54 +00:00
Ward Fisher
405f8bf827 2013-04-01 23:05:45 +00:00
Ward Fisher
9f187a1484 Merged the fix for NCF-29 from Quincy into the trunk. 2013-03-26 18:57:26 +00:00
Dennis Heimbigner
c659633d2e merge from trunk 2013-03-26 16:45:02 +00:00
Dennis Heimbigner
4e41843740 1) fix some minor bugs when pnetcdf is enabled 2)Comment out some apparently unused procedures 2013-03-25 17:12:50 +00:00
Dennis Heimbigner
9b4db7a039 Make some things static that do not need to be externally visible 2013-03-24 17:33:17 +00:00
Ward Fisher
f26a4a559a Merged latest from netcdf-cmake branch. 
Addressed several cmake-related issues, in terms of
building on Windows.  Also added XGetopt.c to 
EXTRA_dist in Makefile.am files.
 2013-03-19 22:40:15 +00:00
Dennis Heimbigner
665c2c33b2 synchronize oc2 with oc2.0 2013-03-15 21:44:59 +00:00
Dennis Heimbigner
dea3c726c8 merge trunk into this branch 2013-03-15 20:31:07 +00:00
Ward Fisher
ceb736c4b5 Corrected bug introduced via typo. Bug identified 
by Coverity. Thanks, Coverity!
 2013-03-14 23:23:36 +00:00
Ward Fisher
6096f6b43b Merged changes from CMake branch. 
Addressed a handful of memory leaks
reported by Coverity.
 2013-03-14 22:49:21 +00:00
Dennis Heimbigner
c18c90b012 removed some unused local variables 2013-03-12 20:45:58 +00:00
Dennis Heimbigner
6cf31dcf2d jira: NCF-232: bad conversion of grids 2013-02-26 04:31:06 +00:00
Ward Fisher
ddf3c31bb0 Corrected a handful of syntax issues in CMake config files, 
probably introduced more.  

Added CMake-related files to Makefile.am files for inclusion
when creating a distribution package.
 2013-02-20 23:28:28 +00:00
Ward Fisher
12b7ac7048 o Improved package_source support in CMake-based builds. 
o Corrected an issue related to uninitialized variables
which caused test failures on 2 test systems under
very specific circumstances.
 2013-02-19 23:29:41 +00:00
Dennis Heimbigner
70186d5329 Fix bug in dataError when no error message is found 2013-02-11 23:32:46 +00:00
Dennis Heimbigner
4109174d00 Add quick check for Error {...} at start of the datadds data part 2013-02-07 22:14:57 +00:00
Dennis Heimbigner
bf18c79ce4 include oc2/dap.y in the distribution 2013-01-31 03:34:59 +00:00
Dennis Heimbigner
2200f01f4d fix NCF-218: bug in oc2/dap.y parser 2013-01-30 22:56:12 +00:00
Ward Fisher
71a30406f7 Corrected 2 windows-specific errors when using Visual Studio: 
1. In nc4hdf.c, had a variable declaration located such
that Visual Studio complained and threw an error. Moved
to head of function.

2. Visual Studio was complaining about variable declarations
being made after OCVERIFY/OCDEREF macros.
 2013-01-29 23:33:59 +00:00
Dennis Heimbigner
460ac331e0 1)synchronize with original oc2 2) add some convenience functions 2013-01-29 21:22:05 +00:00
Ward Fisher
21523c8582 Merged changes from cmake branch. oc2 changes are just 
'file property' changes, not sure what exactly.
 2012-12-20 21:50:45 +00:00
Dennis Heimbigner
c11e78314e periodic sync of oc2 dir with the official oc2.0 repository 2012-12-18 21:08:23 +00:00
Dennis Heimbigner
c684a02d87 fix typo 2012-12-07 00:23:50 +00:00
Dennis Heimbigner
c114861e68 fix dfile.c error reporting 2012-12-06 21:17:36 +00:00
Ward Fisher
81280c7878 Merge from latest netcdf-cmake branch. 
- Fixes for Windows.
- CMake-based changes (functionality, tests).
- Smattering of coverity-informed bug-fixes.
 2012-12-05 18:35:42 +00:00
Ward Fisher
f844126d0e Addressed a buffer overrun issue; making the assumption this is an 
error. On the off chance it wasn't an error, a proper fix will be
formulated.
 2012-12-05 17:44:39 +00:00
Dennis Heimbigner
ec761ec8fb null=>NULL error 2012-12-04 23:32:32 +00:00
Dennis Heimbigner
97344d8551 make consistent with svn/oc2.0 2012-12-04 03:32:41 +00:00
Dennis Heimbigner
0803ba20ba fix Jira NCF-208; but note that this causes test.06 to fail because thredds mishandles grids 2012-11-21 23:57:42 +00:00
Ward Fisher
ff631c8156 Merged latest changes from cmake branch. 
o Improved CMake support.
o Cmake module compatibility (netcdf-config*.cmake.in).
 2012-11-19 21:43:12 +00:00
Ward Fisher
afa67452f6 Took some time to address a handful of errors identified by Coverity. 
Primarily focused on memory errors falling into a couple different types:

1) Static overrun errors.
2) Dereference uninitialized memory errors.

make distcheck works after applying these fixes, and coverity no longer sees an issue, so hopefully they are properly resolved.
 2012-11-14 18:24:45 +00:00
Ward Fisher
45f77090a1 Addressed a handful of minor 'fixed-length buffer overrun' 
errors identified by Coverity.  The fixes involved replacing calls
to strcpy, strcat with strncpy, strncat.
 2012-10-31 21:31:47 +00:00
Ward Fisher
95bb271925 A few changes related to MSVC builds slipped through the previous merge. 2012-09-28 23:02:35 +00:00
Ward Fisher
7a226dd3f1 Merging the win_netcdf branch into the trunk. 2012-09-27 22:50:41 +00:00
Ward Fisher
34efd517f9 2012-09-21 17:37:57 +00:00
Ward Fisher
405bcacdc9 Corrected an error on my part. 2012-09-20 21:19:34 +00:00
Ward Fisher
650c6fe362 Corrected MSVC-related issues with DAP. Renamed variables to avoid collision with reserved words, enclosed includes with appropriate ifdefs, other minor changes. 2012-09-20 16:31:31 +00:00
Ward Fisher
e55d002dbc Merged Dennis' changes from trunk. 2012-09-06 21:15:37 +00:00
Dennis Heimbigner
880b5c3f7e fix perf bug in bytebuffer code where setlength was always realloc'ing even when enough space was available 2012-08-30 16:43:34 +00:00
Ward Fisher
235fc6bb13 Merged latest trunk into branch 2012-08-22 19:52:24 +00:00
Dennis Heimbigner
29d3fe7d51 fix bug in reading a file url (needs to signal binary if possible) 2012-08-21 23:34:25 +00:00
Dennis Heimbigner
64a78ab239 added O_BINARY to open in ocread.c 2012-08-21 22:32:00 +00:00
Dennis Heimbigner
c47cd83c85 more debug for Ward's windows bug 2012-08-21 20:01:13 +00:00
Dennis Heimbigner
3c843c9578 add more debug output to try to find Ward's bug 2012-08-21 16:46:10 +00:00
Ward Fisher
e8453be1e5 Merged from trunk into branch 2012-08-20 18:30:04 +00:00
Dennis Heimbigner
5380aa5b67 update utilities: list,byte,hash,uri,log 2012-08-19 21:54:30 +00:00
Dennis Heimbigner
2a0d68c530 update nchashmap; move some old stuff in libdap2; fix new debug code 2012-08-19 21:12:35 +00:00
Dennis Heimbigner
685e1bf66a add extra debug about findbod 2012-08-17 20:51:03 +00:00
Ward Fisher
ffb7dc6f0d Merged latest trunk into branch 2012-08-13 19:57:51 +00:00
Dennis Heimbigner
d131258014 update oc2 2012-08-12 17:51:01 +00:00
Dennis Heimbigner
be5a7bbe71 update oc2 2012-08-12 17:40:08 +00:00
Ward Fisher
14619ec4c4 2012-08-09 18:40:41 +00:00
Ward Fisher
0607b62375 Added coverage test flags to CMakeLists.txt files. 2012-08-09 17:07:41 +00:00
Dennis Heimbigner
499f8d3a1c complete update of utilities: ncbyte, nclist, ncuri, nclog 2012-08-08 23:15:18 +00:00
Ward Fisher
02a1448dd1 2012-08-08 21:34:53 +00:00
Ward Fisher
402c4277e1 2012-08-08 21:29:57 +00:00
Ward Fisher
c8e9772237 2012-08-08 21:04:44 +00:00
Ward Fisher
c9fae163fb 2012-08-08 20:51:41 +00:00
Ward Fisher
a6c95c65b1 2012-08-08 19:45:38 +00:00
Ward Fisher
0a964ad8b1 Updated CMake files, added a few changes to fix linux-based compile warnings. 2012-08-07 21:34:55 +00:00
Ward Fisher
751c41928a Additional CMake changes. 2012-08-03 22:24:29 +00:00
Dennis Heimbigner
bc3a732e25 fix e-support YOP-841363 plus a number of coverity found bugs 2012-08-02 18:43:21 +00:00
Dennis Heimbigner
42999f4c7c move from oc1.0 to oc2.0; create new dir oc2 2012-07-31 20:34:13 +00:00