Commit Graph

11 Commits

Author SHA1 Message Date
Dennis Heimbigner
4db4393e69 Begin changing over to use strlcat instead of strncat because
strlcat provides better protection against buffer overflows.

Code is taken from the FreeBSD project source code. Specifically:
https://github.com/freebsd/freebsd/blob/master/lib/libc/string/strlcat.c
License appears to be acceptable, but needs to be checked by e.g. Debian.

Step 1:
1. Add to netcdf-c/include/ncconfigure.h to use our version
   if not already available as determined by HAVE_STRLCAT in config.h.
2. Add the strlcat code to libdispatch/dstring.c
3. Turns out that strlcat was already defined in several places.
   So remove it from:
	ncgen3/genlib.c
	ncdump/dumplib.c
3. Define strlcat extern definition in ncconfigure.h.
4. Modify following directories to use strlcat:
	libdap2 libdap4 ncdap_test dap4_test
   Will do others in subsequent steps.
2017-11-23 10:55:24 -07:00
posophe
14b399f803 codecleanup 2015-04-18 13:07:04 +02:00
Ward Fisher
091a4f3c0c Suppressing a coverity false-positive. 2014-08-01 14:25:24 -06:00
Ward Fisher
5eaddf0212 Addressed an out-of-bound array access issue. 2014-05-13 09:50:04 -06:00
Ward Fisher
46c11d494f Corrected an issue introduced on Windows. 2014-04-23 13:50:55 -06:00
Ward Fisher
e11f22312e Fixed a declaration error in Visual Studio. 2014-04-23 13:43:36 -06:00
Ward Fisher
a4f6cfa1c3 Corrected clang-reported issue: Static array bounds overrun. 2014-04-21 10:49:39 -06:00
Ward Fisher
bb84fda8cf Removed a couple of clang-reported potential dereferences of null/undefined pointers. 2014-03-31 09:56:39 -06:00
Russ Rew
508ee74874 In load.c, follow autoconf recommendations for including config.h (www.gnu.org/software/autoconf/manual/autoconf-2.64/html_node/Configuration-Headers.html) 2013-10-25 12:46:31 -06:00
Ward Fisher
7b91248723 Merged changes from netcdf-branch.
o Changed variable names 'typeid' to 'typeid1' to avoid a namespace conflict
in visual studio.
o Cleaned up a handful of warnings in Visual Studio.
o Addressed a few Coverity-discovered issuesl
o Made changes to CMake-based builds.
2012-12-13 22:09:41 +00:00
Ed Hartnett
18f4bca367 moving to trunk subdir 2010-06-03 13:24:43 +00:00