Commit Graph

8720 Commits

Author SHA1 Message Date
Edward Hartnett
a0d58c6820 fixed missing NC_HAS_QUANTIZE 2022-04-10 08:21:11 -06:00
Edward Hartnett
0b044b180e fixing some nc_test builds when --enable-pnetcdf is not used 2022-04-10 07:36:34 -06:00
Edward Hartnett
7849955976 fixing some nc_test builds when --enable-pnetcdf is not used 2022-04-10 07:30:49 -06:00
Edward Hartnett
1dbc0e7b05 fixing some nc_test builds when --enable-pnetcdf is not used 2022-04-10 07:21:11 -06:00
Edward Hartnett
2b26121537 fixed problems running mpi-enabled tests with --enable-pnetcdf in nc_test 2022-04-09 14:27:13 -06:00
Edward Hartnett
d4d4e28ac9 now running MPI-enabled tests with mpiexec for parallel I/O builds 2022-04-09 14:18:36 -06:00
Edward Hartnett
be0de4c95c fixing some issuses of pnetcdf tests in nc_test 2022-04-09 13:56:59 -06:00
Edward Hartnett
f077e4a2a8 fixing some issuses of pnetcdf tests in nc_test 2022-04-09 13:52:29 -06:00
Edward Hartnett
336b7d7222 turning off tests that depend on ncpathcvt when --disable-utilities is used 2022-04-09 13:28:01 -06:00
Edward Hartnett
0cfc4370da untabified 2022-04-09 11:41:40 -06:00
Edward Hartnett
a7e1734568 adding pnetcdf 2022-04-09 11:32:43 -06:00
Ward Fisher
4ad45457d2
Merge pull request #2253 from DennisHeimbigner/daptestfixes.dmh
Clean up some ncdap tests.
2022-04-07 16:57:41 -06:00
Ward Fisher
0b60b72232
Merge branch 'main' into daptestfixes.dmh 2022-04-07 16:57:35 -06:00
Dennis Heimbigner
9f78be8bb8 Allow the read/write of JSON-valued Zarr attributes.
A number of other packages that read/write Zarr insert
attributes whose value is a dictionary containing specialized
information.  An example is the GDAL Driver convention (see
https://gdal.org/drivers/raster/zarr.html).

In order to handle such attributes, this PR enforces a special
convention. It applies to both pure Zarr an NCZarr format as
written by the netdf-c library.

The convention is as follows:

## Reading
Suppose an attribute is read from *.zattrs* and it has a JSON
value that is a a dictionary.  In this case, the JSON dictionary
is converted to a string value.  It then appears in the netcdf-c
API as if it is a character valued attribute of the same name,
and whose value is the "stringified" dictionary.

# Writing
Suppose an attribute is of type character and its *value* *looks like*
a JSON dictionary. In this case, it is parsed to JSON
and written as the value of the attribute in the NCZarr file.
Here the *value* is the concatenation of all the characters
in the attributes netcdf-c value.
The term "looks like" means that the *value*'s first character is
"{", its last value is "}", and it can be successfully parsed
by a JSON parser.

A test case, *nczarr_test/run_jsonconventions.sh* was also added.

## Misc. Unrelated Changes

1. Fix an error in nc_test4/tst_broken_files.c
2. Modify the internal JSON parser API.
3. Modify the nczarr_test/zisjson program is modified to support
   this convention.
2022-04-06 18:22:59 -06:00
Dennis Heimbigner
56167a7775 final 2022-04-06 17:16:40 -06:00
Dennis Heimbigner
d5798aff2e testing 2022-04-06 15:57:17 -06:00
Dennis Heimbigner
90fe06592e ckp 2022-04-06 15:54:42 -06:00
Dennis Heimbigner
7b3128b3e4 update file permission 2022-04-06 15:54:19 -06:00
Ward Fisher
e6853c24f0
Merge pull request #2273 from edwardhartnett/ejh_par
turning on parallel I/O tests in CI
2022-04-06 14:44:02 -06:00
Dennis Heimbigner
cd3fa1b361 restrict the json convention to dictionaries only 2022-04-06 11:42:51 -06:00
Dennis Heimbigner
8be0782c39 Describe JSON attribute convention 2022-04-06 11:04:22 -06:00
Ward Fisher
127c139618
Merge pull request #2263 from wkliao/vpath
vpath build: use top_srcdir
2022-04-05 16:57:27 -06:00
Ward Fisher
ac5c2f55c1
Merge pull request #2277 from WardF/gh2222.wif
Conflict resolution
2022-04-05 11:44:45 -06:00
Edward Hartnett
9dc2947856 fixed makefile 2022-04-05 11:06:55 -06:00
Ward Fisher
3446aa0c13 Merge branch 'winutf8.dmh' of https://github.com/DennisHeimbigner/netcdf-c into gh2222.wif 2022-04-05 10:46:22 -06:00
Ward Fisher
7958a5b330
Merge pull request #2270 from wkliao/mpi_fix
avoid type redefine of MPI_Comm and MPI_Info
2022-04-05 10:26:34 -06:00
Edward Hartnett
5f9a676363 turning on parallel tests 2022-04-05 09:38:02 -06:00
Edward Hartnett
bce16a73e1 turning off parallel tests? 2022-04-05 09:14:26 -06:00
Edward Hartnett
f515378f56 changed Makefile.am flags in examples/C 2022-04-05 06:04:50 -06:00
Edward Hartnett
99ce0e8cbc turning on parallel I/O tests in CI 2022-04-05 05:20:17 -06:00
wkliao
5230ae802e Compile dparallel.c only when parallel I/O is enabled 2022-04-01 23:11:28 -05:00
wkliao
01efbd79cf avoid type define MPI_Comm and MPI_Info
Also define NC_MPI_INFO only when parallel I/O is enabled.
2022-04-01 23:10:19 -05:00
Ward Fisher
4366db8ac1
Merge pull request #2269 from WardF/gh2232.wif
Resolve conflict in generated file
2022-04-01 17:27:39 -06:00
Ward Fisher
2ccdf14697 Merge branch 'csz_bitround' of https://github.com/nco/netcdf-c into gh2232.wif 2022-04-01 10:43:34 -06:00
Ward Fisher
cd421ee92d
Merge pull request #2260 from wkliao/NC_EDIMSCALE
use NC_EDIMSCALE for errors related to dimscale
2022-04-01 10:17:18 -06:00
Ward Fisher
e1cc95434b
Merge pull request #2267 from DennisHeimbigner/nanfix.dmh
Fix typo "Nan" -> "NaN"
2022-03-31 14:50:54 -06:00
Dennis Heimbigner
dab1c36650 Fix typo "Nan" -> "NaN"
re: issue https://github.com/Unidata/netcdf-c/issues/2265

The zarr code is generating "Nan" instead of "NaN" on windows.
This causes failures.
Solution: fix typo.
2022-03-30 13:27:55 -06:00
Ward Fisher
ce0446baeb
Merge pull request #2266 from WardF/gh2170.wif
Correct conflict in #2170
2022-03-30 10:42:27 -06:00
Ward Fisher
0164512b0f Merge branch 'tinyxml2.dmh' of https://github.com/DennisHeimbigner/netcdf-c into gh2170.wif 2022-03-29 11:31:31 -06:00
Ward Fisher
9273aafedf
Merge pull request #2262 from wkliao/echo
use AC_MSG_WARN/AC_MSG_NOTICE instead of echo
2022-03-29 11:14:03 -06:00
Ward Fisher
79f30b375f
Merge pull request #2264 from WardF/gh2261.wif
Fix parallel build issue, add Parallel Tests Github Actions
2022-03-29 10:41:36 -06:00
Ward Fisher
6649d74ff8 Merge branch 'nc4var.c' of https://github.com/wkliao/netcdf-c into gh2261.wif 2022-03-28 14:04:06 -06:00
Ward Fisher
40412e6db5 Correct compiler issue with parallel one-off test. 2022-03-28 13:55:02 -06:00
Ward Fisher
2f3b7fc922 Correct dependency chain for Github Actions. 2022-03-28 13:45:10 -06:00
Ward Fisher
7d76990596 Added first pass at a parallel github actions one-off 2022-03-28 13:43:07 -06:00
Ward Fisher
418c7c86c5 Reconfiguring the Ubuntu Github Actions test. 2022-03-28 13:32:04 -06:00
Dennis Heimbigner
13dd15b76c minor fix 2022-03-28 10:04:18 -06:00
wkliao
15c75bf5d3 vpath build: use top_srcdir 2022-03-27 17:37:43 -05:00
wkliao
300aa5c84e use AC_MSG_WARN/AC_MSG_NOTICE instead of echo 2022-03-27 17:35:39 -05:00
wkliao
548a33a4f2 fix a compile error 2022-03-27 17:33:41 -05:00