There were several HDF5_PLUGIN_PATH that did not have the underscore escaped. A few other symbols with similar issues.
Fixed some code blocks that appeared broken on my markdown viewer... Not sure if that is the case in general.
There was a HDF5_PLUGIN_DIR referenced near the bottom. I think it was supposed to be _PATH, but could be wrong since there are multiple _DIR and _PATH througout the code and scripts...
The configuration of the `nc-config` file uses some symbols that were not defined until later in the file. This caused the quantize and zstd support lines to be incorrect.
re: Issue https://github.com/Unidata/netcdf-c/issues/2939
The problem managing inter-dependent options.
I was looking for certain cases of the form, where x and y are options.
````
if( not x and y)
message(warning "not x => not y)
endif
````
However in a couple of cases (including the referenced Issue), I was only testing this:
````
if( not x)
message(warning "not x => not y)
endif
````
Fix is to correct the tests.
As suggested by Ward, I ensured that this PR supports
read backward compatibility with old key format.
This addition also adds a test case for this.
## Misc. Other Changes
* Remove some unused code
* Cleanup json error handling
* Fix some more unsigned/signed conversions warning
As discussed in a netcdf meeting, convert NCZarr V2 to store all netcdf-4 specific info as attributes. This improves interoperability with other Zarr implementations by no longer using non-standard keys.
## Other Changes
* Remove support for older NCZarr formats.
* Update anonymous dimension naming
* Begin the process of fixing the -Wconversion and -Wsign-compare warnings in libnczarr, nczarr_test, and v3_nczarr_test.
* Update docs/nczarr.md
* Rebuild using the .y and .l files
The NETCDF_ENABLE_SET_LOG_LEVEL_FUNC option is apparently not used, but
is effectively used to set NETCDF_ENABLE_SET_LOG_LEVEL.
This is not clear from the build files CMakeLists.txt and configure.ac.
So this PR cleanups the code to make it more clear what is going on.
Already skipped on MinGW, so I don't feel bad skipping it on Cygwin too. Still haven't figured out why it's crashing. I should probably look into why Autotools is fine.
