re: Issue https://github.com/Unidata/netcdf-c/issues/2868
There are three parameters (zero, one, and two) that are currently
used in testing, but should not be. Parameters zero and one
are ignored by the code and parameter two is the typesize
parameter that either takes on the value 0 or 4 (== sizeof(int)).
See nc_test4/tst_specific_filters.sh.
Unfortunately, these three parameters differ depending on the blosc library.
The solution is to force them to a specific value -- namely 0,0,0 --
in the test script.
Problem was basically that the test file ref_oldformat.zip
was incorrect. Additionally, logic in zsync.c was incorrect.
### Misc. other fixes
1. Turn off accidental debug output
re: Issue https://github.com/Unidata/netcdf-c/issues/2952
The documentation -- such as it is -- is lost inside
docs/auth.md. So, create docs/quickstart_env.md to describe how
.rc file mechanism is used, and include the netcdf-c API. Also
add list of environment variables used by the netcdf-c library.
As discussed in a netcdf meeting, convert NCZarr V2 to store all netcdf-4 specific info as attributes. This improves interoperability with other Zarr implementations by no longer using non-standard keys.
## Other Changes
* Remove support for older NCZarr formats.
* Update anonymous dimension naming
* Begin the process of fixing the -Wconversion and -Wsign-compare warnings in libnczarr, nczarr_test, and v3_nczarr_test.
* Update docs/nczarr.md
* Rebuild using the .y and .l files
# Description
Remove various obsolete build options. Also do some code movement.
## Specific Changes
* The remotetest server is sometimes unstable, so provide a mechanism
to force disabling calls to remotetest.unidata.ucar.edu.
This is enabled by adding a repository variable named
REMOTETESTDOWN with the value "yes".
* Fix CMakeLists.txt to use the uname command as an alternate
to using the hostname command (which does not work under cygwin).
* Remove the JNA stuff as obsolete
* Remove the ENABLE_CLIENTSIDE_FILTERS options since it has been
disabled for a while.
* Fix bad option flag in some github action .yml files: change --disable-xml2 to --disable-libxml2
* Collect globalstate definitions into nc4internal.h
* Remove ENABLE_NCZARR_FILTERS_TESTING option as obsolete and replace
with ENABLE_NCZARR_FILTERS
* Move some dispatcher independent functions from libsrc4/nc4internal.c to libdispatch/ddispatch.c
* As a long term goal, and because it is now the case that --enable-nczarr
=> USE_NETCDF4, make the external options --enable-netcdf-4 and
--enable-netcdf4 obsolete in favor of --enable-hdf5
We will do the following for one more release cycle.
1. Make --enable-netcdf-4 be an alias for --enable-netcdf4.
2. Make --enable-netcdf4 an alias for --enable-hdf5.
3. Internally, convert most uses of USE_NETCDF_4 ad USE_NETCDF4 to USE_HDF5
After the next release, --enable-netcdf-4 and --enable-netcdf4 will
be removed.
# Primary Change
In order to conform to the cmake overhaul, occurrences of
ENABLE_XXX options in the nczarr code have been changed to
NETCDF_ENABLE_XXX.
# Misc. Other changes
* Fix use of rand_s in libdispatch/ncrandom.c
* Fix some bugs in the mingw gitub action.
* Fix signature bug in libncpoco/cp_win32.c
* Make some NCZarr fixes to config.h.cmake.in
re: https://github.com/Unidata/netcdf-c/issues/2780
As noted in the above issue, changing the NC_OBJ.id field
type from size_t to int reduces irrelevant warning.
There is no semantic effect since the number of distinct ids
will never approach the max positive integer value.
Note that this could change in the future if the id becomes
more than a simple counter.
