Commit Graph

8694 Commits

Author SHA1 Message Date
Dennis Heimbigner
6ae3289701 I made a major update to this PR with the following changes:
## Overwriting
I think I solved the file overwrite problem by doing light name
mangling of the shared library names. With this change the probabilty
is very small that installing our filter wrappers in a directory will
overwrite code produced by others.

## Default Install Location
I have setup the --with-plugin-dir option default to install in
the following locations in order of preference

1. If HDF5_PLUGIN_PATH is defined (at build time remember), then the last directory in that path will be where the filter wrapper shared libraries will be installed.
2. Otherwise the default is "/usr/local/hdf5/lib/plugin" (on *nix*) or "%ALLUSERSPROFILE%\\hdf5\\lib\\plugin" for Windows or Mingw.

Currently, --with-plugin-dir is disabled by default.
I should note that even if I enable it by default, installing
netcdf-c will still not run "out of the box" because the hypothetical
naive user will not know which compressor libraries need to be
pre-installed before netcdf is installed. Nor will that user have any
way to find out what needs to be installed.
2022-05-19 22:00:40 -06:00
Dennis Heimbigner
9e18d791df Merge branch 'master' into install.dmh 2022-05-19 21:39:23 -06:00
Dennis Heimbigner
3ea5d3bfb6 Merge remote-tracking branch 'Unidata/main' 2022-05-19 15:37:35 -06:00
Ward Fisher
1e637c677d
Merge pull request #2352 from WardF/macos_gh2349.wif
Removed precision fiddling on OSX
2022-05-19 13:44:34 -06:00
Ward Fisher
defa153370 Removed precision fiddling with OSX to correct issues that resulted in remote testing. Also integrated the one-line change from https://github.com/Unidata/netcdf-c/pull/2347, which is proving problematic (for some reason). 2022-05-19 12:28:43 -06:00
Dennis Heimbigner
9925b2074f Merge remote-tracking branch 'Unidata/main' 2022-05-18 12:43:28 -06:00
Ward Fisher
8c6ab4bf0c
Merge pull request #2339 from catenacyber/leak
fix memory leak in genc_netcdf
2022-05-17 16:46:03 -06:00
Ward Fisher
0586b64521
Merge pull request #2335 from edwardhartnett/ejh_szip_constants
fixed missing szip constants in netcdf.h
2022-05-17 16:45:47 -06:00
Ward Fisher
1ce7e79ce1
Merge pull request #2321 from edwardhartnett/ejh_nc_config_cleanup
added some entries to nc-config
2022-05-17 16:45:08 -06:00
Ward Fisher
326bdc4934
Merge pull request #2305 from Alexander-Barth/isnan-mingw32
use isnan instead of _fpclass on non-MSVC compilers
2022-05-17 16:44:41 -06:00
Dennis Heimbigner
e05f5c36a8 Merge master 2022-05-17 15:11:31 -06:00
Dennis Heimbigner
29717c88b7 Merge remote-tracking branch 'Unidata/main' 2022-05-17 13:58:48 -06:00
Ward Fisher
6e8e1c3ece
Merge pull request #2278 from DennisHeimbigner/jsonconvention.dmh
Allow the read/write of JSON-valued Zarr attributes.
2022-05-17 13:25:21 -06:00
Ward Fisher
771b959cad
Merge branch 'main' into jsonconvention.dmh 2022-05-17 13:24:53 -06:00
Ward Fisher
1e19d4d64d
Merge pull request #2257 from DennisHeimbigner/alwaysxarray.dmh
Turn on the xarray convention for NCZarr format
2022-05-17 13:23:50 -06:00
Ward Fisher
375e5adfe4
Merge branch 'main' into alwaysxarray.dmh 2022-05-17 13:23:19 -06:00
Dennis Heimbigner
5e5b1b5ba4 Update release notes 2022-05-14 16:08:56 -06:00
Dennis Heimbigner
7b09290a3a Improve filter installation process to avoid use of an extra shell script
re: https://github.com/Unidata/netcdf-c/issues/2338
re: https://github.com/Unidata/netcdf-c/issues/2294

In issue https://github.com/Unidata/netcdf-c/issues/2338,
Ed Hartnett suggested a better way to install filters to a user
defined location -- for Automake, anyway.

This PR implements that suggestion. It turns out to be more
complicated than it appears, so there are fair number of changes;
mostly to shell scripts. Most of the change is in plugins/Makefile.am.

NOTE: this PR still does NOT address the use of HDF5_PLUGIN_PATH
as the default; this turns out to be complex when dealing with NCZarr.
So this will be addressed in a subsequent post 4.9.0 PR.

## Misc. Changes
1. Record the occurrences of incomplete codecs in libnczarr so that
   they can be included in _Codecs attribute correctly. This allows
   users to see what missing filters are referenced in the Zarr file.
   Primarily affects libnczarr/zfilter.[ch]. Also required creating a
   new no-effect filter: H5Zunknown.c.
2. Move the unknown filter test to a separate test file.
3. Incorporates PR https://github.com/Unidata/netcdf-c/pull/2343
2022-05-14 16:05:48 -06:00
Dennis Heimbigner
0dd076919f Merge remote-tracking branch 'Unidata/main' 2022-05-13 14:17:50 -06:00
Ward Fisher
bfd33b20ac
Merge pull request #2345 from WardF/link_fix.wif
Correct links for gliderscope and netcdfninja in software.html
2022-05-12 15:08:29 -06:00
Ward Fisher
e5f1d0846b correct links for gliderscope and netcdfninja in software.html 2022-05-12 15:07:42 -06:00
Dennis Heimbigner
8eb0712eb6 final1 2022-05-09 14:45:06 -06:00
Dennis Heimbigner
3e2f32a4bc update 2022-05-09 14:23:28 -06:00
Dennis Heimbigner
bd9a2d9641 Merge branch 'jsonconvention.dmh' into jsonconvention.tmp 2022-05-09 12:44:31 -06:00
Dennis Heimbigner
5b400442ff Merge branch 'master' into jsonconvention.dmh 2022-05-09 12:43:52 -06:00
Dennis Heimbigner
f2d3f52efb Merge remote-tracking branch 'Unidata/main' 2022-05-05 15:16:02 -06:00
Ward Fisher
c147bdd7b6
Merge pull request #2336 from edwardhartnett/ejh_doc_4
remove all-error-codes.md
2022-05-05 14:08:32 -06:00
Edward Hartnett
c3d201a8b9
Merge branch 'main' into ejh_doc_4 2022-05-05 08:16:40 -06:00
Philippe Antoine
71f6dbd78a fix memory leak in genc_netcdf 2022-05-05 15:13:23 +02:00
Dennis Heimbigner
83ffd5f474 Merge remote-tracking branch 'Unidata/main' 2022-05-04 20:01:52 -06:00
Ward Fisher
2404731793
Merge pull request #2249 from DennisHeimbigner/updatedocs.dmh
Update selected documentation
2022-05-04 17:02:42 -06:00
Ward Fisher
821f69f669
Merge branch 'main' into updatedocs.dmh 2022-05-04 17:01:06 -06:00
Ward Fisher
ee7039c3c2
Merge pull request #2318 from DennisHeimbigner/filterinstall.dmh
Support installation of standard pre-built filters into user-specified location
2022-05-04 17:00:03 -06:00
Ward Fisher
a7ea050ebb
Merge pull request #2293 from skosukhin/no-strict-aliasing-config-fix
Fix configure check for the -fno-strict-aliasing flag
2022-05-04 16:49:44 -06:00
Edward Hartnett
7a61c9a8d4 added netcdf_filter.h to doxygen build 2022-05-04 13:12:48 -06:00
Edward Hartnett
955b77f831 removed all-error-codes.md 2022-05-04 10:05:38 -06:00
Edward Hartnett
d1cbd60960 fixed missing szip constants in netcdf.h 2022-05-04 09:48:46 -06:00
Edward Hartnett
0d7cbf1911 doxygen for filter functions 2022-05-04 08:04:54 -06:00
Edward Hartnett
6849f44896 more doxygen warning fixes 2022-05-03 12:54:14 -06:00
Edward Hartnett
14e80b4673 fixing doxygen warnings 2022-05-03 09:41:45 -06:00
Edward Hartnett
1b0ca07a3c added nc4cache.c to list of doxygen input files 2022-05-03 08:56:02 -06:00
Dennis Heimbigner
663c17ce26 Merge remote-tracking branch 'Unidata/main' 2022-05-02 12:57:15 -06:00
Ward Fisher
6d4464b47e
Merge pull request #2324 from WardF/gh2323.wif
#2323 plus mpi_count error message
2022-05-02 10:33:36 -06:00
Ward Fisher
6bb0cf7fbe Merge remote-tracking branch 'upstream/main' into gh2323.wif 2022-05-02 10:30:07 -06:00
Ward Fisher
8b1640a445
Merge pull request #2323 from edwardhartnett/ejh_par_test
We are incorrectly running tst_parallel_zlib on 1 processor - it should only ever run on 4
2022-05-02 10:29:53 -06:00
Ward Fisher
9800478f04 Added error message. 2022-05-02 09:55:08 -06:00
Ward Fisher
eac41c78fc Merge branch 'ejh_par_test' of https://github.com/edwardhartnett/netcdf-c into gh2323.wif 2022-05-02 09:53:54 -06:00
Dennis Heimbigner
1776959d5a retest 2022-05-01 13:20:03 -06:00
Dennis Heimbigner
444024a7be Merge branch 'master' into jsonconvention.dmh 2022-05-01 13:16:58 -06:00
Dennis Heimbigner
909884ffb3 cleanup 2022-04-30 21:54:00 -06:00