Commit Graph

7 Commits

Author SHA1 Message Date
Dennis Heimbigner
4c92fc3405 Remove netcdf-4 conditional on the dispatch table.
Partially address: https://github.com/Unidata/netcdf-c/issues/1056

Currently, some of the entries in the dispatch table
are conditional'd on USE_NETCDF4.

As a step in upgrading the dispatch table for use
with user-defined tables, we remove that conditional.
This means that all dispatch tables must implement the
netcdf-4 specific functions even if only to make them
return NC_ENOTNC4. To simplify this, a set of default
functions are defined in libdispatch/dnotnc4.c to provide this
behavior. The file libdispatch/dnotnc3.c is also relevant to
this.

The primary fix is to modify the various dispatch tables to
remove the conditional and use the functions in
libdispatch/dnotnc4.c as appropriate. In practice, all of the
existing tables are prepared to handle this, so the only
real change is to remove the conditionals.

Misc. Unrelated fixes
1. Fix some annoying warnings in ncvalidator.

Notes:
1. This has not been tested with either pnetcdf or hdf4 enabled.
   When those are enabled, it is possible that there are still
   some conditionals that need to be fixed.
2019-07-20 13:59:40 -06:00
Ed Hartnett
162685cd73 moved prototypes for NC_RO, NC_NOTNC3, and NC_NOTNC4 functions to netcdf_dispatch.h 2019-07-16 20:34:11 -06:00
Ed Hartnett
f5125a5b2e cleanup 2019-07-05 05:07:42 -06:00
Ed Hartnett
806ebc91b4 cleanup 2019-07-05 05:05:59 -06:00
Ed Hartnett
e6edc44439 cleanup 2019-07-05 05:04:07 -06:00
Ed Hartnett
72a000f4f9 moved dispatch table definition to netcdf_dispatch.h 2019-07-05 04:53:53 -06:00
Ed Hartnett
39ba4aae89 added netcdf_dispatch.h file 2019-07-05 04:50:36 -06:00