Ward Fisher
5ebc855ed6
Merge pull request #2462 from DennisHeimbigner/enumdfalt.dmh
...
Provide a default enum const when fill value does not match any enum constant
2022-07-27 09:20:15 -06:00
Ward Fisher
ba37c0af9f
Merge branch 'main' into enumdfalt.dmh
2022-07-26 15:23:40 -06:00
Ward Fisher
62ae05d6d0
Merge pull request #2457 from edwardhartnett/ejh_test_quantize_3
...
more quantize testing and adding pre-processor constant NC_MAX_FILENAME to nc_tests.h
2022-07-25 15:59:50 -06:00
Ward Fisher
717e022e80
Merge pull request #2463 from magnusuMET/bugfix/read_only
...
Prevent cmake writing to source dir
2022-07-19 13:43:21 -06:00
Ward Fisher
0de3062048
Merge pull request #2448 from DennisHeimbigner/twojsons.dmh
...
Ensure that netcdf_json.h does not interfere with ncjson.
2022-07-19 11:56:01 -06:00
Ward Fisher
8b583d18ca
Merge branch 'main' into twojsons.dmh
2022-07-19 11:16:04 -06:00
Magnus Ulimoen
aa394b5ebc
Prevent cmake writing to source dir
2022-07-19 15:55:42 +02:00
Dennis Heimbigner
eeb215bf4e
debug1
2022-07-17 14:43:59 -06:00
Dennis Heimbigner
b588855ea2
Update release notes
2022-07-17 14:38:54 -06:00
Dennis Heimbigner
65fd9fe1a5
Provide a default enum const when fill value does not match any enum const.
...
re: https://github.com/Unidata/netcdf-c/issues/982
It is possible to define an enum type that has no enum constant
with value zero. However, HDF5 has a default fill value of zero
that it used to fill all chunks. In the event that this situation
occurs, ncdump, say, will fail because there is no enum const
to print for the value zero.
The solution is to create a special enum constant called "_UNDEFINED"
that has the value zero. It is only used in the case that there is
no constant in the enum that already covers zero.
A test case is added in netcdf-c/ncdump to validate this solution.
Note: the changes occur primarily in libsrc4, so they also work for NCZarr.
2022-07-17 14:32:31 -06:00
Ward Fisher
64033e367d
Merge pull request #2460 from WardF/gh2446.wif
...
Guard _declspec(dllexport) in support of #2446
2022-07-11 14:42:21 -06:00
Ward Fisher
1975911aae
Guard _declspec(dllexport) in support of https://github.com/Unidata/netcdf-c/issues/2446
2022-07-11 14:09:57 -06:00
Edward Hartnett
f32890e1be
more testing of quantize
2022-07-08 14:58:52 -06:00
Edward Hartnett
a621ed4224
more testing of quantize
2022-07-08 13:33:23 -06:00
Edward Hartnett
31dfc1ce15
more testing of quantize
2022-07-08 13:29:56 -06:00
Edward Hartnett
8142189892
more testing of quantize
2022-07-08 13:27:18 -06:00
Edward Hartnett
99dbcad141
more testing of quantize
2022-07-08 13:21:51 -06:00
Edward Hartnett
cd1aa7b882
more testing of quantize
2022-07-08 13:15:23 -06:00
Edward Hartnett
d23d90e148
more testing of quantize
2022-07-08 12:48:46 -06:00
Edward Hartnett
82caba1f12
more quantize testing
2022-07-08 11:44:23 -06:00
Edward Hartnett
1a13b9ed09
more quantize testing
2022-07-08 10:35:38 -06:00
Edward Hartnett
6645cce1c9
more quantize testing
2022-07-08 09:44:38 -06:00
Edward Hartnett
2bfde9a5eb
more quantize testing
2022-07-08 08:55:48 -06:00
Edward Hartnett
4aa319f9dc
adding pre-processor constant NC_MAX_FILENAME to nc_tests.h
2022-07-08 07:27:54 -06:00
Ward Fisher
26c558203f
Merge pull request #2445 from edwardhartnett/ejh_fix_quantize
...
fix and test quantize mode for NC_CLASSIC_MODEL
2022-07-07 15:29:33 -06:00
Edward Hartnett
4b0f337dbc
Merge branch 'main' into ejh_fix_quantize
2022-07-07 11:16:32 -06:00
Dennis Heimbigner
31b24d767a
Fix bad cmake install location
2022-07-06 15:01:23 -06:00
Dennis Heimbigner
966a0c1a9f
Resolve conflict
2022-07-06 14:21:51 -06:00
Ward Fisher
ee5e1596f5
Merge pull request #2430 from DennisHeimbigner/cmakeplugin.dmh
...
Fix the way CMake handles -DPLUGIN_INSTALL_DIR
2022-07-06 09:09:13 -06:00
Dennis Heimbigner
f50007e21d
Update RELEASENOTES.md
2022-07-05 22:06:28 -06:00
Dennis Heimbigner
8b0e1134b4
Ensure that netcdf_json.h does not interfere with ncjson.
...
re: Issue https://github.com/Unidata/netcdf-c/issues/2419
There are effectively two json subsystems in netcdf-c.
1. ncjson.[ch] in libnetcdf
2. netcdf_json.h for use by plugins so they can be built without need
for libnetcdf.
The netcdf_json.h file is constructed from the concatenation of
ncjson.h plus ncjson.c. It turned out that in doing this, I was
leaving some symbols externally visible so that if, for some
reason, a plugin was built and needed libnetcdf, then symbol
conflicts arose.
The solution is to prefix the declarations in ncjson.[ch] with a
macro (OPTSTATIC) that can be resolved to either nothing or to
"static". Then in netcdf_json.h, it resolves to "static" and
prevents the symbol conflicts.
Note that netcdf_json.h is constructed once in
netcdf-c/include/Makefile.am with the rule named
"makepluginjson". This means that it is included in the
distribution. However, this also means that if ncjson.[ch] is
changed, then it is necessary to invoke makepluginjson
explicitly to rebuild netcdf_json.h
2022-07-05 22:03:52 -06:00
Ward Fisher
b2641a1fc5
Merge branch 'main' into cmakeplugin.dmh
2022-07-05 16:27:51 -06:00
Edward Hartnett
4e4209b6f0
code and documentation cleanup
2022-07-02 08:13:13 -06:00
Edward Hartnett
309d4bec35
code and documentation cleanup
2022-07-02 07:51:33 -06:00
Edward Hartnett
a2aeec8936
documentation
2022-07-02 06:19:52 -06:00
Edward Hartnett
536cdd28f9
fix and test quantize mode for NC_CLASSIC_MODEL
2022-07-02 06:14:32 -06:00
Ward Fisher
a00bb62167
Merge pull request #2439 from WardF/disable_quant_option.wif
...
Add `--disable-quantize` to configure
2022-07-01 10:05:35 -06:00
Ward Fisher
b6bdcacde7
Update release notes.
2022-06-30 14:44:09 -06:00
Ward Fisher
d1a3f6fbe6
configure.ac logic for disabling quantize.
2022-06-30 14:41:18 -06:00
Ward Fisher
a494ac50cd
Merge pull request #2438 from WardF/gh2271.wif
...
Updated CMakeLists to avoid corner case cmake error
2022-06-29 16:29:58 -06:00
Ward Fisher
f3426bc7d9
Updated CMakeLists to avoid the error described in https://github.com/Unidata/netcdf-c/issues/2271
2022-06-29 14:44:49 -06:00
Ward Fisher
5794ae4dd3
Merge pull request #2437 from WardF/gh2435.wif
...
Fix pnetcdf tests in cmake
2022-06-28 18:52:44 -06:00
Ward Fisher
9d44421024
Work in a one-line change as originally suggested in https://github.com/Unidata/netcdf-c/pull/2426 .
2022-06-28 16:58:24 -06:00
Ward Fisher
dfc47497e3
Make pnetcdf tests run in serial fashion when using cmake
2022-06-28 16:53:38 -06:00
Ward Fisher
ae0b5e7d8c
Merge branch 'main' into cmakeplugin.dmh
2022-06-28 16:38:31 -06:00
Ward Fisher
7d6d4b9b40
Fix a typo.
2022-06-28 16:31:15 -06:00
Ward Fisher
73a0d92f9d
Fix a typo.
2022-06-28 16:30:26 -06:00
Ward Fisher
e34f8d5dc0
Run one-off tests first.
2022-06-28 16:29:35 -06:00
Ward Fisher
ff34b66182
Fix cache check.
2022-06-28 16:27:23 -06:00
Ward Fisher
8637265e7f
Merge branch 'main' into gh2435.wif
2022-06-28 16:15:44 -06:00