Commit Graph

27 Commits

Author SHA1 Message Date
Dennis Heimbigner
f897b458ea Fix szip handling 2022-04-30 19:06:01 -06:00
Dennis Heimbigner
a8aa6e3db3 Remove debug 2022-04-29 14:38:18 -06:00
Dennis Heimbigner
126b3f9423 Support installation of filters into user-specified location
re: https://github.com/Unidata/netcdf-c/issues/2294

Ed Hartnett suggested that the netcdf library installation process
be extended to install the standard filters into a user specified
location. The user can then set HDF5_PLUGIN_PATH to that location.

This PR provides that capability using:
````
configure option: --with-plugin-dir=<absolute directory path>
cmake option: -DPLUGIN_INSTALL_DIR=<absolute directory path>
````

Currently, the following plugins are always installed, if
available: bzip2, zstd, blosc.
If NCZarr is enabled, then additional plugins are installed:
fletcher32, shuffle, deflate, szip.

Additionally, the necessary codec support is installed
for each of the above filters that is installed.

## Changes:
1. Cleanup handling of built-in bzip2.
2. Add documentation to docs/filters.md
3. Re-factor the NCZarr codec libraries
4. Add a test, although it can only be exercised after
   the library is installed, so it cannot be used during
   normal testing.
5. Cleanup use of HDF5_PLUGIN_PATH in the filter test cases.
2022-04-29 14:31:55 -06:00
Dennis Heimbigner
3ffe7be446 Enhance/Fix filter support
re: Discussion https://github.com/Unidata/netcdf-c/discussions/2214

The primary change is to support so-called "standard filters".
A standard filter is one that is defined by the following
netcdf-c API:
````
int nc_def_var_XXX(int ncid, int varid, size_t nparams, unsigned* params);
int nc_inq_var_XXXX(int ncid, int varid, int* usefilterp, unsigned* params);
````
So for example, zstandard would be a standard filter by defining
the functions *nc_def_var_zstandard* and *nc_inq_var_zstandard*.

In order to define these functions, we need a new dispatch function:
````
int nc_inq_filter_avail(int ncid, unsigned filterid);
````
This function, combined with the existing filter API can be used
to implement arbitrary standard filters using a simple code pattern.
Note that I would have preferred that this function return a list
of all available filters, but HDF5 does not support that functionality.

So this PR implements the dispatch function and implements
the following standard functions:
    + bzip2
    + zstandard
    + blosc
Specific test cases are also provided for HDF5 and NCZarr.
Over time, other specific standard filters will be defined.

## Primary Changes
* Add nc_inq_filter_avail() to netcdf-c API.
* Add standard filter implementations to test use of *nc_inq_filter_avail*.
* Bump the dispatch table version number and add to all the relevant
   dispatch tables (libsrc, libsrcp, etc).
* Create a program to invoke nc_inq_filter_avail so that it is accessible
  to shell scripts.
* Cleanup szip support to properly support szip
  when HDF5 is disabled. This involves detecting
  libsz separately from testing if HDF5 supports szip.
* Integrate shuffle and fletcher32 into the existing
  filter API. This means that, for example, nc_def_var_fletcher32
  is now a wrapper around nc_def_var_filter.
* Extend the Codec defaulting to allow multiple default shared libraries.

## Misc. Changes
* Modify configure.ac/CMakeLists.txt to look for the relevant
  libraries implementing standard filters.
* Modify libnetcdf.settings to list available standard filters
  (including deflate and szip).
* Add CMake test modules to locate libbz2 and libzstd.
* Cleanup the HDF5 memory manager function use in the plugins.
* remove unused file include//ncfilter.h
* remove tests for the HDF5 memory operations e.g. H5allocate_memory.
* Add flag to ncdump to force use of _Filter instead of _Deflate
  or _Shuffle or _Fletcher32. Used for testing.
2022-03-14 12:39:37 -06:00
Ward Fisher
b1b59e1760 Correct trigger event for mingw tests to pull_request from push' 2022-01-24 16:31:34 -07:00
Ward Fisher
a8c5307ed3 Removing cmake-based tests for now. 2022-01-24 16:23:42 -07:00
Ward Fisher
16115303a5 Missing pipe character. 2022-01-24 16:15:57 -07:00
Ward Fisher
05e207f5ca Syntax error. 2022-01-24 16:12:11 -07:00
Ward Fisher
acbbde16a1 Syntax error. 2022-01-24 16:10:51 -07:00
Ward Fisher
db98c57af6 HDF5 configuration diagnostic output 2022-01-24 16:09:39 -07:00
Ward Fisher
472e4c8b36 Oh right, Unix Makefiles 2022-01-24 16:02:45 -07:00
Ward Fisher
3058b760ad Force CMake to use gcc 2022-01-24 15:59:10 -07:00
Ward Fisher
7e1c770dff Adding hdf5 info for cmake-based tests. 2022-01-24 15:55:13 -07:00
Ward Fisher
f12eb2d0f9 Moving on to cmake-based github actions. 2022-01-24 15:47:27 -07:00
Ward Fisher
27db0f2354 More tweaks. 2022-01-24 15:21:29 -07:00
Ward Fisher
3c017da5e3 Collapse build and run test steps into a single step, no need to build all the tests before seeing if any fail. 2022-01-24 15:11:58 -07:00
Ward Fisher
3898d4f80a Remove stray text. 2022-01-24 13:18:05 -07:00
Ward Fisher
84070ad177 Next iteration of compilation test. 2022-01-24 13:08:55 -07:00
Ward Fisher
08598a761f Additional compilation work. 2022-01-24 12:20:04 -07:00
Ward Fisher
e8e3141cb1 Really simplify things. 2022-01-24 11:45:46 -07:00
Ward Fisher
0333da7be5 Clean up some Unix-related cruft. 2022-01-24 11:38:21 -07:00
Ward Fisher
ddd675a6d7 Temporarily disable cache 2022-01-24 11:30:14 -07:00
Ward Fisher
d0ad57fb3e Further developments unfolding. 2022-01-24 11:24:45 -07:00
Ward Fisher
d76fbe3fc2 Remove stray text. 2022-01-24 11:06:21 -07:00
Ward Fisher
3a12cee940 Working on MinGW/MSYS2 support. Attempting workflow with system-installed libhdf5 2022-01-24 11:05:33 -07:00
Ward Fisher
a6e7ad17a2 Added cmake to the mingw-based test. 2022-01-24 10:54:00 -07:00
Ward Fisher
4ad9f00493 Add skeleton mingw/msys2 Github CI tests. 2022-01-24 10:51:19 -07:00