Commit Graph

4389 Commits

Author SHA1 Message Date
Dennis Heimbigner
4db4393e69 Begin changing over to use strlcat instead of strncat because
strlcat provides better protection against buffer overflows.

Code is taken from the FreeBSD project source code. Specifically:
https://github.com/freebsd/freebsd/blob/master/lib/libc/string/strlcat.c
License appears to be acceptable, but needs to be checked by e.g. Debian.

Step 1:
1. Add to netcdf-c/include/ncconfigure.h to use our version
   if not already available as determined by HAVE_STRLCAT in config.h.
2. Add the strlcat code to libdispatch/dstring.c
3. Turns out that strlcat was already defined in several places.
   So remove it from:
	ncgen3/genlib.c
	ncdump/dumplib.c
3. Define strlcat extern definition in ncconfigure.h.
4. Modify following directories to use strlcat:
	libdap2 libdap4 ncdap_test dap4_test
   Will do others in subsequent steps.
2017-11-23 10:55:24 -07:00
Ward Fisher
64b500cf24
Merge pull request #665 from NetCDF-World-Domination-Council/ejh_ncdump_3
Autotools build system tweaks and fixes to get make -j check and make -j distcheck working
2017-11-21 18:16:33 -07:00
Ed Hartnett
b04cf4f83b fixed dist list to include ref_null_byte_padding_test.nc 2017-11-21 17:19:42 -07:00
Ward Fisher
f14b988ee9
Merge branch 'master' into ejh_ncdump_3 2017-11-21 15:55:15 -07:00
Ward Fisher
7d8f58a752
Merge branch 'master' into ejh_ncdump_3 2017-11-21 15:54:29 -07:00
Ward Fisher
ac440a2d06
Merge pull request #675 from Unidata/gh657
Address strict null byte padding
2017-11-21 15:40:43 -07:00
Ward Fisher
2341f9f2b4 Updated release notes 2017-11-21 12:49:14 -07:00
Ward Fisher
c17503dfab Corrected pathing oversight. 2017-11-21 12:17:32 -07:00
Ward Fisher
2ab3e56747 Added error message for new error NC_ENULLPAD. [skip ci] 2017-11-20 17:31:08 -07:00
Ward Fisher
cd3d5f8e0e Updated for expected failure. 2017-11-20 17:26:06 -07:00
Ward Fisher
95b9ef5ffe Added expected failure to cmake-based tests. 2017-11-20 17:02:16 -07:00
Ward Fisher
e97911a592 Updated v1hpg.c to make header padding with null byte checks optional. 2017-11-20 16:08:06 -07:00
Ward Fisher
a07eddd0e4 More wiring in of test. [ci skip] 2017-11-20 15:58:39 -07:00
Ward Fisher
01bfdbf767 Wired in test to autotools. 2017-11-20 15:06:10 -07:00
Ward Fisher
b11f6b4dea Added a small test file. 2017-11-20 13:52:20 -07:00
Ward Fisher
e8af76c2f4 Wiring in a quick test. 2017-11-20 13:52:06 -07:00
Ward Fisher
c27153edb6 Corrected an incorrect download link for Windows NC3-only binary 2017-11-20 13:43:16 -07:00
Ed Hartnett
c8a2d53d34 fixes HDF4 build with cmake 2017-11-20 08:25:47 -07:00
Ed Hartnett
096e0e19fc fixing cmake build 2017-11-20 05:34:17 -07:00
Ed Hartnett
2130e5dcfb fixing cmake build 2017-11-20 05:28:42 -07:00
Ed Hartnett
76cd491426 clean up 2017-11-19 06:56:44 -07:00
Ed Hartnett
87d59b80fb Makefile.am cleanup 2017-11-18 14:20:04 -07:00
Ed Hartnett
39916a105b added dependency 2017-11-18 09:28:25 -07:00
Ed Hartnett
d7c1dd82c3 fixed hdf4 test that should not run if utilities not built 2017-11-18 07:36:24 -07:00
Ed Hartnett
21053f5c49 clean up and removal of extra_tests 2017-11-17 15:35:14 -07:00
Ed Hartnett
bd556cd79f fix for make -j check in test_dap4 2017-11-17 12:35:07 -07:00
Ed Hartnett
9618937e69 cleanup of ncdump Makefile.am 2017-11-17 12:29:12 -07:00
Ed Hartnett
577ff47eff fixed dependency 2017-11-17 11:07:24 -07:00
Ed Hartnett
66ddc9dfb4 getting make -j check working 2017-11-17 10:49:06 -07:00
Ed Hartnett
812c2fd4d1 got make -j check working in ncdump and examples directories 2017-11-17 10:16:17 -07:00
Ed Hartnett
4a4a4fb7a0 make -j working for classic only in ncdump 2017-11-17 08:22:49 -07:00
Ed Hartnett
b993a21356 merges from master 2017-11-17 07:30:34 -07:00
Ed Hartnett
3bdf2801f6 working on cmake build 2017-11-16 17:57:22 -07:00
Ed Hartnett
7b4f17cb38 working on cmake build 2017-11-16 17:56:12 -07:00
Ed Hartnett
1a178582b9 working on cmake build 2017-11-16 17:54:30 -07:00
Ed Hartnett
2efdf55ad7 working on cmake build 2017-11-16 17:50:02 -07:00
Ed Hartnett
cd753be416 working on cmake build 2017-11-16 17:48:06 -07:00
Ed Hartnett
976a6e438e working on cmake build 2017-11-16 17:46:11 -07:00
Ed Hartnett
22a4898325 working on cmake build 2017-11-16 17:43:21 -07:00
Ed Hartnett
045a467029 working on cmake build 2017-11-16 17:32:19 -07:00
Ed Hartnett
0d517d5653 fixing CMake build 2017-11-16 17:14:48 -07:00
Ed Hartnett
693a47ad04 move C program invokations to scripts to clean up dependencies in build 2017-11-16 13:03:35 -07:00
Ed Hartnett
3b0c301d76 moved tst_bug324 in Cmake build from ncdump to nc_test4 2017-11-16 11:57:39 -07:00
Ed Hartnett
4f43b80320 moved test from ncdump to nc_test4 2017-11-16 11:30:35 -07:00
Ward Fisher
07ddccc2ac
Merge pull request #654 from wkliao/O3_bug
fix codes might break strict-aliasing rules
2017-11-16 11:03:51 -07:00
Ward Fisher
5e5dfc6f7b
Merge branch 'master' into O3_bug 2017-11-16 09:16:23 -07:00
Wei-keng Liao
9b511b4e0f fix codes might break strict-aliasing rules 2017-11-16 00:01:01 -06:00
Ed Hartnett
a9ba19b43c merged in changes from master 2017-11-15 12:57:11 -07:00
Ward Fisher
c7365a5183
Merge pull request #652 from NetCDF-World-Domination-Council/ejh_all_docs
Ejh all documentation PRs combined
2017-11-15 12:11:18 -07:00
Ed Hartnett
6be9db4703 merging branches into develop 2017-11-15 11:35:16 -07:00