Peter Hill
5f6def8b6b
Fix conditional that will always be true
...
`options->file` is allocated on the stack and so will never be `NULL`,
making this conditional always true. Instead, we want to check the
value of `file`. As `options` is allocated with `calloc`, we know that
`file` will be zero-initialised, and it's safe to just check the first
element
2023-11-30 14:11:58 +00:00
Peter Hill
fdff1eb123
Silence conversion warnings in nczarr tests
2023-11-30 14:11:56 +00:00
Peter Hill
507c8ab966
Remove some unneeded #ifdef
guards
...
`chunk_size` is only used if `PRINT_CHUNK_WASTE_REPORT` is
defined. Also move the declaration of `chunk_size` inside the `#ifdef`
to silence `set-but-unused` warning
2023-11-30 14:11:21 +00:00
Peter Hill
3f4967f216
Use built-in printf
hex format code
2023-11-30 14:11:21 +00:00
Ward Fisher
e4c174cb1a
Merge branch 'main' of github.com:WardF/netcdf-c
2023-11-28 10:08:20 -07:00
Peter Hill
4e1ff160e1
Change signature of nczm_sortenvv
to take size_t
...
Always called with a `size_t` and passes `n` to `qsort` which expects
a `size_t` anyway
2023-11-28 16:28:31 +00:00
Peter Hill
b05b9be9a1
Try to more consistently use size_t
for argument of nclistlength
2023-11-28 16:28:31 +00:00
Peter Hill
653e09fd6d
Try to more consistently use size_t
for nclistget
index argument
2023-11-28 16:28:31 +00:00
Dennis Heimbigner
58dd53022f
Fix some important bugs in various files
...
The most critical bug is in nch5s3comms.c.
I for some reason assumed that signing keys
did not contain any zero bytes. But obviously
it can, so a test was removed.
Other fixes:
1. Guarantee allocated memory is initialized to all zeros.
2. Cleanup errmsg handling in libncpoco.
3. Fix processing of aws list-objects-v2 because I misread the syntax.
2023-11-27 18:46:10 -07:00
Peter Hill
99f5ec3f24
Include header for size_t
in nclist.h
2023-11-27 09:22:29 +00:00
Peter Hill
d07dac918c
Silence conversion warnings from malloc
arguments
...
Mostly just add an explicit cast when calling `malloc` and its
variants. Sometimes instead change the type of a local variable if
this would silence multiple warnings.
2023-11-24 18:20:52 +00:00
Peter Hill
ffe4fd85ba
Use explicit casts in nc4_convert_type
to silence warnings
2023-11-24 16:46:58 +00:00
Ward Fisher
0c6fd78251
Merge pull request #2802 from seanm/UBSan-null
...
Fixed various UBSan warnings about working with NULL pointers
2023-11-20 16:43:36 -07:00
Ward Fisher
aa97f6be83
Merge remote-tracking branch 'upstream/main'
2023-11-17 15:18:53 -07:00
Ward Fisher
3a1b125f4d
Merge pull request #2788 from WardF/check-pr.wif
...
Tweaking PR to work with Visual Studio
2023-11-17 15:18:39 -07:00
Ward Fisher
e8be174475
Merge remote-tracking branch 'upstream/main'
2023-11-17 15:16:35 -07:00
Ward Fisher
9566a18100
Merge pull request #2800 from seanm/UBSan-misaligned
...
Fixed misaligned memory access flagged by UBSan
2023-11-17 15:15:01 -07:00
Ward Fisher
0d09cf8b97
Merge pull request #2765 from DennisHeimbigner/dap4ce.dmh
...
Improve fetch performance of DAP4
2023-11-16 12:22:20 -07:00
Ward Fisher
9fe1a346ba
Merge branch 'main' into dap4ce.dmh
2023-11-16 12:22:11 -07:00
Ward Fisher
d4e906fec0
Merge pull request #2803 from seanm/UBSan-utf8
...
Fixed various UBSan warnings about working with NULL pointers
2023-11-16 12:21:08 -07:00
Ward Fisher
d7b6ad0b65
Merge pull request #2789 from DennisHeimbigner/execinfo.dmh
...
Remove the execinfo capability
2023-11-15 15:54:44 -07:00
Ward Fisher
807c6ef3f9
Merge branch 'main' into execinfo.dmh
2023-11-15 15:54:35 -07:00
Ward Fisher
6d9c092e13
Merge remote-tracking branch 'upstream/main'
2023-11-15 15:41:00 -07:00
Ward Fisher
17cf532eb4
Merge pull request #2771 from DennisHeimbigner/tinyxmlupdate.dmh
...
Update internal tinyxml2 code to the latest version
2023-11-15 15:34:04 -07:00
Ward Fisher
33c77f3c59
Merge branch 'main' into tinyxmlupdate.dmh
2023-11-15 15:33:47 -07:00
Sean McBride
23aa46fcf5
Fixed various UBSan warnings about working with NULL pointers
...
Any pointer arithmetic with NULL pointers is technically UB, even if you don't end up dereferencing the pointer.
2023-11-15 15:11:56 -05:00
Ward Fisher
2767c4843b
Merge pull request #2795 from tbussmann/patch-1
...
disable test that depends on ncpathcvt in cmake build w/o utilities
2023-11-15 12:46:39 -07:00
Sean McBride
dc1b8b9c4b
Fixed various UBSan warnings about working with NULL pointers
...
Any pointer arithmetic with NULL pointers is technically UB, even if you don't end up dereferencing the pointer.
2023-11-15 14:28:24 -05:00
Sean McBride
374d654644
Fixed misaligned memory access flagged by UBSan
...
Use memcpy to copy correctly even for unaligned memory. This was already done for some functions here, but not all.
Also took the oppurtunity to remove a bunch of seemingly obsolete/commented code.
2023-11-14 19:14:33 -05:00
Ward Fisher
99f22954c5
Merge pull request #2787 from seanm/UBSan-shift
...
Fixed various UBSan warnings about invalid bit shifting
2023-11-14 16:55:24 -07:00
Ward Fisher
ce33d888a1
Add missing ERANGE_FILL to cmake-generated config.h. Include config.h in ncx.c.
2023-11-14 15:43:58 -07:00
Ward Fisher
16841a990d
Merge pull request #2782 from ZedThree/fix-float-conversions
...
Fix most float conversion warnings
2023-11-14 10:42:29 -07:00
Tobias Bussmann
99d0760c0d
disable test that depend on ncpathcvt in cmake build w/o utilities
...
fixes #2794
2023-11-09 00:39:16 +01:00
Ward Fisher
dd0aedcaa5
Merge pull request #2793 from WardF/fix_nczarr_libzip_dep.wif
...
Make ncZarr-specific deps and options dependent on ncZarr being enabled.
2023-11-07 14:47:51 -07:00
Ward Fisher
f1ada42b5d
Added fenceposts so that dependencies and options specific to nczarr are skipped if nczarr is not enabled.
2023-11-07 12:18:13 -07:00
Ward Fisher
f0e0e68ff1
Merge branch 'main' into check-pr.wif
2023-11-06 16:55:04 -07:00
Ward Fisher
9593dbfac9
Merge pull request #2790 from seanm/mmap-bsd
...
Renamed mmap variable, which conflicts with mmap() function on FreeBSD
2023-11-06 14:48:06 -07:00
Sean McBride
fb62738f72
Renamed mmap variable, which conflicts with mmap() function on FreeBSD
...
This fixes compiler errors on FreeBSD 14.
2023-11-06 16:05:24 -05:00
Dennis Heimbigner
6c99d07731
Update RELEASENOTES
2023-11-04 21:34:50 -06:00
Dennis Heimbigner
adea80f376
Remove the execinfo capability
...
re: Issue https://github.com/Unidata/netcdf-c/issues/2766
This attempt to programmatically dump stack never worked,
so it is time to kill it off.
2023-11-04 21:32:33 -06:00
Dennis Heimbigner
b10ab54b56
Update to latest master
2023-11-04 20:45:40 -06:00
Dennis Heimbigner
f878acf99e
fix memory leak
2023-11-04 20:23:55 -06:00
Dennis Heimbigner
f8cb89e679
ckp
2023-11-04 16:42:36 -06:00
Dennis Heimbigner
64111c7f5e
remove conflicts
2023-11-04 16:17:09 -06:00
Dennis Heimbigner
87497d79cf
update
2023-11-04 16:08:59 -06:00
Sean McBride
1162f64d2a
Fixed various UBSan warnings about invalid bit shifting
...
Just made sure to use unsigned, so that a bit does not get shifted into a sign bit.
2023-11-02 11:11:18 -04:00
Ward Fisher
e92404f11f
Add fenceposting so DLL flags are only introduced wwhen we are compiling DLL-based shared libraries.
2023-11-01 11:45:31 -06:00
Ward Fisher
b9adb697ac
Working to get the proposed change working with Visual studio
2023-11-01 11:35:52 -06:00
Ward Fisher
3385be8500
Merge branch 'main' into nczarr-tests-common-library
2023-10-30 15:10:43 -06:00
Ward Fisher
100dca4854
Merge pull request #2786 from Unidata/stray-lfs-character.wif
...
Remove stray character in cmake lfs tests for nczarr.
2023-10-30 13:17:37 -06:00