Commit Graph

8268 Commits

Author SHA1 Message Date
Edward Hartnett
5d3e7a5147 fixed warning in tst_h_files4.c 2021-08-03 01:53:12 -06:00
Ward Fisher
84f0696e7d
Merge pull request #2036 from Unidata/gh1983.wif
Address optimization issue
2021-07-29 11:15:29 -06:00
Ward Fisher
0bc8c2e9c3
Merge pull request #2040 from mathstuf/replace-invalid-utf8
ncexhash: replace invalid UTF-8 sequence
2021-07-28 11:16:55 -06:00
Ben Boeckel
2472cda4f0 ncexhash: replace invalid UTF-8 sequence 2021-07-28 12:51:30 -04:00
Ward Fisher
a89e259431 Added -fno-strict-aliasing to CFLAGS when the compiler supports it and cmake is in use. 2021-07-27 11:22:48 -06:00
Ward Fisher
a8001f03e1 Added -fno-strict-aliasing to CFLAGS when the compiler supports it and autotools are in use. 2021-07-27 11:16:58 -06:00
Ward Fisher
2cfd0cb1fe
Merge pull request #2034 from ArchangeGabriel/patch-1
libhdf5/H5FDhttp: add missing semicolons to H5Epush_ret
2021-07-22 14:26:56 -07:00
Ward Fisher
9f798e2ed6 Merge branch 'virtual_datasets' of https://github.com/d70-t/netcdf-c into gh1983.wif 2021-07-19 09:44:35 -07:00
Ward Fisher
7840f89500 Merge remote-tracking branch 'origin/master' into gh1983.wif 2021-07-19 09:11:23 -07:00
Ward Fisher
24330edc80
Merge pull request #2032 from DennisHeimbigner/newformat.dmh
Move to Version 2 NCZarr Extended Meta-Data
2021-07-19 09:09:01 -07:00
Ward Fisher
01718d7877
Merge branch 'master' into newformat.dmh 2021-07-19 09:08:45 -07:00
Ward Fisher
847c12e716
Merge pull request #2035 from DennisHeimbigner/badchunkpath.dmh
Fix chunk key when using dimension_separator - high priority
2021-07-19 09:07:33 -07:00
Dennis Heimbigner
8cdf5943ac Update RELEASE_NOTES 2021-07-18 19:42:26 -06:00
Dennis Heimbigner
6b28409b54 Fix chunk key when using dimension_separator
The construction of the chunk key is malformed
when using dimension_separator rather than always
using '/'.

This is a priority bug.
2021-07-18 19:38:02 -06:00
Dennis Heimbigner
9417055c3e Fix bad chunkpath calculation 2021-07-18 16:20:22 -06:00
Bruno Pagani
74fe2fe95b
libhdf5/H5FDhttp: add missing semicolons to H5Epush_ret
In HDF5 1.12.1, this was changed from optional to required per the changelog:

>H5Epush_ret() is a function-like macro that has been changed to
>contain a `do {} while(0)` loop. Consequently, a trailing semicolon
>is now required to end the `while` statement. Previously, a trailing
>semi would work, but was not mandatory.

This should be backward compatible with older version of HDF5.
2021-07-18 20:12:47 +00:00
Dennis Heimbigner
669fd34357 remove push 2021-07-18 13:37:51 -06:00
Dennis Heimbigner
27ce37febf Merge branch 'newformat.dmh' of https://github.com/DennisHeimbigner/netcdf-c into newformat.dmh 2021-07-18 13:36:51 -06:00
Dennis Heimbigner
7f61f6b43c undebug 2021-07-18 13:36:39 -06:00
Dennis Heimbigner
fef6353d0e Bad file reference 2021-07-17 20:32:43 -06:00
Dennis Heimbigner
73a94362dd Update RELEASE_NOTES 2021-07-17 16:58:19 -06:00
Dennis Heimbigner
d953899559 Move to Version 2 NCZarr Extended Meta-Data
re: https://github.com/zarr-developers/zarr-specs/issues/41

After discussions with the Zarr community, it was decided to
convert to a new representation of the NCZarr meta-data extensions: version 2.
These extensions store information necessary to mapping the Zarr data model
to the netcdf-4 data model.

The basic change is to remove the NCZarr specific objects: .nczarr, .nczgroup, .nczarray, and .nczattr.
The contents of these objects is moved into the corresponding existing Zarr objects as special keys. The mapping is as follows:

* ''.nczarr'' => ''/.zgroup/_NCZARR_SUPERBLOCK_''
* ''.nczgroup => ''.zgroup/_NCZARR_GROUP_''
* ''.nczarray => ''.zarray/_NCZARR_ARRAY_''
* ''.nczattr => ''.zattr/_NCZARR_ATTR_''

Backward compatibility is maintained by looking for the object ''/.nczarr''
and if found, then assuming that the dataset is in the older version 1 format.
This compatibility only supports reading of such version 1 datasets.

Documentation and test cases are also added.

Misc. Other Changes:
1. The json parsing code was added to the general library instead of nczarr only (ncjson.c, ncjson.h).
2. Improved support for different platform paths by allowing conversion
   to a single common path representation.
3. Add some new error codes.
4. Modify nccopy usage to mention the new chunking specification.
2021-07-17 16:55:30 -06:00
Ward Fisher
4aeafe2d3a Fix an accidentally-introduced bug. 2021-07-13 12:07:56 -06:00
Ward Fisher
30621b38d3 Eliminate a lot of 'result of operation is undefined or garbage' errors reported by static analysis. These errors appeared to be false positives as there was logic that should prevent their occurance, but it's possible that optimization would result in these error states occuring. 2021-07-12 16:40:27 -06:00
Ward Fisher
0451296574 Added explicit initialization to address some potential issues raised by clang static analysis. 2021-07-09 13:48:35 -06:00
Ward Fisher
907e300e3e Merge remote-tracking branch 'origin/master' into gh1983.wif 2021-07-08 14:52:23 -06:00
Ward Fisher
2ba84ea2b3
Merge pull request #2028 from Unidata/gh2027.wif
Fix in support of https://github.com/Unidata/netcdf-c/issues/2027
2021-07-06 12:14:36 -06:00
Ward Fisher
b6c3568ec0 Fix in support of https://github.com/Unidata/netcdf-c/issues/2027 2021-07-06 11:34:30 -06:00
Ward Fisher
e89b29c332
Merge pull request #2005 from DennisHeimbigner/dap4fixes2.dmh
Improve operation of the DAP4 code and fix bugs
2021-06-28 16:34:07 -06:00
Ward Fisher
8e3b74669c
Merge branch 'master' into dap4fixes2.dmh 2021-06-28 16:34:00 -06:00
Ward Fisher
e8303135bd
Merge pull request #2015 from gsjaardema/patch-48
Simply version check logic
2021-06-28 14:18:42 -06:00
Ward Fisher
b71f939895
Merge pull request #2001 from edwardhartnett/ejh_test
improved program nc_perf/tst_gfs_data_1.c
2021-06-28 14:06:03 -06:00
Ward Fisher
1a7ee7170a
Merge pull request #1972 from catenacyber/ossfuzz
Adds fuzz target for oss-fuzz integration
2021-06-17 14:32:48 -06:00
Ward Fisher
64eb7af64f Merge branch 'master' into gh1983.wif 2021-06-16 16:34:23 -06:00
Ward Fisher
b09461754f Turn verbose output on in nc_test. 2021-06-16 16:34:06 -06:00
Ward Fisher
cd39b9d2d8
Merge pull request #2019 from Unidata/gh2018.wif
Fixes portability issue with how echo was used in a shell script
2021-06-11 12:09:42 -06:00
Ward Fisher
ad11c54a79 Added a temporary fix in support of https://github.com/Unidata/netcdf-c/issues/2018. Also, fixed a missing reference file when using cmake-based build systems. 2021-06-09 15:55:11 -06:00
Ward Fisher
5b04247d71
Merge pull request #2016 from gsjaardema/patch-49
Clean up curl symbol tests
2021-06-08 16:26:03 -06:00
Ward Fisher
1ee604a3a7
Merge pull request #2017 from DennisHeimbigner/zarrfillv.dmh
NCZarr is outputting fill value as an array instead of a singleton.
2021-06-07 11:58:32 -06:00
Dennis Heimbigner
6f03935de4 Update release notes 2021-06-05 14:15:11 -06:00
Dennis Heimbigner
1c3e86440e NCZarr is outputting fill value as an array instead of a singleton.
re: https://github.com/Unidata/netcdf-c/issues/2008

The fill_value key in a .zarray should have a single value,
but it currently has a value that is a 1 element array.
Fix is to pull out the single element.

This occurred because the fill_value is taken from the _FillValue attribute,
and all netcdf attributes are stored as arrays, of length 1 in this case.

In a related change, any attribute with length 1 is now stored in .zattrs
as a singleton rather than an array of length 1. This make the generated
Zarr more consistent with other Zarr implementations.

Misc. other changes:

1. Fix bug in testpathcvt caused by the way various shells handle backslash escapes.
2. Fix bug in testauth where test for MSVC is wrong.
2021-06-05 14:12:21 -06:00
Greg Sjaardema
4a18f6b54e
Remove a debug print 2021-06-02 12:55:50 -06:00
Greg Sjaardema
31f0c80ade
Remove a debug print 2021-06-02 12:55:36 -06:00
Greg Sjaardema
477c4de95b
Clean up curl symbol tests
* Set `CMAKE_REQUIRED_INCLUDES` to include the path found for `curl.h`.  The `CHECK_C_SOURCE_COMPILES` function uses this and not the `INCLUDE_DIRECTORIES`

* Make the test for version 7.66 or later match the same test in `configure.ac`
* If the version is 7.66 or later, then we can skip the tests for the curl symbols which were all added in versions prior to 7.66.
* If the version is earlier than 7.66, then continue to perform the tests.
2021-06-02 12:54:05 -06:00
Greg Sjaardema
e755a08f11
Simply version check logic
We use the CMake `VERSION_LESS` test other places, might as well use it here and  eliminate another compile-based test.
2021-06-02 11:40:01 -06:00
Dennis Heimbigner
4bf58c65dd fix conflicts 2021-06-02 10:59:26 -06:00
Ward Fisher
94262989eb
Merge pull request #1991 from gsjaardema/eliminate_need_for_hdf5-1.6-API
Remove need for HDF5-1.6 API being defined
2021-06-01 16:36:28 -06:00
Ward Fisher
384e77d9fe
Merge pull request #2012 from DennisHeimbigner/dimscope.dmh
Regularize the scoping of dimensions
2021-06-01 16:28:12 -06:00
Ward Fisher
7446311dfd
Merge pull request #2014 from Unidata/fix-makedist.wif
Another PR to fix 'make distcheck' issues that had crept in.
2021-06-01 15:26:23 -06:00
Ward Fisher
cab3743568 Added missing file. 2021-06-01 15:05:42 -06:00