There were several HDF5_PLUGIN_PATH that did not have the underscore escaped. A few other symbols with similar issues.
Fixed some code blocks that appeared broken on my markdown viewer... Not sure if that is the case in general.
There was a HDF5_PLUGIN_DIR referenced near the bottom. I think it was supposed to be _PATH, but could be wrong since there are multiple _DIR and _PATH througout the code and scripts...
The configuration of the `nc-config` file uses some symbols that were not defined until later in the file. This caused the quantize and zstd support lines to be incorrect.
re: Issue https://github.com/Unidata/netcdf-c/issues/2939
The problem managing inter-dependent options.
I was looking for certain cases of the form, where x and y are options.
````
if( not x and y)
message(warning "not x => not y)
endif
````
However in a couple of cases (including the referenced Issue), I was only testing this:
````
if( not x)
message(warning "not x => not y)
endif
````
Fix is to correct the tests.
As suggested by Ward, I ensured that this PR supports
read backward compatibility with old key format.
This addition also adds a test case for this.
## Misc. Other Changes
* Remove some unused code
* Cleanup json error handling
* Fix some more unsigned/signed conversions warning
As discussed in a netcdf meeting, convert NCZarr V2 to store all netcdf-4 specific info as attributes. This improves interoperability with other Zarr implementations by no longer using non-standard keys.
## Other Changes
* Remove support for older NCZarr formats.
* Update anonymous dimension naming
* Begin the process of fixing the -Wconversion and -Wsign-compare warnings in libnczarr, nczarr_test, and v3_nczarr_test.
* Update docs/nczarr.md
* Rebuild using the .y and .l files
The NETCDF_ENABLE_SET_LOG_LEVEL_FUNC option is apparently not used, but
is effectively used to set NETCDF_ENABLE_SET_LOG_LEVEL.
This is not clear from the build files CMakeLists.txt and configure.ac.
So this PR cleanups the code to make it more clear what is going on.
Already skipped on MinGW, so I don't feel bad skipping it on Cygwin too. Still haven't figured out why it's crashing. I should probably look into why Autotools is fine.
re: Issue https://github.com/Unidata/netcdf-c/issues/2927
The NC_s3sdkinitialize NC_s3sdkfinalize functions were
misplaced. They should have been moved from ds3util.c to
ncs3sdk_h5.c. When using ncs3sdl_aws.cpp, this resulted in a
duplicate definition.
Also, found and fixed a memory leak in the NCZarr S3 code.
* main: (29 commits)
ftp --> resources
Update release notes
Convert the ENABLE_XXX options to NETCDF_ENABLE_XXX options
Modify CMakeLists.txt to honor CMAKE_INSTALL_MANDIR in support of https://github.com/Unidata/netcdf-c/issues/2920.
Modify ncdump to print char-valued variables as utf8.
CI: Create an MSYS2/MinGW CMake run.
CI: Test on MSYS2/UCRT64 environment
CMake: Fix running tests on MinGW
removal of ftp and contrib site
removal of ftp site
removal of ftp and netcdf contrib site
removal of ftp and netcdf contrib site
comment
ftp --> resources for sample data location
ftp--> resources for sample data location
CMake: Enable plugins on MinGW
Reintroduce targets to allow for cmake-based netCDF-Fortran to find and linka gainst netCDF-C. Stop-gap measure until we can modify netCDF-Fortran to use a more modern approach.
revert
Fix conversion warning in flag set/check/clear macros
ckp
...
# Description
Remove various obsolete build options. Also do some code movement.
## Specific Changes
* The remotetest server is sometimes unstable, so provide a mechanism
to force disabling calls to remotetest.unidata.ucar.edu.
This is enabled by adding a repository variable named
REMOTETESTDOWN with the value "yes".
* Fix CMakeLists.txt to use the uname command as an alternate
to using the hostname command (which does not work under cygwin).
* Remove the JNA stuff as obsolete
* Remove the ENABLE_CLIENTSIDE_FILTERS options since it has been
disabled for a while.
* Fix bad option flag in some github action .yml files: change --disable-xml2 to --disable-libxml2
* Collect globalstate definitions into nc4internal.h
* Remove ENABLE_NCZARR_FILTERS_TESTING option as obsolete and replace
with ENABLE_NCZARR_FILTERS
* Move some dispatcher independent functions from libsrc4/nc4internal.c to libdispatch/ddispatch.c
* As a long term goal, and because it is now the case that --enable-nczarr
=> USE_NETCDF4, make the external options --enable-netcdf-4 and
--enable-netcdf4 obsolete in favor of --enable-hdf5
We will do the following for one more release cycle.
1. Make --enable-netcdf-4 be an alias for --enable-netcdf4.
2. Make --enable-netcdf4 an alias for --enable-hdf5.
3. Internally, convert most uses of USE_NETCDF_4 ad USE_NETCDF4 to USE_HDF5
After the next release, --enable-netcdf-4 and --enable-netcdf4 will
be removed.
