Commit Graph

233 Commits

Author SHA1 Message Date
Ward Fisher
1807cb7aa2 Roughing in a test to create the failure described in https://github.com/Unidata/netcdf-c/issues/221 2016-02-16 11:00:09 -07:00
Ward Fisher
55b24e2964 Added tst_mode to CMakeLists.txt 2016-02-04 19:12:15 +00:00
Dennis Heimbigner
45572f5971 Fix github issue: https://github.com/Unidata/netcdf-c/issues/208
Return an error when specifying deflation (compression) or fletcher32 on
a file created for parallel IO in netcdf-4.
2016-02-01 16:15:58 -07:00
Ward Fisher
427577be8d Merge branch 'gsjaardema-patch-6' into pull-consolidation 2016-01-26 10:10:54 -07:00
Greg Sjaardema
e1696187ec Replace NC_MAX_DIMS with NC_MAX_VAR_DIMS
Same issue as in #197.
2016-01-25 14:55:29 -07:00
Greg Sjaardema
ba7d9c54bd Replace NC_MAX_DIMS with NC_TESTS_MAX_DIMS
Missed this file earlier somehow.  Same situation as fixed in fbc210f
2016-01-25 14:47:52 -07:00
Ward Fisher
fbc210f511 Alternative solution to https://github.com/Unidata/netcdf-c/pull/199 and https://github.com/Unidata/netcdf-c/pull/200. 2016-01-25 14:09:03 -07:00
Ward Fisher
f3cae2e6ce Merge branch 'master' of https://github.com/Unidata/netcdf-c 2016-01-25 11:29:12 -07:00
Greg Sjaardema
04f1231f48 Fix incorrect array size specification
The count and start arrays are dimensioned to NC_MAX_DIMS even though the maximum size should be NDIMS which is set to 3; possibly, the maximum size could be 2 since only indices 0 and 1 are used to access both start and count.  I left it at NDIMS since that matches the number of items in the initialization and is consistent with other uses in the file.
2016-01-22 21:03:48 -07:00
Greg Sjaardema
e13d976e27 Replace NC_MAX_DIMS with correct NC_MAX_VAR_DIMS
The constant NC_MAX_DIMS is used to dimension the `dimids` arrays which are use to retrieve the dimension ids corresponding to the variables dimensions.  By definition, the maximum number of dimension ids is `NC_MAX_VAR_DIMS` as is documented in the `nc_inq_var` documentation:
http://www.unidata.ucar.edu/software/netcdf/netcdf-4/newdocs/netcdf-c/nc_005finq_005fvar.html

dimids   Returned vector of *ndimsp dimension IDs corresponding to the variable dimensions. The caller must allocate enough space for a vector of at least *ndimsp integers to be returned. The maximum possible number of dimensions for a variable is given by the predefined constant NC_MAX_VAR_DIMS. 

Although the default or standard values of NC_MAX_DIMS and NC_MAX_VAR_DIMS are the same, the correct value to be used here is NC_MAX_VAR_DIMS and not NC_MAX_DIMS.  Even though this currently works, it could fail if either NC_MAX_VAR_DIMS or NC_MAX_DIMS is changed and it can also provide an incorrect function usage example that may mislead developers trying to determine the correct usage of the function.
2016-01-22 20:54:52 -07:00
Ward Fisher
bb332ac08a Added a missing file to EXTRA_DIST. 2016-01-13 10:25:18 -07:00
Greg Sjaardema
ccb9682288 Merge branch 'master' into max_vars_dims_cleanup 2015-11-30 10:37:07 -05:00
Greg Sjaardema
724453b113 Update comments related to NC_MAX_VARS and NC_MAX_DIMS 2015-11-30 10:28:06 -05:00
Ward Fisher
03f7b56879 Cleaned up a sloppy cut-and-paste on my part. 2015-11-23 15:49:24 -06:00
Ward Fisher
bf0279e229 Added new test in support of https://github.com/Unidata/netcdf-c/issues/160 2015-11-23 15:48:24 -06:00
Ward Fisher
c000899df2 Added a test in support of issue https://github.com/Unidata/netcdf-c/issues/160. 2015-11-23 15:42:22 -06:00
Ward Fisher
ccd824a77f Added new test to distribution file list. 2015-11-11 14:27:25 -07:00
Ward Fisher
5065b01d37 Wired in a new test based on one provided by Jeff Whitaker in support of issue 149 on github. See https://github.com/Unidata/netcdf-c/issues/149. 2015-11-11 10:42:49 -07:00
Ward Fisher
c1210f4020 Merge branch 'master' into cdf5-sync-master 2015-11-09 13:45:11 -07:00
dmh
5ad26bb68f Fix github issues #140
1. Added check to libsrc4/nc4var.nc_def_var_extra to
   check that the no specified chunks size is greater than
   the dimension size.

2. Added test to nc_test4/tst_chunks.c
2015-11-07 20:29:16 -07:00
Ward Fisher
612b35a84c Merge branch 'master' into cdf-5, in preparation for merging the CDF-5 functionality into the master branch. This will be the key new feature for netcdf 4.4.0. 2015-11-05 13:40:35 -07:00
Ward Fisher
a81773e5bf Corrected an issue Visual Studio has with how externals are managed. 2015-11-05 12:57:49 -07:00
Ward Fisher
a359cb6a53 Reverted some of the spelling corrections. Some misspellings were intentional 2015-10-16 14:36:17 -06:00
tbeu
e2820e4d8a Fix common typos
Detected by https://github.com/vlajos/misspell_fixer
2015-08-20 11:42:05 +02:00
dmh
859f105005 merge-squash 2015-08-15 16:26:35 -06:00
Russ Rew
0687dfe5a2 Cleanup clang warnings. 2015-08-02 17:22:50 -06:00
Ward Fisher
3a792b1fb2 Remove the [NCF-332] temp file on failure. 2015-05-29 10:23:24 -06:00
Ward Fisher
ea8f1d9027 Fleshed out [NCF-332] test to check all little-endian variable types supported, and also added some true-negative/expected failure tests. Next up is regression testing and then merging into master. 2015-05-29 09:49:20 -06:00
Ward Fisher
d5d1efbcdb Refactoring and expanding [NCF-332] test. 2015-05-29 09:22:38 -06:00
Ward Fisher
0ed84b406b Fleshed out a test that *should* start passing, once we've fixed issue [NCF-332] 2015-05-28 17:21:01 -06:00
Ward Fisher
64e0d2a44e Added a new test for h4 endianness. [NCF332] 2015-05-28 17:13:15 -06:00
Ward Fisher
4fecd37ba7 Refactored tst_h_endians to tst_h5_endians, so that we can differentiate between hdf5 and hdf4 endian tests. 2015-05-28 16:29:49 -06:00
Ward Fisher
c9d7c88f63 Added a stanza for 'NC_DOUBLE' into the recently-added endians test. 2015-05-18 10:55:17 -06:00
Ward Fisher
5eb90c3a66 Cleaned up an unnecessary test, added refactored nc4 test to autotools. 2015-05-15 15:31:38 -06:00
Ward Fisher
9d98aab40a Refactored test. 2015-05-15 15:29:29 -06:00
Ward Fisher
99ef1624bc Regarding [NCF-331], the issues appears to have been in nc4file.c:get_type_info2(). The call to H5Tget_order() was only happening for H5T_Float. According to the documentation, this works for all datatypes as of hdf5 1.8.6. This tentatively fixes the bug reported, but additional testing (and cleanup from debugging) is needed. 2015-05-15 14:24:27 -06:00
Ward Fisher
de29c4d0a8 Tweaked tests for additional debugging. 2015-05-15 13:11:46 -06:00
Ward Fisher
999f4e5720 Additional debugging, modified the LOGGING functions somewhat. Also modified ncdump to print 'native' endianness. This may be removed before merging back into trunk. 2015-05-14 17:22:07 -06:00
Ward Fisher
fa1d61b980 Additional debugging for [NCF-331] 2015-05-12 13:52:52 -06:00
Ward Fisher
6eff077ed5 Incorporated endian test for [NCF-331] into autotools. 2015-05-12 13:00:22 -06:00
Ward Fisher
c43f9dee63 Refined test for [NCF-331]. 2015-05-11 15:58:47 -06:00
Ward Fisher
659172816b Added a new test. 2015-05-11 15:01:31 -06:00
Ward Fisher
ee3daa3267 Added a test contributed by Jeff Whitaker. See https://github.com/Unidata/netcdf-c/issues/112 or [NCF-331] for more information. 2015-05-11 14:52:16 -06:00
Russ Rew
ab18a2e17c Fix bug NCF-187 (thanks to Alexander Barth). Add test for bug fix. 2015-04-02 12:30:51 -06:00
Russ Rew
6a6e8c08a6 added test case for ncf-187, haven't added fix yet 2015-04-01 15:09:27 -06:00
Quincey Koziol
aede522766 Mark dataset attributes dirty when one is renamed. 2015-02-25 09:25:40 -06:00
Ward Fisher
261e7511cc Modified group rename shell script to work in Msys/Windows Environment. 2015-02-02 14:46:51 -07:00
Ward Fisher
2d72b7ca7f More work on getting the shell scripts working properly with cmake under MSYS. 2015-02-02 14:46:50 -07:00
Russ Rew
db83a3be4c Jira issue NCF-314, "Provide replacement for using numeric values of -k
option on nccopy and ncgen".
2014-12-29 13:07:28 -07:00
Russ Rew
9a60dc612f Use short "-k" codes instead of deprecated version numbers for ncgen and nccopy tests 2014-12-28 22:42:05 -07:00