Commit Graph

8957 Commits

Author SHA1 Message Date
Edward Hartnett
1a13b9ed09 more quantize testing 2022-07-08 10:35:38 -06:00
Edward Hartnett
6645cce1c9 more quantize testing 2022-07-08 09:44:38 -06:00
Edward Hartnett
2bfde9a5eb more quantize testing 2022-07-08 08:55:48 -06:00
Edward Hartnett
4aa319f9dc adding pre-processor constant NC_MAX_FILENAME to nc_tests.h 2022-07-08 07:27:54 -06:00
Ward Fisher
26c558203f
Merge pull request #2445 from edwardhartnett/ejh_fix_quantize
fix and test quantize mode for NC_CLASSIC_MODEL
2022-07-07 15:29:33 -06:00
Edward Hartnett
4b0f337dbc
Merge branch 'main' into ejh_fix_quantize 2022-07-07 11:16:32 -06:00
Dennis Heimbigner
31b24d767a Fix bad cmake install location 2022-07-06 15:01:23 -06:00
Dennis Heimbigner
966a0c1a9f Resolve conflict 2022-07-06 14:21:51 -06:00
Greg Sjaardema
53aeb1aacb
Minor update to doxygen function documentation 2022-07-06 10:38:43 -06:00
Ward Fisher
ee5e1596f5
Merge pull request #2430 from DennisHeimbigner/cmakeplugin.dmh
Fix the way CMake handles -DPLUGIN_INSTALL_DIR
2022-07-06 09:09:13 -06:00
Dennis Heimbigner
f50007e21d Update RELEASENOTES.md 2022-07-05 22:06:28 -06:00
Dennis Heimbigner
8b0e1134b4 Ensure that netcdf_json.h does not interfere with ncjson.
re: Issue https://github.com/Unidata/netcdf-c/issues/2419

There are effectively two json subsystems in netcdf-c.
1. ncjson.[ch] in libnetcdf
2. netcdf_json.h for use by plugins so they can be built without need
   for libnetcdf.

The netcdf_json.h file is constructed from the concatenation of
ncjson.h plus ncjson.c. It turned out that in doing this, I was
leaving some symbols externally visible so that if, for some
reason, a plugin was built and needed libnetcdf, then symbol
conflicts arose.

The solution is to prefix the declarations in ncjson.[ch] with a
macro (OPTSTATIC) that can be resolved to either nothing or to
"static". Then in netcdf_json.h, it resolves to "static" and
prevents the symbol conflicts.

Note that netcdf_json.h is constructed once in
netcdf-c/include/Makefile.am with the rule named
"makepluginjson". This means that it is included in the
distribution. However, this also means that if ncjson.[ch] is
changed, then it is necessary to invoke makepluginjson
explicitly to rebuild netcdf_json.h
2022-07-05 22:03:52 -06:00
Ward Fisher
b2641a1fc5
Merge branch 'main' into cmakeplugin.dmh 2022-07-05 16:27:51 -06:00
Edward Hartnett
4e4209b6f0 code and documentation cleanup 2022-07-02 08:13:13 -06:00
Edward Hartnett
309d4bec35 code and documentation cleanup 2022-07-02 07:51:33 -06:00
Edward Hartnett
a2aeec8936 documentation 2022-07-02 06:19:52 -06:00
Edward Hartnett
536cdd28f9 fix and test quantize mode for NC_CLASSIC_MODEL 2022-07-02 06:14:32 -06:00
Ward Fisher
a00bb62167
Merge pull request #2439 from WardF/disable_quant_option.wif
Add `--disable-quantize` to configure
2022-07-01 10:05:35 -06:00
Ward Fisher
b6bdcacde7 Update release notes. 2022-06-30 14:44:09 -06:00
Ward Fisher
d1a3f6fbe6 configure.ac logic for disabling quantize. 2022-06-30 14:41:18 -06:00
Ward Fisher
a494ac50cd
Merge pull request #2438 from WardF/gh2271.wif
Updated CMakeLists to avoid corner case cmake error
2022-06-29 16:29:58 -06:00
Ward Fisher
f3426bc7d9 Updated CMakeLists to avoid the error described in https://github.com/Unidata/netcdf-c/issues/2271 2022-06-29 14:44:49 -06:00
Ward Fisher
5794ae4dd3
Merge pull request #2437 from WardF/gh2435.wif
Fix pnetcdf tests in cmake
2022-06-28 18:52:44 -06:00
Ward Fisher
9d44421024 Work in a one-line change as originally suggested in https://github.com/Unidata/netcdf-c/pull/2426. 2022-06-28 16:58:24 -06:00
Ward Fisher
dfc47497e3 Make pnetcdf tests run in serial fashion when using cmake 2022-06-28 16:53:38 -06:00
Ward Fisher
ae0b5e7d8c
Merge branch 'main' into cmakeplugin.dmh 2022-06-28 16:38:31 -06:00
Ward Fisher
7d6d4b9b40 Fix a typo. 2022-06-28 16:31:15 -06:00
Ward Fisher
73a0d92f9d Fix a typo. 2022-06-28 16:30:26 -06:00
Ward Fisher
e34f8d5dc0 Run one-off tests first. 2022-06-28 16:29:35 -06:00
Ward Fisher
ff34b66182 Fix cache check. 2022-06-28 16:27:23 -06:00
Ward Fisher
8637265e7f Merge branch 'main' into gh2435.wif 2022-06-28 16:15:44 -06:00
Ward Fisher
f414e51b1a
Merge pull request #2423 from edwardhartnett/ejh_docs_1
fixed RELEASE_NOTES.md
2022-06-28 16:15:11 -06:00
Ward Fisher
baaa2b6f00 Building test programs invoked by run_pnetcdf_tests.sh 2022-06-28 15:28:40 -06:00
Ward Fisher
bfca030037 Fixing cmake-based run_pnetcdf_tests.sh 2022-06-28 15:04:58 -06:00
Ward Fisher
24bdf6c067 Generate nc_test/run_pnetcdf_tests.sh when using cmake, in support of https://github.com/Unidata/netcdf-c/issues/2435 2022-06-28 14:56:38 -06:00
Ward Fisher
47d35cc24e
Merge pull request #2319 from wkliao/part 2022-06-27 11:47:20 -06:00
Dennis Heimbigner
ccecc3065b debug1 2022-06-25 18:42:50 -06:00
Dennis Heimbigner
feb07359cd Update Release notes 2022-06-25 16:49:28 -06:00
Dennis Heimbigner
c633de1125 Fix way CMake handle -DPLUGIN_INSTALL_DIR
re: Issue https://github.com/Unidata/netcdf-c/issues/2429

The CMake tests for -DPLUGIN_INSTALL_DIR only accepted
"on" or "off" as boolean values. So extend to accept e.g.
-DPLUGIN_INSTALL_DIR=yes or -DPLUGIN_INSTALL_DIR=1, etc.
2022-06-25 16:47:49 -06:00
Dennis Heimbigner
d594f72a6d force rebuild 2022-06-23 16:08:58 -06:00
Dennis Heimbigner
bc55212936 Minimal changes to RELEASENOTES to get a working patch 2022-06-23 15:51:21 -06:00
Dennis Heimbigner
43ec0e5216 undebug 2022-06-23 14:10:45 -06:00
Dennis Heimbigner
f3ef83ea46 fix RELEASENOTES 2022-06-23 14:08:58 -06:00
Edward Hartnett
e45292f6ca moved quantize error documentation 2022-06-23 09:51:09 +02:00
Edward Hartnett
68b0d50af0 change to trigger CI 2022-06-23 07:25:09 +02:00
Edward Hartnett
f9494ab296 change to trigger CI 2022-06-23 07:09:16 +02:00
Edward Hartnett
03668614b8 changed backslash to and 2022-06-23 06:46:01 +02:00
Edward Hartnett
a9ffa1c503 fixed missing quote 2022-06-23 06:44:03 +02:00
Edward Hartnett
650ae97fa8 fixed missing quote 2022-06-23 06:43:23 +02:00
Edward Hartnett
45f29f884a fixed RELEASE_NOTES.md 2022-06-23 06:18:17 +02:00