Problem was basically that the test file ref_oldformat.zip
was incorrect. Additionally, logic in zsync.c was incorrect.
### Misc. other fixes
1. Turn off accidental debug output
As suggested by Ward, I ensured that this PR supports
read backward compatibility with old key format.
This addition also adds a test case for this.
## Misc. Other Changes
* Remove some unused code
* Cleanup json error handling
* Fix some more unsigned/signed conversions warning
As discussed in a netcdf meeting, convert NCZarr V2 to store all netcdf-4 specific info as attributes. This improves interoperability with other Zarr implementations by no longer using non-standard keys.
## Other Changes
* Remove support for older NCZarr formats.
* Update anonymous dimension naming
* Begin the process of fixing the -Wconversion and -Wsign-compare warnings in libnczarr, nczarr_test, and v3_nczarr_test.
* Update docs/nczarr.md
* Rebuild using the .y and .l files
re: Issue https://github.com/Unidata/netcdf-c/issues/2927
The NC_s3sdkinitialize NC_s3sdkfinalize functions were
misplaced. They should have been moved from ds3util.c to
ncs3sdk_h5.c. When using ncs3sdl_aws.cpp, this resulted in a
duplicate definition.
Also, found and fixed a memory leak in the NCZarr S3 code.
# Primary Change
In order to conform to the cmake overhaul, occurrences of
ENABLE_XXX options in the nczarr code have been changed to
NETCDF_ENABLE_XXX.
# Misc. Other changes
* Fix use of rand_s in libdispatch/ncrandom.c
* Fix some bugs in the mingw gitub action.
* Fix signature bug in libncpoco/cp_win32.c
* Make some NCZarr fixes to config.h.cmake.in
* main: (39 commits)
Define USE_SZIP variable for nc-config.cmake.in
matching cmake variables in autotools configuration
moving the version into the project command in cmake
Updated doxygen files for older, less-forgiving versions of doxygen (1.9.1, at least)
Clean up doxygen warnings that were being treated as failures.
Correcting a weird doxygen issue that has appeared.
cmake: Fix Szip link using correct cmake var
cmake: Improve FindSzip logic to provide a Szip_LIBRARY var
Changed link to netCDF-Fortran documentation.
Replaced ancient K&R function declarations to be C23 compatible
Rebased PR by hand against main.
count argument in H5Sselect_hyperslab
Add H5FD_http_finalize function and call on hdf5 finalize
Catching up on PRs, this is 2431 on the current 'main'
Fix cmake syntax typo.
Typo fix in support of gh2824.wif
Fix typo in nc-config.cmake.in
Removed a use of sprintf that required changing a function signature
Replaced some sprintf with snprintf with aid of new variable containing size
Replaced trivial uses of sprintf with snprintf
...
NOTE: it is important that this fix gets into 4.9.3
re: Issue https://github.com/Unidata/netcdf-c/issues/2798
## Modifications
* This PR includes PR https://github.com/Unidata/netcdf-c/pull/2813
* Support the following AWS environment variables in the internal S3 library
(they are already supported by aws-sdk-cpp).
- AWS_REGION
- AWS_DEFAULT_REGION
- AWS_ACCESS_KEY_ID
- AWS_CONFIG_FILE
- AWS_PROFILE
- AWS_SECRET_ACCESS_KEY
- (source https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-envvars.html).
* Support an empty region when specifying s3.amazonaws.com as the host.
* Move some S3/AWS related functions to ds3util.c
* Add a test case to test empty region and AWS_[DEFAULT]_REGION.
`options->file` is allocated on the stack and so will never be `NULL`,
making this conditional always true. Instead, we want to check the
value of `file`. As `options` is allocated with `calloc`, we know that
`file` will be zero-initialised, and it's safe to just check the first
element
`chunk_size` is only used if `PRINT_CHUNK_WASTE_REPORT` is
defined. Also move the declaration of `chunk_size` inside the `#ifdef`
to silence `set-but-unused` warning
Mostly just add an explicit cast when calling `malloc` and its
variants. Sometimes instead change the type of a local variable if
this would silence multiple warnings.
