mirror/netcdf-c
2
0
Fork 0
mirror of https://github.com/Unidata/netcdf-c.git synced 2025-04-06 18:00:24 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix type punning in xxdrntohdouble() by using memcpy instead of assignment

Browse Source 
gcc11 explicitly warned about this strict aliasing violation:
xxdr.c: In function 'xxdrntohdouble':
xxdr.c:505:19: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
  505 |     if(dp) *dp = *(double*)ii;
      |                   ^~~~~~~~~~~

Signed-off-by: Egbert Eich <eich@suse.com>
This commit is contained in:
Egbert Eich 2021-07-10 09:54:03 +02:00
parent fbad04ee79
commit dfdc278907
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
oc2/xxdr.c
View File

@ -502,7 +502,8 @@ xxdrntohdouble(char* c8, double* dp)
ii[0] = ii[1];
ii[1] = tmp;
}
if(dp) *dp = *(double*)ii;
/* use memcpy avoid type punning */
if(dp) memcpy(dp, ii, sizeof(double));
}
void