Added a document to catalog what the various tests are.

docs/tests.md

@@ -0,0 +1,23 @@
+NetCDF Unit/Regression Tests
+============================
+
+This file, when complete, will contain a description of every test run by netCDF during regression/unit testing.  Much of this information is being backfilled, and is for the time being incomplete.  This header will be updated to reflect completeness, when so warranted.
+
+Tests are organized by the directory in which they appear.
+
+nc_test4/
+--------
+
+Test | Notes
+-----|------
+tst_fill_attr_vanish | Ensures that adding a _FillValue attribute doesn't result in other variable attributes disappearing[^tstfillattrvanish].
+
+
+
+
+
+
+External resources
+------------------
+
+[^tstfillattrvanish]:https://github.com/Unidata/netcdf-c/issues/239

nc_test4/CMakeLists.txt

@@ -9,7 +9,7 @@ SET(NC4_TESTS tst_dims tst_dims2 tst_dims3 tst_files tst_files4 tst_vars
   t_type cdm_sea_soundings tst_vl tst_atts1 tst_atts2
   tst_vars2 tst_files5 tst_files6 tst_sync tst_h_strbug tst_h_refs
   tst_h_scalar tst_rename tst_h5_endians tst_atts_string_rewrite
-  tst_put_vars_two_unlim_dim tst_hdf5_file_compat)
+  tst_put_vars_two_unlim_dim tst_hdf5_file_compat tst_fill_attr_vanish)
 
 # Note, renamegroup needs to be compiled before run_grp_rename
 build_bin_test(renamegroup)

nc_test4/tst_fill_attr_vanish.c

@@ -0,0 +1,89 @@
+/* This is part of the netCDF package.
+   Copyright 2016 University Corporation for Atmospheric Research/Unidata
+   See COPYRIGHT file for conditions of use.
+
+   Based on tst_fillbug.c
+
+   Added in support of https://github.com/Unidata/netcdf-c/issues/239
+
+   The issue in a nutshell is that if _FillValue is added to a file
+   defined without it, previously existing attributes with
+   preexisting variables are wiped out, only the _FillValue attribute
+   exists.
+
+*/
+
+#include <nc_tests.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <netcdf.h>
+
+#define FILENAME "tst_fill_attr_vanish.nc"
+#define RANK_Time 1
+#define RANK_P 3
+#define LEN 4
+
+int
+main()
+{
+   int ncid, dimids[RANK_P], time_id, p_id;
+   int ndims, dimids_in[RANK_P];
+
+   double data[1] = {3.14159};
+   size_t start[1] = {0}, count[1] = {1};
+   static float P_data[LEN];
+   size_t cor[RANK_P] = {0, 1, 0};
+   size_t edg[RANK_P] = {1, 1, LEN};
+   float pdata[1] = {1};
+   int pfill = 3;
+   int i;
+
+   printf("\n*** Testing for a netCDF-4 fill-value bug.\n");
+   printf("*** Creating a file with no _FillValue defined. ***\n");
+
+   /* Create a 3D test file. */
+   if (nc_create(FILENAME, NC_CLOBBER|NC_NETCDF4, &ncid)) ERR;
+   //if (nc_set_fill(ncid,NC_NOFILL,NULL)) ERR;
+
+   /* define dimensions */
+   if (nc_def_dim(ncid, "Time", NC_UNLIMITED, &dimids[0])) ERR;
+   if (nc_def_dim(ncid, "X", 4, &dimids[2])) ERR;
+   if (nc_def_dim(ncid, "Y", 3, &dimids[1])) ERR;
+
+   /* define variables */
+   if (nc_def_var(ncid, "Time", NC_DOUBLE, 1, dimids, &time_id)) ERR;
+   if (nc_def_var(ncid, "P", NC_FLOAT, RANK_P, dimids, &p_id)) ERR;
+
+   if (nc_put_att_float(ncid,p_id,"_FillValue", NC_FLOAT, 1, pfill)) ERR;
+
+   /* Add one record in coordinate variable. */
+   if (nc_put_vara(ncid, time_id, start, count, data)) ERR;
+
+   /* The other variable should show an increase in size, since it
+    * uses the unlimited dimension. */
+   if (nc_inq_var(ncid, 1, NULL, NULL, &ndims, dimids_in, NULL)) ERR;
+   if (ndims != 3 || dimids_in[0] != 0 || dimids_in[1] != 2 || dimids_in[2] != 1) ERR;
+
+   /* That's it! */
+   if (nc_close(ncid)) ERR;
+
+
+
+
+   /* Reopen the fi+le and read the second slice. */
+   /*
+   if (nc_open(FILENAME, NC_NOWRITE, &ncid)) ERR;
+
+   if (nc_inq_var(ncid, 1, NULL, NULL, &ndims, dimids_in, NULL)) ERR;
+   if (ndims != 3 || dimids_in[0] != 0 || dimids_in[1] != 2 || dimids_in[2] != 1) ERR;
+   if (nc_get_vara(ncid, 1, cor, edg, P_data)) ERR;
+   for (i = 0; i < LEN; i++)
+     if (P_data[i] != NC_FILL_FLOAT) ERR;
+
+   if (nc_close(ncid)) ERR;
+   */
+   SUMMARIZE_ERR;
+
+   FINAL_RESULTS;
+   return 0;
+}