mirror/netcdf-c
2
0
Fork 0
mirror of https://github.com/Unidata/netcdf-c.git synced 2024-11-21 03:13:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

Removed a potential double-free identified by static analysis.

Browse Source
This commit is contained in:
Ward Fisher 2018-05-31 15:09:11 -06:00
parent 3e1bd3ce5f
commit db8d23b986
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
libsrc/nc3internal.c
View File

@ -584,7 +584,7 @@ fill_added(NC3_INFO *gnu, NC3_INFO *old)
{
const NC_var *const gnu_varp = *(gnu_varpp + varid);
if (gnu_varp->no_fill) continue;
if (gnu_varp->no_fill) continue;
if(IS_RECVAR(gnu_varp))
{
@ -1203,9 +1203,12 @@ NC3_open(const char * path, int ioflags,
* !_CRAYMPP, only pe 0 is valid
*/
if(basepe != 0) {
if(nc3) free(nc3);
status = NC_EINVAL;
goto unwind_alloc;
if(nc3) {
free(nc3);
nc3 = NULL;
}
status = NC_EINVAL;
goto unwind_alloc;
}
#endif
@ -1743,7 +1746,7 @@ NC3_inq_format_extended(int ncid, int *formatp, int *modep)
* Determine name and size of netCDF type. This netCDF-4 function
* proved so popular that a netCDF-classic version is provided. You're
* welcome.
*
*
* \param ncid The ID of an open file.
* \param typeid The ID of a netCDF type.
* \param name Pointer that will get the name of the type. Maximum