mirror/netcdf-c
2
0
Fork 0
mirror of https://github.com/Unidata/netcdf-c.git synced 2025-01-18 15:55:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

Coverity: 712596

Browse Source
This commit is contained in:
Ward Fisher 2014-08-15 16:09:07 -06:00
parent 56a0f8620f
commit d25b94f92d
1 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
libdap2/getvara.c
View File

@ -634,11 +634,25 @@ movetofield(NCDAPCOMMON* nccomm,
OCdatanode fieldcontent = NULL; OCdatanode fieldcontent = NULL;
CDFnode* xnext; CDFnode* xnext;
int newdepth; int newdepth;
int ffield;
/* currentcontent points to the grid/dataset/structure/record instance */ /* currentcontent points to the grid/dataset/structure/record instance */
xnext = (CDFnode*)nclistget(path,depth+1); xnext = (CDFnode*)nclistget(path,depth+1);
ASSERT((xnext != NULL)); ASSERT((xnext != NULL));
/* If findfield is less than 0,
and passes through this stanza,
an undefined value will be passed to
oc_data_ithfield. See coverity
issue 712596. */
ffield = findfield(xnode, xnext);
if(ffield < 0) {
ncstat = NC_EBADFIELD;
goto done;
} else {
fieldindex = findfield(xnode,xnext); fieldindex = findfield(xnode,xnext);
}
/* If the next node is a nc_virtual node, then /* If the next node is a nc_virtual node, then
we need to effectively we need to effectively
ignore it and use the appropriate subnode. ignore it and use the appropriate subnode.