mirror/netcdf-c
2
0
Fork 0
mirror of https://github.com/Unidata/netcdf-c.git synced 2025-01-30 16:10:44 +08:00
Code Issues Packages Projects Releases Wiki Activity

Updated OFF_T_MAX computation to avoid an undefined behavior warning reported by clang/gcc.

Browse Source
This commit is contained in:
Ward Fisher 2016-09-26 10:14:38 -06:00
parent b6c5d34c32
commit cdf7717666
1 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
libsrc/var.c
View File

@ -15,7 +15,24 @@
#include "utf8proc.h"
#ifndef OFF_T_MAX
#define OFF_T_MAX (~ (off_t) 0 - (~ (off_t) 0 << (CHAR_BIT * sizeof (off_t) - 1)))
//#define OFF_T_MAX (~ (off_t) 0 - (~ (off_t) 0 << (CHAR_BIT * sizeof (off_t) - 1)))
/* The behavior above is undefined, re: bitshifting a negative value, according
to warnings thrown by clang/gcc. An alternative OFF_T_MAX was written
based on info found at:
* http://stackoverflow.com/questions/4514572/c-question-off-t-and-other-signed-integer-types-minimum-and-maximum-values
*/
#define MAX_INT_VAL_STEP(t) \
((t) 1 << (CHAR_BIT * sizeof(t) - 1 - ((t) -1 < 1)))
#define MAX_INT_VAL(t) \
((MAX_INT_VAL_STEP(t) - 1) + MAX_INT_VAL_STEP(t))
#define MIN_INT_VAL(t) \
((t) -MAX_INT_VAL(t) - 1)
#define OFF_T_MAX MAX_INT_VAL(off_t)
#endif
/*