diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index c7de58943..eb37f229a 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -7,6 +7,7 @@ This file contains a high-level description of this package's evolution. Release ## 4.8.2 - TBD +* [Bug Fix] Fix use of non-aws appliances. See [Github #????](https://github.com/Unidata/netcdf-c/pull/????). * [Enhancement] Added options to suppress the new behavior from [Github #2135](https://github.com/Unidata/netcdf-c/pull/2135). The options for `cmake` and `configure` are, respectively `-DENABLE_LIBXML2` and `--(enable/disable)-libxml2`. Both of these options defaul to 'on/enabled'. When disabled, the bundled `ezxml` XML interpreter is used regardless of whether `libxml2` is present on the system. * [Enhancement] Support optional use of libxml2, otherwise default to ezxml. See [Github #2135](https://github.com/Unidata/netcdf-c/pull/2135) -- H/T to [Egbert Eich](https://github.com/e4t). * [Bug Fix] Fix several os related errors. See [Github #2138](https://github.com/Unidata/netcdf-c/pull/2138). diff --git a/libdispatch/ds3util.c b/libdispatch/ds3util.c index 5b600dce9..6158854a9 100644 --- a/libdispatch/ds3util.c +++ b/libdispatch/ds3util.c @@ -119,11 +119,12 @@ NC_s3urlrebuild(NCURI* url, NCURI** newurlp, char** bucketp, char** outregionp) if((stat = NC_getdefaults3region(url,®ion0))) goto done; region = strdup(region0); } - /* Construct the revised host */ - ncbytescat(buf,"s3."); - ncbytescat(buf,region); - ncbytescat(buf,AWSHOST); - host = ncbytesextract(buf); + if(host == NULL) { /* Construct the revised host */ + ncbytescat(buf,"s3."); + ncbytescat(buf,region); + ncbytescat(buf,AWSHOST); + host = ncbytesextract(buf); + } /* Construct the revised path */ ncbytesclear(buf); diff --git a/liblib/nc_initialize.c b/liblib/nc_initialize.c index 5c092f427..982f6be7c 100644 --- a/liblib/nc_initialize.c +++ b/liblib/nc_initialize.c @@ -47,8 +47,8 @@ extern int NC_HDF4_finalize(void); #endif #ifdef ENABLE_S3_SDK -extern int NC_s3sdkinitialize(void); -extern int NC_s3sdkfinalize(void); +EXTERNL int NC_s3sdkinitialize(void); +EXTERNL int NC_s3sdkfinalize(void); #endif #ifdef _MSC_VER diff --git a/ncdap_test/findtestserver.c.in b/ncdap_test/findtestserver.c.in index cbe3fdb99..5a2c0c4b3 100644 --- a/ncdap_test/findtestserver.c.in +++ b/ncdap_test/findtestserver.c.in @@ -87,7 +87,7 @@ main(int argc, char** argv) } url = nc_findtestserver(servlet,serverlist); if(url == NULL) { - url = ""; + url = strdup(""); fprintf(stderr,"not found: %s\n",servlet); } printf("%s",url); diff --git a/nczarr_test/run_interop.sh b/nczarr_test/run_interop.sh index 8867e9f54..4c13d1738 100755 --- a/nczarr_test/run_interop.sh +++ b/nczarr_test/run_interop.sh @@ -69,19 +69,22 @@ case "$zext" in testcasezip ref_quotes zarr metaonly ;; s3) - # Read a test case created by netcdf-java zarr. - # Move into position - rm -f ${execdir}/ref_zarr_test_data.cdl - if gunzip -c < ${srcdir}/ref_zarr_test_data.cdl.gz > ${execdir}/ref_zarr_test_data.cdl ; then - testcases3 zarr_test_data.zarr ref_zarr_test_data xarray + # Test file does not exist on stratus + if test "x$NCZARR_S3_TEST_HOST" = "xs3.us-east-1.amazonaws.com" ; then + # Read a test case created by netcdf-java zarr. + # Move into position + rm -f ${execdir}/ref_zarr_test_data.cdl + if gunzip -c < ${srcdir}/ref_zarr_test_data.cdl.gz > ${execdir}/ref_zarr_test_data.cdl ; then + testcases3 zarr_test_data.zarr ref_zarr_test_data xarray + fi fi ;; *) echo "unimplemented kind: $1" ; exit 1;; esac } -#testallcases file -#if test "x$FEATURE_NCZARR_ZIP" = xyes ; then testallcases zip; fi +testallcases file +if test "x$FEATURE_NCZARR_ZIP" = xyes ; then testallcases zip; fi if test "x$FEATURE_S3TESTS" = xyes ; then testallcases s3; fi exit # Cleanup