mirror/netcdf-c
2
0
Fork 0
mirror of https://github.com/Unidata/netcdf-c.git synced 2024-11-21 03:13:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

Corrected issue 1372911 in Coverity.

Browse Source
This commit is contained in:
Ward Fisher 2016-09-14 16:16:06 -06:00
parent 485faa0333
commit ad1220453a
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
libsrc4/nc4info.c
View File

@ -161,20 +161,24 @@ NC4_put_propattr(NC_HDF5_FILE_INFO_T* h5)
char* text = NULL; char* text = NULL;
ncstat = NC4_buildpropinfo(&h5->fileinfo->propattr,&text); ncstat = NC4_buildpropinfo(&h5->fileinfo->propattr,&text);
if(text == NULL || ncstat != NC_NOERR) { if(text == NULL || ncstat != NC_NOERR) {
if(text != NULL) free(text); goto done;
goto done;
} }
herr = -1; herr = -1;
/* Create a datatype to refer to. */ /* Create a datatype to refer to. */
HCHECK((atype = H5Tcopy(H5T_C_S1))); HCHECK((atype = H5Tcopy(H5T_C_S1)));
HCHECK((H5Tset_cset(atype, H5T_CSET_ASCII))); HCHECK((H5Tset_cset(atype, H5T_CSET_ASCII)));
HCHECK((H5Tset_size(atype, strlen(text)+1))); /*keep nul term */ HCHECK((H5Tset_size(atype, strlen(text)+1))); /*keep nul term */
HCHECK((aspace = H5Screate(H5S_SCALAR))); HCHECK((aspace = H5Screate(H5S_SCALAR)));
HCHECK((attid = H5Acreate(grp, NCPROPS, atype, aspace, H5P_DEFAULT))); HCHECK((attid = H5Acreate(grp, NCPROPS, atype, aspace, H5P_DEFAULT)));
HCHECK((H5Awrite(attid, atype, text))); HCHECK((H5Awrite(attid, atype, text)));
herr = 0; herr = 0;
} }
done: done:
if(ncstat != NC_NOERR) {
if(text != NULL) {
free(text);
}
if(attid >= 0) HCHECK((H5Aclose(attid))); if(attid >= 0) HCHECK((H5Aclose(attid)));
if(aspace >= 0) HCHECK((H5Sclose(aspace))); if(aspace >= 0) HCHECK((H5Sclose(aspace)));
if(atype >= 0) HCHECK((H5Tclose(atype))); if(atype >= 0) HCHECK((H5Tclose(atype)));