Renamed option used to enable fortran bootstrap behavior. Updated RELEASE_NOTES.md with information re: this new option.

This commit is contained in:
Ward Fisher 2014-11-20 15:56:11 -07:00
parent f20baaf19c
commit 8de2a68a30
3 changed files with 30 additions and 17 deletions

View File

@ -312,7 +312,10 @@ ENDIF()
# Option to automatically build netcdf-fortran.
IF(NOT MSVC)
OPTION(BUILD_FORTRAN "Download and build netcdf-fortran automatically (EXPERIMENTAL)." OFF)
OPTION(ENABLE_REMOTE_FORTRAN_BOOTSTRAP "Download and build netcdf-fortran automatically (EXPERIMENTAL)." OFF)
IF(ENABLE_REMOTE_FORTRAN_BOOTSTRAP)
SET(BUILD_FORTRAN ON)
ENDIF()
IF(BUILD_FORTRAN)
CONFIGURE_FILE("${CMAKE_SOURCE_DIR}/postinstall.sh.in"
"${CMAKE_BINARY_DIR}/postinstall.sh"

View File

@ -9,19 +9,29 @@ This file contains a high-level description of this package's evolution. Release
### 4.3.3-rc3 Released ?
* The pnetcdf support was not properly being used to provide
mpi parallel io for netcdf-3 classic files. The wrong
dispatch table was being used.
[NCF-319](https://bugtracking.unidata.ucar.edu/browse/NCF-319)
* Added functionality to make it easier to build `netcdf-fortran` as part of the `netcdf-c` build. This functionality is enabled at configure time by using the following **Highly Experimental** options:
* Fixed bug in ncgen. When classic format was in force (k=1 or k=4),
the "long" datatype should be treated as int32. Was returning an error.
[NCF-318](https://bugtracking.unidata.ucar.edu/browse/NCF-318)
* CMake: `-DENABLE_REMOTE_FORTRAN_BOOTSTRAP=ON`
* Autotools: `--enable-remote-fortran-bootstrap`
* Fixed bug where if the netCDF-C library is built with the
HDF5 library but without the HDF4 library and one attempts
to open an HDF4 file, an abort occurs rather than returning
a proper error code (NC_ENOTNC). [NCF-317](https://bugtracking.unidata.ucar.edu/browse/NCF-317)
> Enabling these options creates two new make targets:
~~~
$ make build-netcdf-fortran
$ make install-netcdf-fortran
~~~
These make targets are **only** valid after `make install` has been invoked. This cannot be enforced rigidly in the makefile for reasons we will expand on in the documentation, but in short: `make install` may require sudo, but using sudo will discard environmental variables required when attempting to build netcdf-fortran in this manner.
It is important to note that this is functionality is for *convenience only*. It will remain possible to build `netcdf-c` and `netcdf-fortran` manually. These make targets should hopefully suffice for the majority of our users, but for corner cases it may still be required of the user to perform a manual build.
* The pnetcdf support was not properly being used to provide mpi parallel io for netcdf-3 classic files. The wrong dispatch table was being used. [NCF-319](https://bugtracking.unidata.ucar.edu/browse/NCF-319)
* Fixed bug in ncgen. When classic format was in force (k=1 or k=4), the "long" datatype should be treated as int32. Was returning an error. [NCF-318](https://bugtracking.unidata.ucar.edu/browse/NCF-318)
* Fixed bug where if the netCDF-C library is built with the HDF5 library but without the HDF4 library and one attempts to open an HDF4 file, an abort occurs rather than returning a proper error code (NC_ENOTNC). [NCF-317](https://bugtracking.unidata.ucar.edu/browse/NCF-317)
* Added a new option, `NC_EXTRA_DEPS`, for cmake-based builds. This is analogous to `LIBS` in autotools-based builds. Example usage:

View File

@ -173,10 +173,10 @@ AC_MSG_RESULT($enable_hdf4_file_tests)
# Does the user want to try to install netcdf-fortran
# automatically?
AC_MSG_CHECKING([whether we should attempt to install netcdf-fortran (EXPERIMENTAL)])
AC_ARG_ENABLE([fortran], [AS_HELP_STRING([--enable-fortran],
AC_ARG_ENABLE([fortran], [AS_HELP_STRING([--enable-remote-fortran-bootstrap],
[Download and install netcdf-fortran (EXPERIMENTAL)])])
test "x$enable_fortran" = xyes || enable_fortran=no
AC_MSG_RESULT([$enable_fortran])
test "x$enable_remote_fortran_bootstrap" = xyes || enable_remote_fortran_bootstrap=no
AC_MSG_RESULT([$enable_remote_fortran_bootstrap])
# Does the user want to turn on PNETCDF read ability?
AC_MSG_CHECKING([whether parallel I/O for classic and 64-bit offset files using parallel-netcdf is to be enabled])
@ -872,7 +872,7 @@ if test "x$enable_netcdf_4" = xyes; then
fi
# Check for downloading/building fortran via postinstall script.
if test "x$enable_fortran" = xyes; then
if test "x$enable_remote_fortran_bootstrap" = xyes; then
AC_DEFINE([BUILD_FORTRAN], 1, [If true, will attempt to download and build netcdf-fortran.])
fi
@ -943,7 +943,7 @@ AM_CONDITIONAL(USE_NETCDF4, [test x$enable_netcdf_4 = xyes])
AM_CONDITIONAL(USE_HDF4, [test x$enable_hdf4 = xyes])
AM_CONDITIONAL(USE_HDF4_FILE_TESTS, [test x$enable_hdf4_file_tests = xyes])
AM_CONDITIONAL(USE_RENAMEV3, [test x$enable_netcdf_4 = xyes -o x$enable_dap = xyes])
AM_CONDITIONAL(BUILD_FORTRAN, [test x$enable_fortran = xyes])
AM_CONDITIONAL(BUILD_FORTRAN, [test x$enable_remote_fortran_bootstrap = xyes])
AM_CONDITIONAL(USE_PNETCDF, [test x$enable_pnetcdf = xyes])
AM_CONDITIONAL(USE_DISPATCH, [test x$enable_dispatch = xyes])
AM_CONDITIONAL(BUILD_CDMREMOTE, [test "x$enable_cdmremote" = xyes]) # Alias