CI, DBG: Upload MinGW test logs on failure.

.github/workflows/run_tests_win_mingw.yml

@@ -48,9 +48,24 @@ jobs:
         run: cat libnetcdf.settings
 
       - name: (Autotools) Build Library and Utilities
-        run: make -j 8 LDFLAGS='-Wl,--export-all-symbols'
+        run: make -j 8 LDFLAGS="-Wl,--export-all-symbols"
         if: ${{ success() }}
 
+      - name: Check for plugins
+        run: |
+          dir ./plugins
+          dir ./plugins/.libs
+
       - name: (Autotools) Build and Run Tests
-        run: make check -j 8
+        run: make check -j 8 LDFLAGS="-Wl,--export-all-symbols"
         if: ${{ success() }}
+        id: tests
+
+      - name: Upload test failures
+        if: ${{ failure() && steps.tests.conclusion == 'failure' }}
+        uses: actions/upload-artifact@v3
+        with:
+          name: test-logs
+          path: |
+            */*.log
+            */*.trs

plugins/Makefile.am

@@ -26,6 +26,7 @@ plugins_to_install =
 # tmpdir = ${ALTPLUGINDIR}
 
 check_LTLIBRARIES =
+noinst_LTLIBRARIES =
 
 # This linker flag specifies libtool version info.
 # See http://www.gnu.org/software/libtool/manual/libtool.html#Libtool-versioning
@@ -120,7 +121,9 @@ lib__nczmisc_la_LDFLAGS = ${plugin_version_info} $(AM_LDFLAGS) -rpath $(abs_buil
 lib__nch5unknown_la_SOURCES = H5Zunknown.c
 lib__nch5unknown_la_LDFLAGS = ${plugin_version_info} $(AM_LDFLAGS) -rpath $(abs_builddir)/.libs
 
-check_LTLIBRARIES += lib__nch5noop.la lib__nch5noop1.la lib__nch5misc.la lib__nczmisc.la lib__nch5unknown.la
+check_LTLIBRARIES += lib__nch5noop.la lib__nch5noop1.la lib__nch5unknown.la
+# findplugin.sh needs these plugins, and I want to see if these get built properly
+noinst_LTLIBRARIES += lib__nch5misc.la lib__nczmisc.la
 
 # Bzip2 is used to test more complex filters
 lib__nch5bzip2_la_SOURCES = H5Zbzip2.c h5bzip2.h
@@ -135,9 +138,9 @@ plugins_to_install += lib__nch5bzip2.la
 endif #ENABLE_FILTER_TESTING
 
 if ENABLE_PLUGIN_DIR
-plugin_LTLIBRARIES = $(plugins_to_install)
+plugin_LTLIBRARIES += $(plugins_to_install)
 else
-noinst_LTLIBRARIES = $(plugins_to_install)
+noinst_LTLIBRARIES += $(plugins_to_install)
 endif
 
 BUILT_SOURCES = H5Znoop1.c