2010-06-03 21:24:43 +08:00
|
|
|
## This is a automake file, part of Unidata's netCDF package.
|
2018-12-07 06:36:53 +08:00
|
|
|
# Copyright 2018, see the COPYRIGHT file for more information.
|
2010-06-03 21:24:43 +08:00
|
|
|
# This file builds and runs the ncdump program.
|
|
|
|
|
|
2017-11-23 03:10:58 +08:00
|
|
|
# Ed Hartnett, Dennis Heimbigner, Ward Fisher
|
2010-06-03 21:24:43 +08:00
|
|
|
|
2019-03-16 02:05:27 +08:00
|
|
|
#SH_LOG_DRIVER = $(SHELL) $(top_srcdir)/test-driver-verbose
|
|
|
|
|
#sh_LOG_DRIVER = $(SHELL) $(top_srcdir)/test-driver-verbose
|
|
|
|
|
#LOG_DRIVER = $(SHELL) $(top_srcdir)/test-driver-verbose
|
This PR adds EXPERIMENTAL support for accessing data in the
cloud using a variant of the Zarr protocol and storage
format. This enhancement is generically referred to as "NCZarr".
The data model supported by NCZarr is netcdf-4 minus the user-defined
types and the String type. In this sense it is similar to the CDF-5
data model.
More detailed information about enabling and using NCZarr is
described in the document NUG/nczarr.md and in a
[Unidata Developer's blog entry](https://www.unidata.ucar.edu/blogs/developer/en/entry/overview-of-zarr-support-in).
WARNING: this code has had limited testing, so do use this version
for production work. Also, performance improvements are ongoing.
Note especially the following platform matrix of successful tests:
Platform | Build System | S3 support
------------------------------------
Linux+gcc | Automake | yes
Linux+gcc | CMake | yes
Visual Studio | CMake | no
Additionally, and as a consequence of the addition of NCZarr,
major changes have been made to the Filter API. NOTE: NCZarr
does not yet support filters, but these changes are enablers for
that support in the future. Note that it is possible
(probable?) that there will be some accidental reversions if the
changes here did not correctly mimic the existing filter testing.
In any case, previously filter ids and parameters were of type
unsigned int. In order to support the more general zarr filter
model, this was all converted to char*. The old HDF5-specific,
unsigned int operations are still supported but they are
wrappers around the new, char* based nc_filterx_XXX functions.
This entailed at least the following changes:
1. Added the files libdispatch/dfilterx.c and include/ncfilter.h
2. Some filterx utilities have been moved to libdispatch/daux.c
3. A new entry, "filter_actions" was added to the NCDispatch table
and the version bumped.
4. An overly complex set of structs was created to support funnelling
all of the filterx operations thru a single dispatch
"filter_actions" entry.
5. Move common code to from libhdf5 to libsrc4 so that it is accessible
to nczarr.
Changes directly related to Zarr:
1. Modified CMakeList.txt and configure.ac to support both C and C++
-- this is in support of S3 support via the awd-sdk libraries.
2. Define a size64_t type to support nczarr.
3. More reworking of libdispatch/dinfermodel.c to
support zarr and to regularize the structure of the fragments
section of a URL.
Changes not directly related to Zarr:
1. Make client-side filter registration be conditional, with default off.
2. Hack include/nc4internal.h to make some flags added by Ed be unique:
e.g. NC_CREAT, NC_INDEF, etc.
3. cleanup include/nchttp.h and libdispatch/dhttp.c.
4. Misc. changes to support compiling under Visual Studio including:
* Better testing under windows for dirent.h and opendir and closedir.
5. Misc. changes to the oc2 code to support various libcurl CURLOPT flags
and to centralize error reporting.
6. By default, suppress the vlen tests that have unfixed memory leaks; add option to enable them.
7. Make part of the nc_test/test_byterange.sh test be contingent on remotetest.unidata.ucar.edu being accessible.
Changes Left TO-DO:
1. fix provenance code, it is too HDF5 specific.
2020-06-29 08:02:47 +08:00
|
|
|
#TESTS_ENVIRONMENT += export SETX=1;
|
2018-03-03 07:55:58 +08:00
|
|
|
|
2011-03-22 04:31:56 +08:00
|
|
|
# Put together AM_CPPFLAGS and AM_LDFLAGS.
|
|
|
|
|
include $(top_srcdir)/lib_flags.am
|
2014-08-26 04:30:11 +08:00
|
|
|
LDADD = ${top_builddir}/liblib/libnetcdf.la
|
2018-08-02 04:27:09 +08:00
|
|
|
noinst_PROGRAMS=
|
2017-11-17 23:22:49 +08:00
|
|
|
# Note which tests depend on other tests. Necessary for make -j check.
|
|
|
|
|
TEST_EXTENSIONS = .sh
|
2017-11-21 08:26:06 +08:00
|
|
|
XFAIL_TESTS=""
|
2017-11-17 23:22:49 +08:00
|
|
|
|
This PR adds EXPERIMENTAL support for accessing data in the
cloud using a variant of the Zarr protocol and storage
format. This enhancement is generically referred to as "NCZarr".
The data model supported by NCZarr is netcdf-4 minus the user-defined
types and the String type. In this sense it is similar to the CDF-5
data model.
More detailed information about enabling and using NCZarr is
described in the document NUG/nczarr.md and in a
[Unidata Developer's blog entry](https://www.unidata.ucar.edu/blogs/developer/en/entry/overview-of-zarr-support-in).
WARNING: this code has had limited testing, so do use this version
for production work. Also, performance improvements are ongoing.
Note especially the following platform matrix of successful tests:
Platform | Build System | S3 support
------------------------------------
Linux+gcc | Automake | yes
Linux+gcc | CMake | yes
Visual Studio | CMake | no
Additionally, and as a consequence of the addition of NCZarr,
major changes have been made to the Filter API. NOTE: NCZarr
does not yet support filters, but these changes are enablers for
that support in the future. Note that it is possible
(probable?) that there will be some accidental reversions if the
changes here did not correctly mimic the existing filter testing.
In any case, previously filter ids and parameters were of type
unsigned int. In order to support the more general zarr filter
model, this was all converted to char*. The old HDF5-specific,
unsigned int operations are still supported but they are
wrappers around the new, char* based nc_filterx_XXX functions.
This entailed at least the following changes:
1. Added the files libdispatch/dfilterx.c and include/ncfilter.h
2. Some filterx utilities have been moved to libdispatch/daux.c
3. A new entry, "filter_actions" was added to the NCDispatch table
and the version bumped.
4. An overly complex set of structs was created to support funnelling
all of the filterx operations thru a single dispatch
"filter_actions" entry.
5. Move common code to from libhdf5 to libsrc4 so that it is accessible
to nczarr.
Changes directly related to Zarr:
1. Modified CMakeList.txt and configure.ac to support both C and C++
-- this is in support of S3 support via the awd-sdk libraries.
2. Define a size64_t type to support nczarr.
3. More reworking of libdispatch/dinfermodel.c to
support zarr and to regularize the structure of the fragments
section of a URL.
Changes not directly related to Zarr:
1. Make client-side filter registration be conditional, with default off.
2. Hack include/nc4internal.h to make some flags added by Ed be unique:
e.g. NC_CREAT, NC_INDEF, etc.
3. cleanup include/nchttp.h and libdispatch/dhttp.c.
4. Misc. changes to support compiling under Visual Studio including:
* Better testing under windows for dirent.h and opendir and closedir.
5. Misc. changes to the oc2 code to support various libcurl CURLOPT flags
and to centralize error reporting.
6. By default, suppress the vlen tests that have unfixed memory leaks; add option to enable them.
7. Make part of the nc_test/test_byterange.sh test be contingent on remotetest.unidata.ucar.edu being accessible.
Changes Left TO-DO:
1. fix provenance code, it is too HDF5 specific.
2020-06-29 08:02:47 +08:00
|
|
|
if ! ENABLE_UNFIXED_MEMORY_LEAKS
|
|
|
|
|
AM_TESTS_ENVIRONMENT += export NC_VLEN_NOTEST=1;
|
|
|
|
|
endif
|
|
|
|
|
|
2011-03-22 04:31:56 +08:00
|
|
|
# This is the program we're building, and it's sources.
|
2014-08-26 04:30:11 +08:00
|
|
|
bin_PROGRAMS = ncdump
|
2017-11-12 07:45:03 +08:00
|
|
|
ncdump_SOURCES = ncdump.c vardata.c dumplib.c indent.c nctime0.c \
|
2020-08-18 09:15:47 +08:00
|
|
|
ncdump.h vardata.h dumplib.h indent.h nctime0.h cdl.h utils.h \
|
2017-11-12 07:45:03 +08:00
|
|
|
utils.c nciter.h nciter.c nccomps.h
|
2011-03-22 04:31:56 +08:00
|
|
|
|
|
|
|
|
# Another utility program that copies any netCDF file using only the
|
|
|
|
|
# netCDF API
|
|
|
|
|
bin_PROGRAMS += nccopy
|
2017-11-12 07:45:03 +08:00
|
|
|
nccopy_SOURCES = nccopy.c nciter.c nciter.h chunkspec.h chunkspec.c \
|
2018-07-27 10:16:02 +08:00
|
|
|
utils.h utils.c dimmap.h dimmap.c list.c list.h
|
2011-03-22 04:31:56 +08:00
|
|
|
|
2019-03-24 04:02:39 +08:00
|
|
|
# Wei-keng Liao's (wkliao@eecs.northwestern.edu)
|
|
|
|
|
# netcdf-3 validator program
|
|
|
|
|
# (https://github.com/Parallel-NetCDF/PnetCDF/blob/master/src/utils/ncvalidator/ncvalidator.c)
|
|
|
|
|
# that prints out the structure of a netcdf-3 file.
|
2020-03-12 02:49:33 +08:00
|
|
|
# This program is built but not installed.
|
2019-03-24 04:02:39 +08:00
|
|
|
noinst_PROGRAMS += ncvalidator
|
|
|
|
|
ncvalidator_SOURCES = ncvalidator.c
|
|
|
|
|
|
2017-11-18 03:29:12 +08:00
|
|
|
# A simple netcdf-4 metadata -> xml printer. Do not install.
|
2018-12-01 23:24:56 +08:00
|
|
|
if USE_HDF5
|
2020-09-16 04:56:12 +08:00
|
|
|
bin_PROGRAMS += nc4print
|
2018-08-02 04:27:09 +08:00
|
|
|
noinst_PROGRAMS += nc4print
|
2020-09-25 04:33:58 +08:00
|
|
|
nc4print_SOURCES = nc4print.c nc4printer.c
|
2017-03-09 08:01:10 +08:00
|
|
|
endif
|
|
|
|
|
|
|
|
|
|
# Conditionally build the ocprint program, but do not install
|
|
|
|
|
if ENABLE_DAP
|
2020-09-16 04:56:12 +08:00
|
|
|
bin_PROGRAMS += ocprint
|
2018-08-02 04:19:50 +08:00
|
|
|
noinst_PROGRAMS += ocprint
|
2017-11-12 07:45:03 +08:00
|
|
|
ocprint_SOURCES = ocprint.c
|
2017-03-09 08:01:10 +08:00
|
|
|
endif
|
|
|
|
|
|
2011-03-22 04:31:56 +08:00
|
|
|
# This is the man page.
|
|
|
|
|
man_MANS = ncdump.1 nccopy.1
|
|
|
|
|
|
2012-04-13 10:41:00 +08:00
|
|
|
if BUILD_TESTSETS
|
2019-09-18 10:27:43 +08:00
|
|
|
# C programs needed by shell scripts for classic tests.
|
2017-11-12 07:45:03 +08:00
|
|
|
check_PROGRAMS = rewrite-scalar ref_ctest ref_ctest64 ncdump tst_utf8 \
|
|
|
|
|
bom tst_dimsizes nctrunc
|
2016-05-04 11:17:06 +08:00
|
|
|
|
2017-11-18 03:29:12 +08:00
|
|
|
# Tests for classic and 64-bit offset files.
|
2017-11-25 22:28:07 +08:00
|
|
|
TESTS = tst_inttags.sh run_tests.sh tst_64bit.sh ref_ctest \
|
|
|
|
|
ref_ctest64 tst_output.sh tst_lengths.sh tst_calendars.sh \
|
2020-03-12 03:15:32 +08:00
|
|
|
run_utf8_tests.sh test_unicode_directory.sh tst_nccopy3.sh tst_nccopy3_subset.sh \
|
2017-11-25 22:28:07 +08:00
|
|
|
tst_charfill.sh tst_iter.sh tst_formatx3.sh tst_bom.sh \
|
2019-02-26 11:57:23 +08:00
|
|
|
tst_dimsizes.sh run_ncgen_tests.sh tst_ncgen4_classic.sh test_radix.sh
|
2017-11-18 01:16:17 +08:00
|
|
|
|
2017-11-25 22:30:17 +08:00
|
|
|
# The tst_nccopy3.sh test uses output from a bunch of other
|
|
|
|
|
# tests. This records the dependency so parallel builds work.
|
2017-11-18 02:07:24 +08:00
|
|
|
tst_nccopy3.log: tst_calendars.log run_utf8_tests.log tst_output.log \
|
2017-11-19 00:28:25 +08:00
|
|
|
tst_64bit.log run_tests.log tst_lengths.log
|
2016-05-04 11:17:06 +08:00
|
|
|
|
2017-11-21 06:06:10 +08:00
|
|
|
TESTS += tst_null_byte_padding.sh
|
2017-11-21 08:26:06 +08:00
|
|
|
if USE_STRICT_NULL_BYTE_HEADER_PADDING
|
|
|
|
|
XFAIL_TESTS += tst_null_byte_padding.sh
|
2017-11-21 06:06:10 +08:00
|
|
|
endif
|
|
|
|
|
|
2012-03-16 04:50:28 +08:00
|
|
|
if LARGE_FILE_TESTS
|
|
|
|
|
TESTS += tst_iter.sh
|
|
|
|
|
endif
|
|
|
|
|
|
2018-12-01 23:24:56 +08:00
|
|
|
if USE_HDF5
|
2020-08-18 09:15:47 +08:00
|
|
|
# HDF5 has some extra C programs to build. These will be run by
|
2017-11-18 03:29:12 +08:00
|
|
|
# the shell script tests.
|
|
|
|
|
check_PROGRAMS += tst_fileinfo tst_create_files tst_h_rdc0 \
|
|
|
|
|
tst_group_data tst_enum_data tst_opaque_data tst_string_data \
|
|
|
|
|
tst_vlen_data tst_comp tst_comp2 tst_nans tst_special_atts \
|
|
|
|
|
tst_unicode tst_fillbug tst_compress tst_chunking tst_h_scalar
|
|
|
|
|
|
2018-11-16 01:00:38 +08:00
|
|
|
check_PROGRAMS += tst_vlen_demo
|
|
|
|
|
|
2017-11-18 03:29:12 +08:00
|
|
|
# Tests for netCDF-4 behavior.
|
|
|
|
|
TESTS += tst_fileinfo.sh tst_hdf5_offset.sh tst_inttags4.sh \
|
|
|
|
|
tst_netcdf4.sh tst_fillbug.sh tst_netcdf4_4.sh tst_nccopy4.sh \
|
2018-07-27 10:16:02 +08:00
|
|
|
tst_nccopy5.sh tst_grp_spec.sh tst_mud.sh tst_h_scalar.sh tst_formatx4.sh \
|
2017-11-18 03:29:12 +08:00
|
|
|
run_utf8_nc4_tests.sh run_back_comp_tests.sh run_ncgen_nc4_tests.sh \
|
|
|
|
|
tst_ncgen4.sh
|
|
|
|
|
|
2018-07-27 10:16:02 +08:00
|
|
|
# Record interscript dependencies so parallel builds work.
|
2017-11-25 19:31:58 +08:00
|
|
|
tst_nccopy4.log: run_ncgen_tests.log tst_output.log tst_ncgen4.log \
|
2017-11-26 22:13:10 +08:00
|
|
|
tst_fillbug.log tst_netcdf4_4.log tst_h_scalar.log
|
2018-07-27 10:16:02 +08:00
|
|
|
tst_nccopy5.log: tst_nccopy4.log
|
2018-12-01 23:24:56 +08:00
|
|
|
endif #!USE_HDF5
|
2010-06-03 21:24:43 +08:00
|
|
|
|
2019-03-16 02:05:27 +08:00
|
|
|
TESTS += tst_inmemory_nc3.sh tst_nccopy_w3.sh
|
2018-12-01 23:24:56 +08:00
|
|
|
if USE_HDF5
|
2019-03-16 02:05:27 +08:00
|
|
|
TESTS += tst_inmemory_nc4.sh tst_nccopy_w4.sh
|
2017-11-18 03:29:12 +08:00
|
|
|
endif
|
2012-04-13 10:41:00 +08:00
|
|
|
|
2019-11-01 06:08:57 +08:00
|
|
|
if USE_HDF5
|
|
|
|
|
# Re-activate the ncgen -lc tests
|
2019-11-04 03:03:13 +08:00
|
|
|
TESTS += tst_ctests.sh
|
2019-11-01 06:08:57 +08:00
|
|
|
endif
|
|
|
|
|
|
2020-06-06 07:03:29 +08:00
|
|
|
if ENABLE_CDF5
|
|
|
|
|
# Test for keywords as identifiers
|
|
|
|
|
TESTS += test_keywords.sh
|
|
|
|
|
endif
|
|
|
|
|
|
2012-04-13 10:41:00 +08:00
|
|
|
endif BUILD_TESTSETS
|
|
|
|
|
|
2010-06-03 21:24:43 +08:00
|
|
|
# These files all have to be included with the distribution.
|
2017-11-18 03:29:12 +08:00
|
|
|
EXTRA_DIST = run_tests.sh tst_64bit.sh tst_output.sh test0.cdl \
|
|
|
|
|
ref_ctest1_nc4.cdl ref_ctest1_nc4c.cdl ref_tst_solar_1.cdl \
|
|
|
|
|
ref_tst_solar_2.cdl tst_netcdf4.sh tst_netcdf4_4.sh ref_tst_small.cdl \
|
|
|
|
|
tst_lengths.sh tst_ncml.cdl ref1.ncml ref_tst_group_data.cdl \
|
|
|
|
|
ref_tst_enum_data.cdl ref_tst_opaque_data.cdl ref_tst_string_data.cdl \
|
|
|
|
|
ref_tst_vlen_data.cdl ref_tst_comp.cdl ref_tst_unicode.cdl \
|
|
|
|
|
ref_tst_nans.cdl small.cdl small2.cdl $(man_MANS) run_utf8_tests.sh \
|
|
|
|
|
ref_tst_utf8.cdl ref_tst_fillbug.cdl tst_fillbug.sh tst_calendars.cdl \
|
|
|
|
|
tst_calendars.sh ref_times.cdl ref_tst_special_atts.cdl \
|
|
|
|
|
ref_tst_noncoord.cdl ref_tst_compounds2.nc ref_tst_compounds2.cdl \
|
|
|
|
|
ref_tst_compounds3.nc ref_tst_compounds3.cdl ref_tst_compounds4.nc \
|
|
|
|
|
ref_tst_compounds4.cdl ref_tst_group_data_v23.cdl tst_mslp.cdl \
|
|
|
|
|
tst_bug321.cdl ref_tst_format_att.cdl ref_tst_format_att_64.cdl \
|
2020-07-03 03:59:37 +08:00
|
|
|
tst_nccopy3.sh tst_nccopy4.sh tst_nccopy5.sh \
|
|
|
|
|
ref_nc_test_netcdf4_4_0.nc run_back_comp_tests.sh \
|
|
|
|
|
ref_nc_test_netcdf4.cdl ref_tst_special_atts3.cdl tst_brecs.cdl \
|
|
|
|
|
ref_tst_grp_spec0.cdl ref_tst_grp_spec.cdl tst_grp_spec.sh \
|
|
|
|
|
ref_tst_charfill.cdl tst_charfill.cdl tst_charfill.sh tst_iter.sh \
|
|
|
|
|
tst_mud.sh ref_tst_mud4.cdl ref_tst_mud4-bc.cdl \
|
|
|
|
|
ref_tst_mud4_chars.cdl inttags.cdl inttags4.cdl ref_inttags.cdl \
|
|
|
|
|
ref_inttags4.cdl ref_tst_ncf213.cdl tst_h_scalar.sh \
|
|
|
|
|
run_utf8_nc4_tests.sh tst_formatx3.sh tst_formatx4.sh \
|
|
|
|
|
ref_tst_utf8_4.cdl ref_tst_nc4_utf8_4.cdl tst_inttags.sh \
|
|
|
|
|
tst_inttags4.sh CMakeLists.txt tst_bom.sh tst_inmemory_nc3.sh \
|
|
|
|
|
tst_dimsizes.sh tst_inmemory_nc4.sh tst_fileinfo.sh \
|
|
|
|
|
run_ncgen_tests.sh ref_test_360_day_1900.nc ref_test_365_day_1900.nc \
|
2017-11-26 22:13:10 +08:00
|
|
|
ref_test_366_day_1900.nc ref_test_360_day_1900.cdl \
|
|
|
|
|
ref_test_365_day_1900.cdl ref_test_366_day_1900.cdl \
|
|
|
|
|
tst_hdf5_offset.sh run_ncgen_nc4_tests.sh tst_nccopy3_subset.sh \
|
|
|
|
|
ref_nccopy3_subset.nc ref_test_corrupt_magic.nc tst_ncgen_shared.sh \
|
|
|
|
|
tst_ncgen4.sh tst_ncgen4_classic.sh tst_ncgen4_diff.sh \
|
|
|
|
|
tst_ncgen4_cycle.sh tst_null_byte_padding.sh \
|
2020-07-03 03:59:37 +08:00
|
|
|
ref_null_byte_padding_test.nc ref_tst_irish_rover.nc \
|
|
|
|
|
ref_provenance_v1.nc ref_tst_radix.cdl tst_radix.cdl test_radix.sh \
|
|
|
|
|
ref_nccopy_w.cdl tst_nccopy_w3.sh tst_nccopy_w4.sh \
|
|
|
|
|
ref_no_ncproperty.nc test_unicode_directory.sh \
|
2020-12-08 02:29:12 +08:00
|
|
|
ref_roman_szip_simple.cdl ref_roman_szip_unlim.cdl ref_tst_perdimspecs.cdl \
|
Codify cross-platform file paths
The netcdf-c code has to deal with a variety of platforms:
Windows, OSX, Linux, Cygwin, MSYS, etc. These platforms differ
significantly in the kind of file paths that they accept. So in
order to handle this, I have created a set of replacements for
the most common file system operations such as _open_ or _fopen_
or _access_ to manage the file path differences correctly.
A more limited version of this idea was already implemented via
the ncwinpath.h and dwinpath.c code. So this can be viewed as a
replacement for that code. And in path in many cases, the only
change that was required was to replace '#include <ncwinpath.h>'
with '#include <ncpathmgt.h>' and then replace file operation
calls with the NCxxx equivalent from ncpathmgr.h Note that
recently, the ncwinpath.h was renamed ncpathmgmt.h, so this pull
request should not require dealing with winpath.
The heart of the change is include/ncpathmgmt.h, which provides
alternate operations such as NCfopen or NCaccess and which properly
parse and rebuild path arguments to work for the platform on which
the code is executing. This mostly matters for Windows because of the
way that it uses backslash and drive letters, as compared to *nix*.
One important feature is that the user can do string manipulations
on a file path without having to worry too much about the platform
because the path management code will properly handle most mixed cases.
So one can for example concatenate a path suffix that uses forward
slashes to a Windows path and have it work correctly.
The conversion code is in libdispatch/dpathmgr.c, and the
important function there is NCpathcvt which does the proper
conversions to the local path format.
As a rule, most code should just replace their file operations with
the corresponding NCxxx ones defined in include/ncpathmgmt.h. These
NCxxx functions all call NCpathcvt on their path arguments before
executing the actual file operation.
In some rare cases, the client may need to directly use NCpathcvt,
but this should be avoided as much as possible. If there is a need
for supporting a new file operation not already in ncpathmgmt.h, then
use the code in dpathmgr.c as a template. Also please notify Unidata
so we can include it as a formal part or our supported operations.
Also, if you see an operation in the library that is not using the
NCxxx form, then please submit an issue so we can fix it.
Misc. Changes:
* Clean up the utf8 testing code; it is impossible to get some
tests to work under windows using shell scripts; the args do
not pass as utf8 but as some other encoding.
* Added an extra utf8 test case: test_unicode_path.sh
* Add a true test for HDF5 1.10.6 or later because as noted in
PR https://github.com/Unidata/netcdf-c/pull/1794,
HDF5 changed its Windows file path handling.
2021-03-05 04:41:31 +08:00
|
|
|
test_keywords.sh ref_keyword1.cdl ref_keyword2.cdl ref_tst_nofilters.cdl \
|
|
|
|
|
test_unicode_path.sh
|
re e-support UBS-599337
re pull request https://github.com/Unidata/netcdf-c/pull/405
re pull request https://github.com/Unidata/netcdf-c/pull/446
Notes:
1. This branch is a cleanup of the magic.dmh branch.
2. magic.dmh was originally merged, but caused problems with parallel IO.
It was re-issued as pull request https://github.com/Unidata/netcdf-c/pull/446.
3. This branch + pull request replace any previous pull requests and magic.dmh branch.
Given an otherwise valid netCDF file that has a corrupted header,
the netcdf library currently crashes. Instead, it should return
NC_ENOTNC.
Additionally, the NC_check_file_type code does not do the
forward search required by hdf5 files. It currently only looks
at file position 0 instead of 512, 1024, 2048,... Also, it turns
out that the HDF4 magic number is assumed to always be at the
beginning of the file (unlike HDF5).
The change is localized to libdispatch/dfile.c See
https://support.hdfgroup.org/release4/doc/DSpec_html/DS.pdf
Also, it turns out that the code in NC_check_file_type is duplicated
(mostly) in the function libsrc4/nc4file.c#nc_check_for_hdf.
This branch does the following.
1. Make NC_check_file_type return NC_ENOTNC instead of crashing.
2. Remove nc_check_for_hdf and centralize all file format checking
NC_check_file_type.
3. Add proper forward search for HDF5 files (but not HDF4 files)
to look for the magic number at offsets of 0, 512, 1024...
4. Add test tst_hdf5_offset.sh. This tests that hdf5 files with
an offset are properly recognized. It does so by prefixing
a legal file with some number of zero bytes: 512, 1024, etc.
5. Off-topic: Added -N flag to ncdump to force a specific output dataset name.
2017-10-25 06:25:09 +08:00
|
|
|
|
|
|
|
|
# The L512.bin file is file containing exactly 512 bytes each of value 0.
|
|
|
|
|
# It is used for creating hdf5 files with varying offsets for testing.
|
|
|
|
|
EXTRA_DIST += L512.bin
|
2012-01-10 02:49:15 +08:00
|
|
|
|
2019-11-06 04:43:59 +08:00
|
|
|
EXTRA_DIST += tst_ctests.sh ref_ctest_small_3.c ref_ctest_small_4.c \
|
2019-11-04 03:03:13 +08:00
|
|
|
ref_ctest_special_atts_4.c
|
2019-11-01 06:08:57 +08:00
|
|
|
|
2014-09-19 08:26:06 +08:00
|
|
|
# CDL files and Expected results
|
2017-11-18 03:29:12 +08:00
|
|
|
SUBDIRS = cdl expected
|
|
|
|
|
|
2017-11-19 05:20:04 +08:00
|
|
|
CLEANFILES = tst_*.nc tmp*.nc test*.nc iter.* tmp*.cdl \
|
2018-11-19 05:59:05 +08:00
|
|
|
tst_output_*.cdl tst_output_*.c tst_utf8_*.cdl *.tmp tst_tst8.cdl \
|
|
|
|
|
tst_netcdf4_*.cdl test1_ncdump.cdl test2_ncdump.cdl test1.cdl \
|
|
|
|
|
ctest1.cdl test1_cdf5.cdl test2_cdf5.cdl test1_offset.cdl \
|
2017-11-26 23:50:16 +08:00
|
|
|
test2_offset.cdl ctest0.nc ctest0_64.nc c1.cdl c1_4.cdl ctest1_64.cdl \
|
|
|
|
|
c0.nc c0_4.nc small.nc small2.nc c0tmp.nc c1.ncml utf8.cdl \
|
|
|
|
|
utf8_64.cdl utf8.nc utf8_64.nc nc4_utf8.cdl nc4_utf8.nc \
|
|
|
|
|
tst_unicode.cdl tst_group_data.cdl tst_compounds2.cdl tst_comp.cdl \
|
|
|
|
|
tst_enum_data.cdl tst_small.cdl tst_times.cdl tst_solar_2.cdl \
|
|
|
|
|
tst_string_data.cdl tst_fillbug.cdl tst_opaque_data.cdl \
|
|
|
|
|
tst_compounds4.cdl tst_utf8.cdl tst_compounds3.cdl \
|
|
|
|
|
tst_special_atts.cdl tst_nans.cdl tst_format_att_64.cdl \
|
|
|
|
|
tst_vlen_data.cdl tst_solar_1.cdl tst_format_att.cdl \
|
|
|
|
|
tst_nc_test_netcdf4_4_0.cdl tst_mud4.cdl tst_mud4-bc.cdl \
|
|
|
|
|
tst_ncf213.cdl tst_h_scalar.cdl tst_mud4_chars.cdl inttags.nc \
|
|
|
|
|
inttags4.nc tst_inttags.cdl tst_inttags4.cdl nc4_fileinfo.nc \
|
|
|
|
|
hdf5_fileinfo.hdf nccopy3_subset_out.nc c5.nc \
|
2017-11-19 05:20:04 +08:00
|
|
|
compound_datasize_test.nc compound_datasize_test2.nc ncf199.nc \
|
|
|
|
|
tst_c0.cdl tst_c0_4.cdl tst_c0_4c.cdl tst_c0_64.cdl \
|
2017-11-12 08:33:51 +08:00
|
|
|
tst_compound_datasize_test.cdl tst_compound_datasize_test2.cdl \
|
2017-11-19 05:20:04 +08:00
|
|
|
tst_ncf199.cdl tst_tst_gattenum.cdl tst_tst_usuffix.cdl ctest.c \
|
2020-07-04 02:56:22 +08:00
|
|
|
ctest64.c nccopy3_subset_out.nc camrun.c tst_ncf213.cdl tst_ncf213.nc \
|
|
|
|
|
tst_radix.nc tmp_radix.cdl ctest_small_3.c ctest_small_4.c \
|
|
|
|
|
ctest_special_atts_4.c tst_roman_szip_simple.cdl \
|
2020-12-08 02:29:12 +08:00
|
|
|
tst_roman_szip_unlim.cdl tst_perdimpspecs.nc tmppds.* \
|
2020-06-06 07:03:29 +08:00
|
|
|
keyword1.nc keyword2.nc tmp_keyword1.cdl tmp_keyword2.cdl
|
