mirror/nasm
2
0
Fork 0
mirror of https://github.com/netwide-assembler/nasm.git synced 2024-11-27 08:10:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

preproc: make %exitrep do what it is supposed to

Browse Source 
%exitrep should should stop emitting code immediately, not just
terminate the loop when we hit %endrep. There is a bunch of hacky code
that special-cases that using istk->in_progress == 0.

The handling of the tail of %exitrep, %include and non-emitting
conditionals using entirely different mechanisms is just dumb. They
need to be unified.

Link: https://bugzilla.nasm.us/show_bug.cgi?id=3392612
Reported-by: Jason Hood <jadoxa@yahoo.com.au>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
This commit is contained in:
H. Peter Anvin 2019-10-07 21:19:32 -07:00
parent 58bd8e6644
commit d983b62233
2 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
asm/preproc.c
View File

@ -3986,7 +3986,7 @@ issue_error:
break;
if (l)
l->finishes->in_progress = 1;
l->finishes->in_progress = 0;
else
nasm_nonfatal("`%%exitrep' not within `%%rep' block");
break;

16
test/exitrep.asm Normal file
View File

@ -0,0 +1,16 @@
%macro testrep 0.nolist
%assign i 1
%rep 4
mov eax,i
%if i==3
%exitrep
%endif
mov ebx,i
%ifn i < 3
%error iteration i should not be seen
%endif
%assign i i+1
%endrep
%endmacro
testrep