mirror/nasm
2
0
Fork 0
mirror of https://github.com/netwide-assembler/nasm.git synced 2025-03-31 18:20:22 +08:00
Code Issues Packages Projects Releases Wiki Activity

BR 2822263: don't re-invoke ofmt->symdef() in pass2 unless "special"

Browse Source 
Before checkin aeb0e0e9f1e7e9b32a8f17f2259311f6e9207aa6 we would only
invoke ofmt->symdef() for a common variable during pass 2 if that
variable had "special" in the declaration.  That checkin
unintentionally changed that behavior.

That doesn't mean that the pre-existing behavior is right, but this
should at least fix the resulting regressions.  This really warrants
more investigation.

Signed-off-by: H. Peter Anvin <hpa@zytor.com>
This commit is contained in:
H. Peter Anvin 2009-07-16 22:32:33 -04:00
parent e5b9d2dac0
commit 8a962b3efd
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
nasm.c
View File

@ -1368,7 +1368,8 @@ static void assemble_file(char *fname, StrList **depend_ptr)
define_common(value, seg_alloc(), size,
special, ofmt, report_error);
} else if (pass0 == 2) {
ofmt->symdef(value, 0L, 0L, 3, special);
if (special)
ofmt->symdef(value, 0L, 0L, 3, special);
}
break;
}