From 34539fb1eda513cabaa26c6073725b399f604e75 Mon Sep 17 00:00:00 2001
From: "H. Peter Anvin" <hpa@zytor.com>
Date: Wed, 30 May 2007 04:27:58 +0000
Subject: [PATCH] Remove bogus redundant tests

Remove tests that are bogus (they trigger for legitimate instructions.)
The failure cases are okay anyway since they will be trapped by the
REX generation logic.
---
 assemble.c | 36 ++++++++++++++----------------------
 1 file changed, 14 insertions(+), 22 deletions(-)

diff --git a/assemble.c b/assemble.c
index 6bffce3f..0142e7a6 100644
--- a/assemble.c
+++ b/assemble.c
@@ -523,17 +523,24 @@ int32_t assemble(int32_t segment, int32_t offset, int bits, uint32_t cp,
     }
 
     if (temp->opcode == -1) {   /* didn't match any instruction */
-        if (size_prob == 1)     /* would have matched, but for size */
-            error(ERR_NONFATAL, "operation size not specified");
-        else if (size_prob == 2)
+	switch (size_prob) {
+	case 1:
+	    error(ERR_NONFATAL, "operation size not specified");
+	    break;
+	case 2:
             error(ERR_NONFATAL, "mismatch in operand sizes");
-        else if (size_prob == 3)
+	    break;
+	case 3:
             error(ERR_NONFATAL, "no instruction for this cpu level");
-        else if (size_prob == 4)
+	    break;
+	case 4:
             error(ERR_NONFATAL, "instruction not supported in 64-bit mode");
-        else
+	    break;
+	default:
             error(ERR_NONFATAL,
                   "invalid combination of opcode and operands");
+	    break;
+	}
     }
     return 0;
 }
@@ -1502,7 +1509,7 @@ static int rexflags(int val, int32_t flags, int mask)
 
 static int matches(struct itemplate *itemp, insn * instruction, int bits)
 {
-    int i, b, x, size[3], asize, oprs, ret;
+    int i, size[3], asize, oprs, ret;
 
     ret = 100;
 
@@ -1565,8 +1572,6 @@ static int matches(struct itemplate *itemp, insn * instruction, int bits)
         } else if (itemp->flags & IF_SD) {
             size[i] = BITS32;
         } else if (itemp->flags & IF_SQ) {
-            if (bits != 64)
-                return 5;
             size[i] = BITS64;
         }
     } else {
@@ -1581,8 +1586,6 @@ static int matches(struct itemplate *itemp, insn * instruction, int bits)
             asize = BITS32;
             oprs = itemp->operands;
         } else if (itemp->flags & IF_SQ) {
-            if (bits != 64)
-                return 5;
             asize = BITS64;
             oprs = itemp->operands;
         }
@@ -1608,17 +1611,6 @@ static int matches(struct itemplate *itemp, insn * instruction, int bits)
         if (!(itemp->opd[i] & SIZE_MASK) &&
             (instruction->oprs[i].type & SIZE_MASK & ~size[i]))
             return 2;
-
-        x = instruction->oprs[i].indexreg;
-        b = instruction->oprs[i].basereg;
-        
-        if (x != -1 && x >= EXPR_REG_START && x < REG_ENUM_LIMIT)
-            x = regvals[x];
-        if (b != -1 && b >= EXPR_REG_START && b < REG_ENUM_LIMIT)
-            b = regvals[b];
-            
-        if (((b >= 0400 && b <= 0500) || (x >= 0400 && x < 0500)) && bits != 64)
-            return 2;
     }
 
     /*