From 56a0a59d2e1f3fc4d501467fc0213d9e6c4b7a78 Mon Sep 17 00:00:00 2001 From: 07akioni <07akioni2@gmail.com> Date: Sun, 13 Jun 2021 15:03:04 +0800 Subject: [PATCH] refactor(rate): clean codes --- src/rate/demos/enUS/color.demo.md | 7 +++---- src/rate/demos/enUS/index.demo-entry.md | 4 ++-- src/rate/demos/zhCN/color.demo.md | 8 +++----- src/rate/src/Rate.tsx | 12 +++++------- src/rate/styles/light.ts | 3 +-- 5 files changed, 14 insertions(+), 20 deletions(-) diff --git a/src/rate/demos/enUS/color.demo.md b/src/rate/demos/enUS/color.demo.md index 41ab2fb46..d71a34ac8 100644 --- a/src/rate/demos/enUS/color.demo.md +++ b/src/rate/demos/enUS/color.demo.md @@ -1,8 +1,7 @@ # Color +That's how disaster happens. + ```html - - - - + ``` diff --git a/src/rate/demos/enUS/index.demo-entry.md b/src/rate/demos/enUS/index.demo-entry.md index 2d9c17e3a..81a765177 100644 --- a/src/rate/demos/enUS/index.demo-entry.md +++ b/src/rate/demos/enUS/index.demo-entry.md @@ -14,12 +14,12 @@ icon ## Props | 名称 | 类型 | 默认值 | 说明 | -| --- | --- | --- | --- | --- | --- | +| --- | --- | --- | --- | | count | `number` | `5` | | | value | `number` | `undefined` | | | default-value | `number` | `0` | | | size | `'small' \| 'medium' \| 'large' \| number` | `'medium'` | | -| on-update:value | `(value: number) => void` | `undefined` | | | | +| on-update:value | `(value: number) => void` | `undefined` | | ## Slots diff --git a/src/rate/demos/zhCN/color.demo.md b/src/rate/demos/zhCN/color.demo.md index 0f4218ed4..33f1d0459 100644 --- a/src/rate/demos/zhCN/color.demo.md +++ b/src/rate/demos/zhCN/color.demo.md @@ -1,9 +1,7 @@ # 颜色 -灾难就这么发生了 +灾难就是这么发生的。 + ```html - - - - + ``` diff --git a/src/rate/src/Rate.tsx b/src/rate/src/Rate.tsx index 351e6381d..18af0aa06 100644 --- a/src/rate/src/Rate.tsx +++ b/src/rate/src/Rate.tsx @@ -25,10 +25,7 @@ const rateProps = { type: Number, default: 5 }, - value: { - type: Number, - default: undefined - }, + value: Number, defaultValue: { type: Number, default: 0 @@ -99,13 +96,14 @@ export default defineComponent({ const { size } = props const { common: { cubicBezierEaseInOut }, - self: { itemColor, itemColorActive, itemSize } + self } = themeRef.value - let mergedSize: string = itemSize + const { itemColor, itemColorActive } = self + let mergedSize: string if (typeof size === 'number') { mergedSize = `${size}px` } else { - mergedSize = themeRef.value.self[createKey('size', size)] + mergedSize = self[createKey('size', size)] } return { '--bezier': cubicBezierEaseInOut, diff --git a/src/rate/styles/light.ts b/src/rate/styles/light.ts index 5e7a89cb9..d926c530a 100644 --- a/src/rate/styles/light.ts +++ b/src/rate/styles/light.ts @@ -7,8 +7,7 @@ const self = (vars: ThemeCommonVars) => { return { itemColor: railColor, itemColorActive: '#FFCC33', - itemSize: '20px', - sizeSmall: '14px', + sizeSmall: '16px', sizeMedium: '20px', sizeLarge: '24px' }