fix(tests): remove full-icu, test on both node 12 and 14

.eslintrc

@@ -9,7 +9,7 @@
   "plugins": ["import", "jsx-a11y", "prettier", "react", "react-hooks"],
   "rules": {
     "prettier/prettier": "error",
-    "import/no-cycle": "warn",
+    "import/no-cycle": "off",
     "no-underscore-dangle": "off",
     "no-param-reassign": "warn",
     "no-nested-ternary": "warn",

.github/workflows/test.yml

@@ -8,7 +8,8 @@ on:
       - develop
 
 jobs:
-  test-and-build:
+  # can't use matrix since tests are different between node 12 and 14
+  test-node-12:
     runs-on: ubuntu-latest
     steps:
       - name: Setup Node
@@ -16,6 +17,22 @@ jobs:
         with:
           node-version: '12.x'
       - uses: actions/checkout@v2
+      - name: Check yarn cache integrity
+        run: yarn install --immutable --immutable-cache
+      - name: Build packages
+        run: yarn build
+      # format tests don't pass on node 12 since icu is missing
+      - name: Test packages
+        run: yarn test --ignore='@lowdefy/format'
+
+  test-node-14:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Setup Node
+        uses: actions/setup-node@v1
+        with:
+          node-version: '14.x'
+      - uses: actions/checkout@v2
       - name: Check yarn cache integrity
         run: yarn install --immutable --immutable-cache
       - name: Build packages

.pnp.js

@@ -4725,7 +4725,6 @@ function $$SETUP_STATE(hydrateRuntimeState, basePath) {
             ["eslint-config-airbnb", "virtual:b6fa685df68481df8aea241d69a5d4ac044afe9a6d5347abc450d1a9a0b048b47a068daa4b51891dcc21a6f39ddd0469d8cb1b5ac2b845697d880ad1457b4396#npm:18.2.0"],
             ["eslint-config-prettier", "virtual:b6fa685df68481df8aea241d69a5d4ac044afe9a6d5347abc450d1a9a0b048b47a068daa4b51891dcc21a6f39ddd0469d8cb1b5ac2b845697d880ad1457b4396#npm:6.12.0"],
             ["eslint-plugin-prettier", "virtual:b6fa685df68481df8aea241d69a5d4ac044afe9a6d5347abc450d1a9a0b048b47a068daa4b51891dcc21a6f39ddd0469d8cb1b5ac2b845697d880ad1457b4396#npm:3.1.4"],
-            ["full-icu", "npm:1.3.1"],
             ["jest", "npm:24.9.0"],
             ["jest-diff", "npm:24.9.0"],
             ["moment", "npm:2.28.0"],
@@ -11847,15 +11846,6 @@ function $$SETUP_STATE(hydrateRuntimeState, basePath) {
           "linkType": "HARD",
         }]
       ]],
-      ["full-icu", [
-        ["npm:1.3.1", {
-          "packageLocation": "./.yarn/unplugged/full-icu-npm-1.3.1-e7a1988690/node_modules/full-icu/",
-          "packageDependencies": [
-            ["full-icu", "npm:1.3.1"]
-          ],
-          "linkType": "HARD",
-        }]
-      ]],
       ["function-bind", [
         ["npm:1.1.1", {
           "packageLocation": "./.yarn/cache/function-bind-npm-1.1.1-b56b322ae9-ffad86e7d2.zip/node_modules/function-bind/",

packages/format/package.json

@@ -11,7 +11,6 @@
     "prepublishOnly": "yarn build"
   },
   "dependencies": {
-    "full-icu": "1.3.1",
     "moment": "2.28.0"
   },
   "devDependencies": {

yarn.lock

@@ -3156,7 +3156,6 @@ __metadata:
     eslint-config-airbnb: 18.2.0
     eslint-config-prettier: 6.12.0
     eslint-plugin-prettier: 3.1.4
-    full-icu: 1.3.1
     jest: 24.9.0
     jest-diff: 24.9.0
     moment: 2.28.0
@@ -9366,15 +9365,6 @@ fsevents@^1.2.7:
   languageName: node
   linkType: hard
 
-"full-icu@npm:1.3.1":
-  version: 1.3.1
-  resolution: "full-icu@npm:1.3.1"
-  bin:
-    node-full-icu-path: ./node-icu-data.js
-  checksum: 1c6c6819164d3e79a7378e53f4b145664956c7ef43acd522e77899885cba2f7f47bcc3b0184ed45ed1e39e8fa64072bcc8c98ad296ccea9999acf3fb852677c1
-  languageName: node
-  linkType: hard
-
 "function-bind@npm:^1.1.1":
   version: 1.1.1
   resolution: "function-bind@npm:1.1.1"