mirror/lowdefy
2
0
Fork 0
mirror of https://github.com/lowdefy/lowdefy.git synced 2025-04-06 15:30:30 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat: Allow custom openid authorization url parameters.

Browse Source 
Closes #546
This commit is contained in:
SamTolmay 2021-05-03 11:49:26 +02:00
parent c641774606
commit 427b3a1003
4 changed files with 56 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packages/graphql/src/controllers/openIdController.js
View File

@ -63,7 +63,7 @@ class OpenIdController {
});
}
async authorizationUrl({ input, pageId, urlQuery }) {
async authorizationUrl({ authUrlQueryParams, input, pageId, urlQuery }) {
try {
const config = await this.getOpenIdConfig();
if (!config) return null;
@ -73,15 +73,16 @@ class OpenIdController {
pageId,
urlQuery,
});
return this.getAuthorizationUrl({ config, state });
return this.getAuthorizationUrl({ authUrlQueryParams, config, state });
} catch (error) {
throw new ConfigurationError(error);
}
}
async getAuthorizationUrl({ config, state }) {
async getAuthorizationUrl({ authUrlQueryParams, config, state }) {
const client = await this.getClient({ config });
const url = client.authorizationUrl({
...authUrlQueryParams,
redirect_uri: this.redirectUri,
response_type: 'code',
scope: config.scope || 'openid profile email',

53
packages/graphql/src/controllers/openIdController.test.js
View File

@ -24,8 +24,8 @@ jest.mock('openid-client');
const mockOpenIdAuthorizationUrl = jest.fn(
// eslint-disable-next-line camelcase
({ redirect_uri, response_type, scope, state }) =>
`${redirect_uri}:${response_type}:${scope}:${state}`
({ redirect_uri, response_type, scope, state, ...additional }) =>
`${redirect_uri}:${response_type}:${scope}:${state}:${JSON.stringify(additional)}`
);
const mockOpenIdCallback = jest.fn(() => ({
@ -189,7 +189,7 @@ describe('authorizationUrl', () => {
],
]);
expect(url).toEqual(
'https://host/auth/openid-callback:code:openid profile email:eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpbnB1dCI6eyJpIjp0cnVlfSwibG93ZGVmeV9vcGVuaWRfc3RhdGVfdG9rZW4iOnRydWUsInBhZ2VJZCI6InBhZ2VJZCIsInVybFF1ZXJ5Ijp7InUiOnRydWV9LCJpYXQiOjEsImV4cCI6MzAxLCJhdWQiOiJob3N0IiwiaXNzIjoiaG9zdCJ9.-GLdtCspyagMhdx9z1VootZXXbIdLY3cbzpn5UK8eGI'
'https://host/auth/openid-callback:code:openid profile email:eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpbnB1dCI6eyJpIjp0cnVlfSwibG93ZGVmeV9vcGVuaWRfc3RhdGVfdG9rZW4iOnRydWUsInBhZ2VJZCI6InBhZ2VJZCIsInVybFF1ZXJ5Ijp7InUiOnRydWV9LCJpYXQiOjEsImV4cCI6MzAxLCJhdWQiOiJob3N0IiwiaXNzIjoiaG9zdCJ9.-GLdtCspyagMhdx9z1VootZXXbIdLY3cbzpn5UK8eGI:{}'
);
});
@ -205,7 +205,7 @@ describe('authorizationUrl', () => {
const openIdController = createOpenIdController(context);
const url = await openIdController.authorizationUrl(authorizationUrlInput);
expect(url).toEqual(
'https://host/auth/openid-callback:code:custom scope:eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpbnB1dCI6eyJpIjp0cnVlfSwibG93ZGVmeV9vcGVuaWRfc3RhdGVfdG9rZW4iOnRydWUsInBhZ2VJZCI6InBhZ2VJZCIsInVybFF1ZXJ5Ijp7InUiOnRydWV9LCJpYXQiOjEsImV4cCI6MzAxLCJhdWQiOiJob3N0IiwiaXNzIjoiaG9zdCJ9.-GLdtCspyagMhdx9z1VootZXXbIdLY3cbzpn5UK8eGI'
'https://host/auth/openid-callback:code:custom scope:eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpbnB1dCI6eyJpIjp0cnVlfSwibG93ZGVmeV9vcGVuaWRfc3RhdGVfdG9rZW4iOnRydWUsInBhZ2VJZCI6InBhZ2VJZCIsInVybFF1ZXJ5Ijp7InUiOnRydWV9LCJpYXQiOjEsImV4cCI6MzAxLCJhdWQiOiJob3N0IiwiaXNzIjoiaG9zdCJ9.-GLdtCspyagMhdx9z1VootZXXbIdLY3cbzpn5UK8eGI:{}'
);
});
@ -230,6 +230,51 @@ describe('authorizationUrl', () => {
ConfigurationError
);
});
test('authorizationUrl, additional query params', async () => {
getSecrets.mockImplementation(() => secrets);
const openIdController = createOpenIdController(context);
const url = await openIdController.authorizationUrl({
authUrlQueryParams: { screen_hint: 'sign-up' },
});
expect(mockClient.mock.calls).toEqual([
[
{
client_id: 'OPENID_CLIENT_ID',
client_secret: 'OPENID_CLIENT_SECRET',
redirect_uris: ['https://host/auth/openid-callback'],
},
],
]);
expect(url).toEqual(
'https://host/auth/openid-callback:code:openid profile email:eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJsb3dkZWZ5X29wZW5pZF9zdGF0ZV90b2tlbiI6dHJ1ZSwiaWF0IjoxLCJleHAiOjMwMSwiYXVkIjoiaG9zdCIsImlzcyI6Imhvc3QifQ.-UtxdTFvQW6pFFFHTO0EtmubPbkDl8EJQwBQA2pp_M4:{"screen_hint":"sign-up"}'
);
});
test('authorizationUrl, additional query do not overwrite fiexed params', async () => {
getSecrets.mockImplementation(() => secrets);
const openIdController = createOpenIdController(context);
const url = await openIdController.authorizationUrl({
authUrlQueryParams: {
redirect_uri: 'overwritten',
response_type: 'overwritten',
scope: 'overwritten',
state: 'overwritten',
},
});
expect(mockClient.mock.calls).toEqual([
[
{
client_id: 'OPENID_CLIENT_ID',
client_secret: 'OPENID_CLIENT_SECRET',
redirect_uris: ['https://host/auth/openid-callback'],
},
],
]);
expect(url).toEqual(
'https://host/auth/openid-callback:code:openid profile email:eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJsb3dkZWZ5X29wZW5pZF9zdGF0ZV90b2tlbiI6dHJ1ZSwiaWF0IjoxLCJleHAiOjMwMSwiYXVkIjoiaG9zdCIsImlzcyI6Imhvc3QifQ.-UtxdTFvQW6pFFFHTO0EtmubPbkDl8EJQwBQA2pp_M4:{}'
);
});
});
describe('callback', () => {

1
packages/graphql/src/schema.js
View File

@ -71,6 +71,7 @@ const typeDefs = gql`
}
input OpenIdAuthorizationUrlInput {
authUrlQueryParams: JSON
input: JSON
pageId: String
urlQuery: JSON

3
packages/renderer/src/utils/auth/createLogin.js
View File

@ -24,13 +24,14 @@ const GET_LOGIN = gql`
`;
function createLogin({ client, window }) {
async function login({ input, pageId, urlQuery } = {}) {
async function login({ authUrlQueryParams, input, pageId, urlQuery } = {}) {
try {
const { data } = await client.query({
query: GET_LOGIN,
fetchPolicy: 'network-only',
variables: {
openIdAuthorizationUrlInput: {
authUrlQueryParams,
input,
pageId,
urlQuery,