mirror of
git://git.savannah.gnu.org/libtool.git
synced 2025-01-18 14:16:00 +08:00
a9d07029d6
AIX has a brain-dead grep that only handles lines < 2048 characters. Default GREP incase we are not using a future autoconf that sets it for us :-) Changed all callers to use $GREP instead of grep, and to AC_REQUIRE LT_AC_PROG_EGREP. Declare GREP as a libtool config var. * ltmain.in: Use it. * tests/sh.test (scripts): Accept `if $GREP "^foo=bar"' by tightening the regexp. Reported by Albert Chin-A-Young <china@thewrittenword.com>
95 lines
3.2 KiB
Bash
Executable File
95 lines
3.2 KiB
Bash
Executable File
#! /bin/sh
|
|
# sh.test - check that we haven't forgotten a `test' command
|
|
|
|
# Copyright (C) 2003 Free Software Foundation, Inc.
|
|
# This is free software; see the source for copying conditions. There is NO
|
|
# warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 2 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
# General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program; if not, a copy can be downloaded from
|
|
# http://www.gnu.org/copyleft/gpl.html, or by writing to the Free
|
|
# Software Foundation, Inc., 59 Temple Place - Suite 330, Boston,
|
|
# MA 02111-1307, USA.
|
|
|
|
if test -z "$srcdir"; then
|
|
srcdir=`echo "$0" | sed 's%/[^/]*$%%'`
|
|
test "$srcdir" = "$0" && srcdir=.
|
|
fi
|
|
. $srcdir/defs || exit 1
|
|
|
|
# Check all the "portable" shell scripts.
|
|
status=$EXIT_SUCCESS
|
|
scripts="$srcdir/../config/ltmain.sh $srcdir/../libtoolize"
|
|
|
|
# Check for bad binary operators.
|
|
if $EGREP -n -e 'if[ ]+["'\'']?\\$[^ ]+[ ]+(=|-[lg][te]|-eq|-ne)' $scripts; then
|
|
echo "use \`if test \$something =' instead of \`if \$something ='"
|
|
status=$EXIT_FAILURE
|
|
fi
|
|
|
|
# Check for bad unary operators.
|
|
if $EGREP -n -e 'if[ ]+-' $scripts; then
|
|
echo "use \`if test -X' instead of \`if -X'"
|
|
status=$EXIT_FAILURE
|
|
fi
|
|
|
|
# Check for using `[' instead of `test'.
|
|
if $EGREP -n -e 'if[ ]+\[' $scripts; then
|
|
echo "use \`if test' instead of \`if ['"
|
|
status=$EXIT_FAILURE
|
|
fi
|
|
|
|
if $EGREP -n -e 'test[ ]+(![ ])?(-.[ ]+)?"?[.,_x]' $scripts; then
|
|
echo "use \`test \"X...\"' instead of \`test \"x...\"'"
|
|
status=$EXIT_FAILURE
|
|
fi
|
|
|
|
# Check for using test X... instead of test "X...
|
|
if $EGREP -n -e 'test[ ]+(![ ])?(-.[ ]+)?X' $scripts; then
|
|
echo "use \`test \"X...\"' instead of \`test X'"
|
|
status=$EXIT_FAILURE
|
|
fi
|
|
|
|
# Check for using test $... instead of test "$...
|
|
if $EGREP -n -e 'test[ ]+(![ ])?(-.[ ]+)?X?\$' $scripts; then
|
|
echo "use \`test \"\$...\"' instead of \`test \$'"
|
|
status=$EXIT_FAILURE
|
|
fi
|
|
|
|
# Never use test -e.
|
|
if $EGREP -n -e 'test[ ]+(![ ])?-e' $scripts; then
|
|
echo "use \`test -f' instead of \`test -e'"
|
|
status=$EXIT_FAILURE
|
|
fi
|
|
|
|
# Check for problems with variable assignments.
|
|
if $EGREP -n -e '[^ ]=[^ ].*(break|continue)' $scripts; then
|
|
echo "assignments on the same line as a \`break' or \`continue' may have no effect"
|
|
status=$EXIT_FAILURE
|
|
fi
|
|
|
|
# Check for uses of Xsed without corresponding echo "X
|
|
if $EGREP -n -e '\$Xsed' $scripts | $EGREP -v -n -e '\$echo \\*"X'; then
|
|
echo "occurrences of \`\$Xsed\' without \`echo \"X\' on the same line"
|
|
status=$EXIT_FAILURE
|
|
fi
|
|
|
|
# Check for quotes within backquotes within quotes "`"bar"`"
|
|
if $EGREP -n -e '"[^`"]*`[^"`]*"[^"`]*".*`[^`"]*"' $scripts | \
|
|
$EGREP -v "### testsuite: skip nested quoting test$"; then
|
|
echo "nested quotes are dangerous"
|
|
status=$EXIT_FAILURE
|
|
fi
|
|
|
|
exit $status
|