mirror of
git://git.savannah.gnu.org/libtool.git
synced 2024-12-27 07:09:26 +08:00
45ca0c8273
character in `test "X...'. Beef up the `test' tests to also check `test -.' and `test ! -.' phrases for compliance. * ltmain.in: Fix quoting problems uncovered by the new tests.
78 lines
2.1 KiB
Bash
Executable File
78 lines
2.1 KiB
Bash
Executable File
#! /bin/sh
|
|
# sh.test - check that we haven't forgotten a `test' command
|
|
|
|
# Test script header.
|
|
need_prefix=no
|
|
if test -z "$srcdir"; then
|
|
srcdir=`echo "$0" | sed 's%/[^/]*$%%'`
|
|
test "$srcdir" = "$0" && srcdir=.
|
|
test "${VERBOSE+set}" != "set" && VERBOSE=yes
|
|
fi
|
|
. $srcdir/defs || exit 1
|
|
|
|
# Check all the "portable" shell scripts.
|
|
status=0
|
|
scripts="$srcdir/../ltmain.sh"
|
|
|
|
# Check for bad binary operators.
|
|
if egrep -n -e "if[ ]+[\"']?\\$.*(=|-[lg][te]|-eq|-ne)" $scripts; then
|
|
echo "use \`if test \$something =' instead of \`if \$something ='"
|
|
status=1
|
|
fi
|
|
|
|
# Check for bad unary operators.
|
|
if egrep -n -e 'if[ ]+-' $scripts; then
|
|
echo "use \`if test -X' instead of \`if -X'"
|
|
status=1
|
|
fi
|
|
|
|
# Check for using `[' instead of `test'.
|
|
if egrep -n -e 'if[ ]+\[' $scripts; then
|
|
echo "use \`if test' instead of \`if ['"
|
|
status=1
|
|
fi
|
|
|
|
if egrep -n -e 'test[ ]+(![ ])?(-.[ ]+)?"?[.,_x]' $scripts; then
|
|
echo "use \`test \"X...\"' instead of \`test \"x...\"'"
|
|
status=1
|
|
fi
|
|
|
|
# Check for using test X... instead of test "X...
|
|
if egrep -n -e 'test[ ]+(![ ])?(-.[ ]+)?X' $scripts; then
|
|
echo "use \`test \"X...\"' instead of \`test X'"
|
|
status=1
|
|
fi
|
|
|
|
# Check for using test $... instead of test "$...
|
|
if egrep -n -e 'test[ ]+(![ ])?(-.[ ]+)?X?\$' $scripts; then
|
|
echo "use \`test \"\$...\"' instead of \`test \$'"
|
|
status=1
|
|
fi
|
|
|
|
# Never use test -e.
|
|
if egrep -n -e 'test[ ]+(![ ])?-e' $scripts; then
|
|
echo "use \`test -f' instead of \`test -e'"
|
|
status=1
|
|
fi
|
|
|
|
# Check for problems with variable assignments.
|
|
if egrep -n -e '[^ ]=[^ ].*(break|continue)' $scripts; then
|
|
echo "assignments on the same line as a \`break' or \`continue' may have no effect"
|
|
status=1
|
|
fi
|
|
|
|
# Check for uses of Xsed without corresponding echo "X
|
|
if egrep -n -e '\$Xsed' $scripts | egrep -v -n -e '\$echo \\*"X'; then
|
|
echo "occurrences of \`\$Xsed\' without \`echo \"X\' on the same line"
|
|
status=1
|
|
fi
|
|
|
|
# Check for quotes within backquotes within quotes "`"bar"`"
|
|
if egrep -n -e '"[^`"]*`[^"`]*"[^"`]*".*`[^`"]*"' $scripts | \
|
|
egrep -v "### testsuite: skip nested quoting test$"; then
|
|
echo "nested quotes are dangerous"
|
|
status=1
|
|
fi
|
|
|
|
exit $status
|