mirror/libtool
2
0
Fork 0
mirror of git://git.savannah.gnu.org/libtool.git synced 2024-11-27 06:09:57 +08:00
Code Issues Packages Projects Releases Wiki Activity

* tests/sh.test: Add a new test to enforce X as the fill

Browse Source 
character in `test "X...'.
Beef up the `test' tests to also check `test -.' and `test ! -.'
phrases for compliance.
* ltmain.in: Fix quoting problems uncovered by the new tests.
This commit is contained in:
Gary V. Vaughan 2001-07-29 16:35:50 +00:00
parent ed51dc446f
commit 45ca0c8273
3 changed files with 18 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ChangeLog
View File

@ -1,3 +1,11 @@
2001-07-29 Gary V. Vaughan <gary@gnu.org>
* tests/sh.test: Add a new test to enforce X as the fill
character in `test "X...'.
Beef up the `test' tests to also check `test -.' and `test ! -.'
phrases for compliance.
* ltmain.in: Fix quoting problems uncovered by the new tests.
2001-07-29 Andrew C. Feren <aferen@CetaceanNetworks.com>
* tests/sh.test: New test to disallow `test $foo', where

4
ltmain.in
View File

@ -681,7 +681,7 @@ compiler."
fi
# Just move the object if needed, then go on to compile the next one
if test -n "$output_obj" && test "x$output_obj" != "x$lobj"; then
if test -n "$output_obj" && test "X$output_obj" != "X$lobj"; then
$show "$mv $output_obj $lobj"
if $run $mv $output_obj $lobj; then :
else
@ -751,7 +751,7 @@ compiler."
fi
# Just move the object if needed
if test -n "$output_obj" && test "x$output_obj" != "x$obj"; then
if test -n "$output_obj" && test "X$output_obj" != "X$obj"; then
$show "$mv $output_obj $obj"
if $run $mv $output_obj $obj; then :
else

11
tests/sh.test
View File

@ -32,20 +32,25 @@ if egrep -n -e 'if[ ]+\[' $scripts; then
status=1
fi
if egrep -n -e 'test[ ]+(![ ])?(-.[ ]+)?"?[.,_x]' $scripts; then
echo "use \`test \"X...\"' instead of \`test \"x...\"'"
status=1
fi
# Check for using test X... instead of test "X...
if egrep -n -e 'test[ ]+X' $scripts; then
if egrep -n -e 'test[ ]+(![ ])?(-.[ ]+)?X' $scripts; then
echo "use \`test \"X...\"' instead of \`test X'"
status=1
fi
# Check for using test $... instead of test "$...
if egrep -n -e 'test[ ]+(-.[ ]+)?X?\$' $scripts; then
if egrep -n -e 'test[ ]+(![ ])?(-.[ ]+)?X?\$' $scripts; then
echo "use \`test \"\$...\"' instead of \`test \$'"
status=1
fi
# Never use test -e.
if egrep -n -e 'test[ ]+-e' $scripts; then
if egrep -n -e 'test[ ]+(![ ])?-e' $scripts; then
echo "use \`test -f' instead of \`test -e'"
status=1
fi