mirror of
https://github.com/HDFGroup/hdf5.git
synced 2024-11-27 02:10:55 +08:00
7bbea13711
Bug fix Description: ph5diff had been hanging in Tflops. Found out that vsnprintf ph5diff uses was a local coded that did not limit printing according to the size argument. That resulted in buffer overflow and other problems. Solution: Added some sort of size checking in the home-grown vsnprintf and had ph5diff checked for error return of vsnprintf. Leon also revamped the ph5diff manager's way of handling communications with the workers. That eliminated all but the last case of hanging. Platforms tested: Tflops. Misc. update:
64 lines
2.0 KiB
C
64 lines
2.0 KiB
C
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
|
|
* Copyright by the Board of Trustees of the University of Illinois. *
|
|
* All rights reserved. *
|
|
* *
|
|
* This file is part of HDF5. The full HDF5 copyright notice, including *
|
|
* terms governing use, modification, and redistribution, is contained in *
|
|
* the files COPYING and Copyright.html. COPYING can be found at the root *
|
|
* of the source code distribution tree; Copyright.html can be found at the *
|
|
* root level of an installed copy of the electronic HDF5 document set and *
|
|
* is linked from the top-level documents page. It can also be found at *
|
|
* http://hdf.ncsa.uiuc.edu/HDF5/doc/Copyright.html. If you do not have *
|
|
* access to either file, you may request a copy from hdfhelp@ncsa.uiuc.edu. *
|
|
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
|
|
|
|
#ifndef _PH5DIFF_H__
|
|
#define _PH5DIFF_H__
|
|
|
|
/* use a larger output buffer for Tflops which does not support vsnprintf. */
|
|
#ifdef __PUMAGON__
|
|
#define PRINT_DATA_MAX_SIZE 512
|
|
#else
|
|
#define PRINT_DATA_MAX_SIZE 512
|
|
#endif
|
|
#define OUTBUFF_SIZE (PRINT_DATA_MAX_SIZE*4)
|
|
/* Send from manager to workers */
|
|
#define MPI_TAG_ARGS 1
|
|
#define MPI_TAG_PRINT_TOK 2
|
|
|
|
/*Sent from workers to manager */
|
|
#define MPI_TAG_TOK_REQUEST 3
|
|
#define MPI_TAG_DONE 4
|
|
#define MPI_TAG_TOK_RETURN 5
|
|
#define MPI_TAG_PRINT_DATA 6
|
|
|
|
/* Operational tags used to init and complete diff */
|
|
#define MPI_TAG_END 7
|
|
#define MPI_TAG_PARALLEL 8
|
|
|
|
extern int g_nTasks;
|
|
extern unsigned char g_Parallel;
|
|
extern char outBuff[];
|
|
extern int outBuffOffset;
|
|
extern FILE* overflow_file;
|
|
|
|
struct diff_args
|
|
{
|
|
char name[256];
|
|
H5G_obj_t type;
|
|
diff_opt_t options;
|
|
};
|
|
|
|
struct diffs_found
|
|
{
|
|
hsize_t nfound;
|
|
int not_cmp;
|
|
};
|
|
|
|
#ifdef H5_HAVE_PARALLEL
|
|
#include <mpi.h>
|
|
#endif
|
|
|
|
|
|
#endif /* _PH5DIFF_H__ */
|