mirror of
https://github.com/HDFGroup/hdf5.git
synced 2025-02-23 16:20:57 +08:00
a50d211755
* Brings hash table ID code over from Bitbucket branch
* Includes reformatting via clang.
* Excludes uthash.h from reformatting.
* Still has the failing test issue in tid.c. This should only be a
problem if a custom ID type is used and its free function deletes
other IDs.
* Fixes munged H5_GCC_DIAG_ON/OFF macros in H5I.c
The H5_GCC_DIAG_ON/OFF macros used to turn off fallthrough warnings
in uthash.h (external code) were munged when formatting with clang
due to their lack of quotes.
e.g.;
H5_GCC_DIAG_OFF(implicit-fallthrough)
was munged to:
H5_GCC_DIAG_OFF(implicit - fallthrough)
which compiles, but is useless. So, with quotes, this is now:
H5_GCC_DIAG_OFF("implicit-fallthrough")
which survives reformatting with clang.
* Fixes issues with user callbacks in the ID hash tables
The skip lists (previously) used to handle IDs use a mark-and-sweep
scheme to deal with user-defined ID delete callbacks which themselves delete
other IDs in the list. The uthash hash table implementation used to manage
the IDs in this feature branch does not have this ability.
This commit restores the skip lists for non-library ID types in lieu of
significantly modifying the uthash code. The hash tables are used to
manage the library IDs as those do not delete other IDs when they are
closed.
* Adds uthash.h to MANIFEST
* Removes implicit-fallthrough diagnostic disable
Removing -Wimplicit-fallthrough=5 means that the uthash code
no longer raises warnings so the H5_GCC_DIAG_OFF/ON macros
that disabled those warnings have been removed from H5I.c.
* Adds a test to ensure you can delete IDs in the H5Iiterate() callback
18 lines
693 B
YAML
18 lines
693 B
YAML
name: clang-format Check
|
|
on: [workflow_dispatch, push, pull_request]
|
|
jobs:
|
|
formatting-check:
|
|
name: Formatting Check
|
|
runs-on: ubuntu-latest
|
|
if: "!contains(github.event.head_commit.message, 'skip-ci')"
|
|
steps:
|
|
- uses: actions/checkout@v2
|
|
- name: Run clang-format style check for C programs.
|
|
uses: DoozyX/clang-format-lint-action@v0.10
|
|
with:
|
|
source: '.'
|
|
extensions: 'c,h,cpp,hpp'
|
|
clangFormatVersion: 10
|
|
style: file
|
|
exclude: './config ./hl/src/H5LTanalyze.c ./hl/src/H5LTparse.c ./hl/src/H5LTparse.h ./src/H5Epubgen.h ./src/H5Einit.h ./src/H5Eterm.h ./src/H5Edefin.h ./src/H5version.h ./src/H5overflow.h ./src/uthash.h'
|