hdf5/config/clang-warnings
David Young 174f4275ba
To reduce maintenance effort, delete the noerror- variants of the compiler flags files (#1033)
* Avoid maintenance headaches: delete the `noerror-` variants of the
compiler flags files, since they essentially duplicate the `error-`
files modulo the replacement of `-Werror=` with `-W` and any changes in
comments.  (I verified the duplication with a script.)

For autoconf, reinstate the use of the `demote_errors` shell function to
derive the `noerror-` content from the `error-` content.  `demote_errors`
replaces `-Werror=` with `-W` when `WARNINGS_AS_ERRORS` is `no`.

Slightly reorder `configure.ac` so that the setting of
`WARNINGS_AS_ERRORS` takes effect before the `error-` files are sourced.

* Take a stab at updating the CMake files to match the changes I made to
the autoconf files to remove `noerror-` files.  I'm not much of a CMake
user so these changes are quite rough.

Looks like the duplication can be reduced with the introduction of a new
macro.

* Delete `noerror-` files from the MANIFEST.

* Reduce duplication in the CMake files: perform the
HDF5_ENABLE_WARNINGS_AS_ERRORS test once in the ADD_H5_FLAGS macro.

* Add a release note.
2021-10-06 16:24:22 -05:00
..
developer-general Make changes to CMake CompilerFlags.cmake files so extra flags are 2020-06-10 14:25:10 -05:00
error-general Make changes to CMake CompilerFlags.cmake files so extra flags are 2020-06-10 14:25:10 -05:00
general TRILAB-192 add comparable clang flags 2020-03-27 17:10:53 -05:00
no-developer-general Add files for adding warning flags for clang compilers in autotools 2020-06-02 15:53:58 -05:00