mirror of
https://github.com/HDFGroup/hdf5.git
synced 2024-11-21 01:04:10 +08:00
535172c8fb
Bug Fix
Description:
A resource leak happened if the H5Fget_access_plist() function was
called. What was happening: the driver ID and info parts of the
property list copied in H5Fget_access_plist were being overwritten,
but those properties were copied initially, so we lost information.
Added calls to the H5Fget_access_plist function to get the PList and
then immediately close it. It would cause an infinite loop if there
is a resource leak.
Solution:
Before copying over those values, call the H5F_acs_close() function
to close those values.
Platforms tested:
Modi4 (Parallel & Fortran)
Arabica (Fortran)
Verbena (Fortran & C++)
Misc. update:
434 lines
12 KiB
C
434 lines
12 KiB
C
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
|
||
* Copyright by the Board of Trustees of the University of Illinois. *
|
||
* All rights reserved. *
|
||
* *
|
||
* This file is part of HDF5. The full HDF5 copyright notice, including *
|
||
* terms governing use, modification, and redistribution, is contained in *
|
||
* the files COPYING and Copyright.html. COPYING can be found at the root *
|
||
* of the source code distribution tree; Copyright.html can be found at the *
|
||
* root level of an installed copy of the electronic HDF5 document set and *
|
||
* is linked from the top-level documents page. It can also be found at *
|
||
* http://hdf.ncsa.uiuc.edu/HDF5/doc/Copyright.html. If you do not have *
|
||
* access to either file, you may request a copy from hdfhelp@ncsa.uiuc.edu. *
|
||
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
|
||
|
||
/*
|
||
* Programmer: Raymond Lu<slu@ncsa.uiuc.edu>
|
||
* Tuesday, Sept 24, 2002
|
||
*
|
||
* Purpose: Tests the file handle interface
|
||
*/
|
||
|
||
#include "h5test.h"
|
||
|
||
#define FAMILY_NUMBER 4
|
||
#define FAMILY_SIZE 128
|
||
#define MULTI_SIZE 128
|
||
#define CORE_INCREMENT 4096
|
||
|
||
const char *FILENAME[] = {
|
||
"sec2_file",
|
||
"core_file",
|
||
"family_file",
|
||
"multi_file",
|
||
NULL
|
||
};
|
||
|
||
|
||
/*-------------------------------------------------------------------------
|
||
* Function: test_sec2
|
||
*
|
||
* Purpose: Tests the file handle interface for SEC2 driver
|
||
*
|
||
* Return: Success: exit(0)
|
||
*
|
||
* Failure: exit(1)
|
||
*
|
||
* Programmer: Raymond Lu
|
||
* Tuesday, Sept 24, 2002
|
||
*
|
||
* Modifications:
|
||
*
|
||
*-------------------------------------------------------------------------
|
||
*/
|
||
static herr_t
|
||
test_sec2(void)
|
||
{
|
||
hid_t file=(-1), fapl, access_fapl = -1;
|
||
char filename[1024];
|
||
int *fhandle=NULL;
|
||
|
||
TESTING("SEC2 file driver");
|
||
|
||
/* Set property list and file name for SEC2 driver. */
|
||
fapl = h5_fileaccess();
|
||
if(H5Pset_fapl_sec2(fapl)<0)
|
||
goto error;
|
||
h5_fixname(FILENAME[0], fapl, filename, sizeof filename);
|
||
|
||
if((file=H5Fcreate(filename, H5F_ACC_TRUNC, H5P_DEFAULT, fapl))<0)
|
||
goto error;
|
||
|
||
/* Retrieve the access property list... */
|
||
if ((access_fapl = H5Fget_access_plist(file)) < 0)
|
||
goto error;
|
||
|
||
/* ...and close the property list */
|
||
if (H5Pclose(access_fapl) < 0)
|
||
goto error;
|
||
|
||
/* Check file handle API */
|
||
if(H5Fget_vfd_handle(file, H5P_DEFAULT, (void **)&fhandle)<0)
|
||
goto error;
|
||
if(*fhandle<0)
|
||
goto error;
|
||
|
||
if(H5Fclose(file)<0)
|
||
goto error;
|
||
h5_cleanup(FILENAME, fapl);
|
||
PASSED();
|
||
return 0;
|
||
|
||
error:
|
||
H5E_BEGIN_TRY {
|
||
H5Pclose (fapl);
|
||
H5Fclose(file);
|
||
} H5E_END_TRY;
|
||
return -1;
|
||
}
|
||
|
||
|
||
/*-------------------------------------------------------------------------
|
||
* Function: test_core
|
||
*
|
||
* Purpose: Tests the file handle interface for CORE driver
|
||
*
|
||
* Return: Success: exit(0)
|
||
*
|
||
* Failure: exit(1)
|
||
*
|
||
* Programmer: Raymond Lu
|
||
* Tuesday, Sept 24, 2002
|
||
*
|
||
* Modifications:
|
||
*
|
||
*-------------------------------------------------------------------------
|
||
*/
|
||
static herr_t
|
||
test_core(void)
|
||
{
|
||
hid_t file=(-1), fapl, access_fapl = -1;
|
||
char filename[1024];
|
||
void *fhandle=NULL;
|
||
|
||
TESTING("CORE file driver");
|
||
|
||
/* Set property list and file name for CORE driver */
|
||
fapl = h5_fileaccess();
|
||
if(H5Pset_fapl_core(fapl, CORE_INCREMENT, TRUE)<0)
|
||
goto error;
|
||
h5_fixname(FILENAME[1], fapl, filename, sizeof filename);
|
||
|
||
if((file=H5Fcreate(filename, H5F_ACC_TRUNC, H5P_DEFAULT, fapl))<0)
|
||
goto error;
|
||
|
||
/* Retrieve the access property list... */
|
||
if ((access_fapl = H5Fget_access_plist(file)) < 0)
|
||
goto error;
|
||
|
||
/* ...and close the property list */
|
||
if (H5Pclose(access_fapl) < 0)
|
||
goto error;
|
||
|
||
if(H5Fget_vfd_handle(file, H5P_DEFAULT, &fhandle)<0)
|
||
goto error;
|
||
if(fhandle==NULL)
|
||
{
|
||
printf("fhandle==NULL\n");
|
||
goto error;
|
||
}
|
||
|
||
if(H5Fclose(file)<0)
|
||
goto error;
|
||
h5_cleanup(FILENAME, fapl);
|
||
PASSED();
|
||
return 0;
|
||
|
||
error:
|
||
H5E_BEGIN_TRY {
|
||
H5Pclose (fapl);
|
||
H5Fclose(file);
|
||
} H5E_END_TRY;
|
||
return -1;
|
||
}
|
||
|
||
|
||
/*-------------------------------------------------------------------------
|
||
* Function: test_family
|
||
*
|
||
* Purpose: Tests the file handle interface for FAMILY driver
|
||
*
|
||
* Return: Success: exit(0)
|
||
*
|
||
* Failure: exit(1)
|
||
*
|
||
* Programmer: Raymond Lu
|
||
* Tuesday, Sept 24, 2002
|
||
*
|
||
* Modifications:
|
||
*
|
||
*-------------------------------------------------------------------------
|
||
*/
|
||
static herr_t
|
||
test_family(void)
|
||
{
|
||
hid_t file=(-1), fapl, fapl2=(-1), space=(-1), dset=(-1);
|
||
hid_t access_fapl = -1;
|
||
char filename[1024];
|
||
char dname[]="dataset";
|
||
int i, j;
|
||
int *fhandle=NULL, *fhandle2=NULL;
|
||
int buf[FAMILY_NUMBER][FAMILY_SIZE];
|
||
hsize_t dims[2]={FAMILY_NUMBER, FAMILY_SIZE};
|
||
|
||
TESTING("FAMILY file driver");
|
||
|
||
/* Set property list and file name for FAMILY driver */
|
||
fapl = h5_fileaccess();
|
||
if(H5Pset_fapl_family(fapl, (hsize_t)FAMILY_SIZE, H5P_DEFAULT)<0)
|
||
goto error;
|
||
h5_fixname(FILENAME[2], fapl, filename, sizeof filename);
|
||
|
||
if((file=H5Fcreate(filename, H5F_ACC_TRUNC, H5P_DEFAULT, fapl))<0)
|
||
goto error;
|
||
|
||
/* Create and write dataset */
|
||
if((space=H5Screate_simple(2, dims, NULL))<0)
|
||
goto error;
|
||
|
||
/* Retrieve the access property list... */
|
||
if ((access_fapl = H5Fget_access_plist(file)) < 0)
|
||
goto error;
|
||
|
||
/* ...and close the property list */
|
||
if (H5Pclose(access_fapl) < 0)
|
||
goto error;
|
||
|
||
if((dset=H5Dcreate(file, dname, H5T_NATIVE_INT, space, H5P_DEFAULT))<0)
|
||
goto error;
|
||
|
||
for(i=0; i<FAMILY_NUMBER; i++)
|
||
for(j=0; j<FAMILY_SIZE; j++)
|
||
buf[i][j] = i*10000+j;
|
||
if(H5Dwrite(dset, H5T_NATIVE_INT, H5S_ALL, H5S_ALL, H5P_DEFAULT, buf)<0)
|
||
goto error;
|
||
|
||
/* check file handle API */
|
||
if((fapl2=H5Pcreate(H5P_FILE_ACCESS))<0)
|
||
goto error;
|
||
if(H5Pset_family_offset(fapl2, (hsize_t)0)<0)
|
||
goto error;
|
||
|
||
if(H5Fget_vfd_handle(file, fapl2, (void **)&fhandle)<0)
|
||
goto error;
|
||
if(*fhandle<0)
|
||
goto error;
|
||
|
||
if(H5Pset_family_offset(fapl2, (hsize_t)(FAMILY_SIZE*2))<0)
|
||
goto error;
|
||
if(H5Fget_vfd_handle(file, fapl2, (void **)&fhandle2)<0)
|
||
goto error;
|
||
if(*fhandle2<0)
|
||
goto error;
|
||
|
||
if(H5Sclose(space)<0)
|
||
goto error;
|
||
if(H5Dclose(dset)<0)
|
||
goto error;
|
||
if(H5Pclose(fapl2)<0)
|
||
goto error;
|
||
if(H5Fclose(file)<0)
|
||
goto error;
|
||
h5_cleanup(FILENAME, fapl);
|
||
PASSED();
|
||
return 0;
|
||
|
||
error:
|
||
H5E_BEGIN_TRY {
|
||
H5Sclose(space);
|
||
H5Dclose(dset);
|
||
H5Pclose (fapl2);
|
||
H5Pclose (fapl2);
|
||
H5Fclose(file);
|
||
} H5E_END_TRY;
|
||
return -1;
|
||
}
|
||
|
||
|
||
/*-------------------------------------------------------------------------
|
||
* Function: test_multi
|
||
*
|
||
* Purpose: Tests the file handle interface for MUTLI driver
|
||
*
|
||
* Return: Success: exit(0)
|
||
*
|
||
* Failure: exit(1)
|
||
*
|
||
* Programmer: Raymond Lu
|
||
* Tuesday, Sept 24, 2002
|
||
*
|
||
* Modifications:
|
||
*
|
||
*-------------------------------------------------------------------------
|
||
*/
|
||
static herr_t
|
||
test_multi(void)
|
||
{
|
||
hid_t file=(-1), fapl, fapl2=(-1), dset=(-1), space=(-1);
|
||
hid_t access_fapl = -1;
|
||
char filename[1024];
|
||
int *fhandle2=NULL, *fhandle=NULL;
|
||
H5FD_mem_t mt, memb_map[H5FD_MEM_NTYPES];
|
||
hid_t memb_fapl[H5FD_MEM_NTYPES];
|
||
haddr_t memb_addr[H5FD_MEM_NTYPES];
|
||
const char *memb_name[H5FD_MEM_NTYPES];
|
||
char sv[H5FD_MEM_NTYPES][32];
|
||
hsize_t dims[2]={MULTI_SIZE, MULTI_SIZE};
|
||
char dname[]="dataset";
|
||
int i, j;
|
||
int buf[MULTI_SIZE][MULTI_SIZE];
|
||
|
||
TESTING("MULTI file driver");
|
||
/* Set file access property list for MULTI driver */
|
||
fapl = h5_fileaccess();
|
||
|
||
HDmemset(memb_map, 0, sizeof memb_map);
|
||
HDmemset(memb_fapl, 0, sizeof memb_fapl);
|
||
HDmemset(memb_name, 0, sizeof memb_name);
|
||
HDmemset(memb_addr, 0, sizeof memb_addr);
|
||
HDmemset(sv, 0, sizeof sv);
|
||
|
||
for(mt=H5FD_MEM_DEFAULT; mt<H5FD_MEM_NTYPES; H5_INC_ENUM(H5FD_mem_t,mt))
|
||
memb_map[mt] = H5FD_MEM_SUPER;
|
||
memb_map[H5FD_MEM_DRAW] = H5FD_MEM_DRAW;
|
||
|
||
memb_fapl[H5FD_MEM_SUPER] = H5P_DEFAULT;
|
||
sprintf(sv[H5FD_MEM_SUPER], "%%s-%c.h5", 's');
|
||
memb_name[H5FD_MEM_SUPER] = sv[H5FD_MEM_SUPER];
|
||
memb_addr[H5FD_MEM_SUPER] = 0;
|
||
|
||
memb_fapl[H5FD_MEM_DRAW] = H5P_DEFAULT;
|
||
sprintf(sv[H5FD_MEM_DRAW], "%%s-%c.h5", 'r');
|
||
memb_name[H5FD_MEM_DRAW] = sv[H5FD_MEM_DRAW];
|
||
memb_addr[H5FD_MEM_DRAW] = HADDR_MAX/2;
|
||
|
||
if(H5Pset_fapl_multi(fapl, memb_map, memb_fapl, memb_name, memb_addr, TRUE)<0)
|
||
goto error;
|
||
h5_fixname(FILENAME[3], fapl, filename, sizeof filename);
|
||
|
||
if((file=H5Fcreate(filename, H5F_ACC_TRUNC, H5P_DEFAULT, fapl))<0)
|
||
goto error;
|
||
|
||
/* Create and write data set */
|
||
if((space=H5Screate_simple(2, dims, NULL))<0)
|
||
goto error;
|
||
|
||
/* Retrieve the access property list... */
|
||
if ((access_fapl = H5Fget_access_plist(file)) < 0)
|
||
goto error;
|
||
|
||
/* ...and close the property list */
|
||
if (H5Pclose(access_fapl) < 0)
|
||
goto error;
|
||
|
||
if((dset=H5Dcreate(file, dname, H5T_NATIVE_INT, space, H5P_DEFAULT))<0)
|
||
goto error;
|
||
|
||
for(i=0; i<MULTI_SIZE; i++)
|
||
for(j=0; j<MULTI_SIZE; j++)
|
||
buf[i][j] = i*10000+j;
|
||
if(H5Dwrite(dset, H5T_NATIVE_INT, H5S_ALL, H5S_ALL, H5P_DEFAULT, buf)<0)
|
||
goto error;
|
||
|
||
if((fapl2=H5Pcreate(H5P_FILE_ACCESS))<0)
|
||
goto error;
|
||
if(H5Pset_multi_type(fapl2, H5FD_MEM_SUPER)<0)
|
||
goto error;
|
||
if(H5Fget_vfd_handle(file, fapl2, (void **)&fhandle)<0)
|
||
goto error;
|
||
if(*fhandle<0)
|
||
goto error;
|
||
|
||
if(H5Pset_multi_type(fapl2, H5FD_MEM_DRAW)<0)
|
||
goto error;
|
||
if(H5Fget_vfd_handle(file, fapl2, (void **)&fhandle2)<0)
|
||
goto error;
|
||
if(*fhandle2<0)
|
||
goto error;
|
||
|
||
if(H5Sclose(space)<0)
|
||
goto error;
|
||
if(H5Dclose(dset)<0)
|
||
goto error;
|
||
if(H5Pclose(fapl2)<0)
|
||
goto error;
|
||
if(H5Fclose(file)<0)
|
||
goto error;
|
||
|
||
h5_cleanup(FILENAME, fapl);
|
||
PASSED();
|
||
|
||
return 0;
|
||
|
||
error:
|
||
H5E_BEGIN_TRY {
|
||
H5Sclose(space);
|
||
H5Dclose(dset);
|
||
H5Pclose(fapl);
|
||
H5Pclose(fapl2);
|
||
H5Fclose(file);
|
||
} H5E_END_TRY;
|
||
return -1;
|
||
}
|
||
|
||
|
||
/*-------------------------------------------------------------------------
|
||
* Function: main
|
||
*
|
||
* Purpose: Tests the file handle interface(H5Fget_vfd_handle and
|
||
* H5FDget_vfd_handle)
|
||
*
|
||
* Return: Success: exit(0)
|
||
*
|
||
* Failure: exit(1)
|
||
*
|
||
* Programmer: Raymond Lu
|
||
* Tuesday, Sept 24, 2002
|
||
*
|
||
* Modifications:
|
||
*
|
||
*-------------------------------------------------------------------------
|
||
*/
|
||
int
|
||
main(void)
|
||
{
|
||
int nerrors=0;
|
||
|
||
h5_reset();
|
||
|
||
nerrors += test_sec2()<0 ?1:0;
|
||
nerrors += test_core()<0 ?1:0;
|
||
nerrors += test_family()<0 ?1:0;
|
||
nerrors += test_multi()<0 ?1:0;
|
||
|
||
if (nerrors) goto error;
|
||
printf("All file handle tests passed.\n");
|
||
return 0;
|
||
|
||
error:
|
||
nerrors = MAX(1, nerrors);
|
||
printf("***** %d FILE HANDLE TEST%s FAILED! *****\n",
|
||
nerrors, 1 == nerrors ? "" : "S");
|
||
return 1;
|
||
}
|