mirror of
https://github.com/HDFGroup/hdf5.git
synced 2025-02-11 16:01:00 +08:00
8ed20b39d6
Checked in fix for failure in shape same tests that appeared after Quincy's recent massage of the test code. The problem was a race condition created when Quincey re-worked the code selecting either collective or independant I/O. Previously, when independant I/O was selected in the test, I had used H5Pset_dxpl_mpio() and H5Pset_dxpl_mpio_collective_opt() to select collective semantics with independant I/O going on under the hood. Quincey modified this to call H5Pset_dxpl_mpio() when collective I/O was selected, and do nothing in the independant I/O case. As a result, processes were able to race ahead and modify the initial values of the data set before some processes had verified that the initialization was correct. Solved the problem by adding barriers, and making all barriers dependant on independant I/O being selected. Tested parallel on amani and phoenix. h5committested. Note that parallel on amani and h5committest on heiwa failed several times before I got a clean pass without code changes. The failures on amani seemed to be time outs caused by contention for the machine -- worryingly, they occurred in the shape same tests. However, given subsequent passes and passes on jam and phoenix, I am going ahead with the commit. The failure on heiwa was in the fheap test. I don't see how this can be related to changes in testpar, and in any case, it went away on the second try. |
||
|---|---|---|
| .. | ||
| CMakeLists.txt | ||
| COPYING | ||
| Makefile.am | ||
| Makefile.in | ||
| t_cache.c | ||
| t_chunk_alloc.c | ||
| t_coll_chunk.c | ||
| t_dset.c | ||
| t_file.c | ||
| t_filter_read.c | ||
| t_mdset.c | ||
| t_mpi.c | ||
| t_pflush1.c | ||
| t_pflush2.c | ||
| t_ph5basic.c | ||
| t_posix_compliant.c | ||
| t_rank_projection.c | ||
| t_span_tree.c | ||
| testpar.h | ||
| testph5.sh.in | ||
| testphdf5.c | ||
| testphdf5.h | ||