Commit Graph

224 Commits

Author SHA1 Message Date
Dana Robinson
e962df1591 VOL FEATURE 2018-10-10 08:10:15 -07:00
Dana Robinson
eb78fd8832 Develop normalization with vol_integration.
Mostly peripheral things like the tools and wrappers,
with just enough core library code to support that.
2018-09-18 22:57:37 -07:00
Vailin Choi
b178d80be0 Changes made based on feedback from pull request #1039. 2018-05-14 12:26:48 -05:00
Vailin Choi
e6bc326ec0 Fix for HDFFV-10180 Performance issues with H5Oget_info. 2018-04-24 15:10:13 -05:00
Quincey Koziol
4a17aff408 Add API context interface and use it throughout the library. 2018-03-15 16:54:30 -05:00
Dana Robinson
734aebc395 Rework of the POSIX file open permissions and macros to clean up
HDopen() calls.

Also fixed a minor const warning in the core VFD.
2017-04-28 18:13:22 -04:00
Larry Knox
89fbe00dec Merge pull request #426 in HDFFV/hdf5 from ~LRKNOX/hdf5_lrk:hdf5_1_10 to hdf5_1_10
* commit '54957d37f5aa73912763dbb6e308555e863c43f4':
  Commit copyright header change for src/H5PLpkg.c which was added after running script to make changes.
  Add new files in release_docs to MANIFEST. Cimmit changes to Makefile.in(s) and H5PL.c that resulted from running autogen.sh.
  Merge pull request #407 in HDFFV/hdf5 from ~LRKNOX/hdf5_lrk:hdf5_1_10_1 to hdf5_1_10_1
  Change copyright headers to replace url referring to file to be removed and replace it with new url for COPYING file.
2017-04-25 16:05:36 -05:00
Quincey Koziol
0313cbb91d Final merge of page buffering branch to develop 2017-03-13 21:30:37 -07:00
Quincey Koziol
5df52404bc Misc. small cleanups to sync against incoming page buffering changes. 2017-03-02 06:24:46 -08:00
Quincey Koziol
cf93261099 Correct issues from pull request reviews. 2017-02-28 08:41:57 -08:00
Quincey Koziol
5db402afbb Corrected version of 4b5e05c084:
Fix some more signed -> unsigned value issues with cache data structures,
    also misc. style cleanups.  All to align w/incoming page_buffering changes.
2017-02-27 21:45:55 -08:00
Quincey Koziol
e5fb4191de Revert "Fix some more signed -> unsigned value issues with cache data structures, also"
This reverts commit 4b5e05c084.
2017-02-27 21:23:44 -08:00
Quincey Koziol
4b5e05c084 Fix some more signed -> unsigned value issues with cache data structures, also
misc. style cleanups.  All to align w/incoming page_buffering changes.
2017-02-22 23:21:41 -08:00
Quincey Koziol
101fa7af8e Cleanups and normalizations against incoming page_buffering changes. 2017-02-19 18:28:52 -08:00
Quincey Koziol
f8cfbee05e Merge SWMR-related testing to existing tests. 2016-12-18 02:19:26 -08:00
Frank.Willmore
526bcc242d Changes to be committed:
modified:   bittests.c
	modified:   cmpd_dset.c
	modified:   dsets.c
	modified:   dt_arith.c
	modified:   dtypes.c
	modified:   extend.c
	modified:   fillval.c
	modified:   filter_fail.c
	modified:   flush1.c
	modified:   gen_cross.c
	modified:   hyperslab.c
	modified:   istore.c
	modified:   links.c
	modified:   links_env.c
	modified:   objcopy.c
	modified:   plugin.c
	modified:   tcheck_version.c
	modified:   unlink.c
	modified:   unregister.c

Minor fixes to replace numeric exit codes with MACRO declarations. Not all codes found were boolean, and those cases were not changed.
2016-10-25 09:53:44 -05:00
Quincey Koziol
bb19817c9f [svn-r30189] Description:
Clean up more warnings: drop the warning count from ~1310 down to ~940,
with only 31 types of warnings in 148 files (down from 38 types in 167 files).

Tested on:
    MacOSX/64 10.11.5 (amazon) w/serial & parallel
    (h5committest forthcoming)
2016-07-17 19:18:42 -05:00
Vailin Choi
88476380be [svn-r30151] Fix daily test failures for checkin #30143 for HDFFV-9940.
Tested on osx1010test, moohan, emu, kituo.
2016-07-06 18:08:42 -05:00
Vailin Choi
af0829aa17 [svn-r30143] Fix for HDFFV-9940.
Tested on jam, osx1010test, moohan, platypus, emu, kite, kituo, mayll, ostrich, quail.
2016-07-03 23:06:34 -05:00
Dana Robinson
e9139733f2 [svn-r29035] Removed external links test from external storage test.
This test is duplicated more comprehensively in the links.c file so
there is no need to copy it over.

Tested on: 64-bit Ubuntu 15.10 (Linux 4.2.0 x86_64) gcc 5.2.1
           serial autotools
2016-02-02 09:36:28 -05:00
Quincey Koziol
f60170dac7 [svn-r28761] Description:
Clean up many mismatches between malloc/free and H5MM_malloc/H5MM_xfree
in the library and tests (and use of H5free_memory and H5Dvlen_reclaim).  Also
make H5Ocopy use a private version of H5Lexists, which doesn't internally
throw (and suppress) errors when an object (or the path to it) isn't found in
the destination.

Tested on:
    MacOSX/64 10.11.2 (amazon) w/serial & parallel
    (h5committest forthcoming)
2016-01-01 01:28:04 -05:00
Dana Robinson
0a00732c4d [svn-r28696] Minor normalization with revise_chunks.
Tested on: 64-bit Ubuntu 15.10 (Linux 4.2.0 x86_64) gcc 5.2.1
           serial only
2015-12-17 01:31:27 -05:00
Jerome Soumagne
2094d86461 [svn-r28138] Add first support for _Bool and make hbool_t a "real" _Bool if available
Fix tests accordingly and fix misuse of hbool_t in various places

Fix initialization of H5Pgcpl/ocpl structs in property decoding routines

Tested on:
    Linux/32 (jam)
    Linux/64 (platypus)
    Linux/PPC64 (ostrich)
    MacOSX/64 10.11
2015-10-20 01:28:17 -05:00
Quincey Koziol
8fc9a9ba25 [svn-r27834] Description:
Close FAPL for external link test, to fix infinite loop closing the library.

Tested on:
    MacOSX/64 10.10.5 (amazon) w/serial 
    (too minor to require h5committest)
2015-09-20 21:08:56 -05:00
Quincey Koziol
ee7612be44 [svn-r27811] Description:
Refactor property list code to "deep copy" properties in the correct way,
retraining the rest of the library to copy & release things correctly.  This
cleans up another batch of memory leaks, etc. within the library.

Tested on:
    MacOSX/64 10.10.5 (amazon) w/serial & parallel
    Linux/32 2.6.x (jam) w/serial & parallel
    (h5committest forthcoming)
2015-09-16 17:27:49 -05:00
Quincey Koziol
1023374492 [svn-r27768] Description:
Complete revamp of package initialization/shutdown mechanism in the library.
Each package now has a single init/term routine.

    This new way should avoid packages being re-initialized during library
shutdown and is also be _much_ more proactive about giving feedback for
resource leaks internal to the library.

    Introduces a new "module" header file for packages in the library
(e.g src/H5Fmodule.h) which sets up some necessary package configuration macros
for the FUNC_ENTER/LEAVE macros.  (The VFL drivers have their own slightly
modified version of this header, src/H5FDdrvr_module.h)

    Also cleaned up a bunch of resources leaks all across the library and tests,
along with addressing many warnings, as I encountered them.

Tested on:
    MacOSX/64 10.10.5 (amazon) w/serial & parallel
    Linux/64 3.10.x (kituo) w/serial & parallel
    Linux/64 2.6.x (ostrich) w/serial
2015-09-13 22:58:59 -05:00
Dana Robinson
2e6100fb23 [svn-r27572] Removed VMS-specific code from the library.
The only remaining code consists of a few floating-point tests
that rely on pre-generated and checked-in VMS files. These have
been left alone, even though they will not be possible to
recreate, since testing VMS float behavior is still important.

Tested on: h5committest
2015-08-24 15:19:39 -05:00
Jerome Soumagne
ab7d724ffd [svn-r27548] Revert r27545 2015-08-21 17:44:22 -05:00
Jerome Soumagne
7ce2d52cf6 [svn-r27545] Add first support for _Bool and make hbool_t a "real" _Bool if available
Fix tests accordingly
2015-08-21 13:52:30 -05:00
Mohamad Chaarawi
fc45d5fcb0 [svn-r27133] - Add a new attribute function characterstic for format:
* H5_ATTR_FORMAT(X,Y,Z)  __attribute__((format(X, Y, Z)))
- Rename UNUSED attribute characterstic to H5_ATTR_UNUSED.
- Rename NORETURN attribute characterstic to H5_ATTR_NORETURN

tested with h5committest.
2015-06-01 14:38:09 -05:00
Dana Robinson
bfa5786184 [svn-r26986] Removed H5F_ACC_DEBUG and H5FD_DEBUG functionality.
The H5F_ACC_DEBUG symbol remains but has been defined to zero and
has been listed as deprecated.

Fixes: HDFFV-1074

Tested on:
    h5committest
    32-bit Linux w/ C++ and Fortran and multi VFD
    32-bit Linux w/ C++ and Fortran and multi VFD (no deprec symbols)
2015-04-30 14:32:25 -05:00
Dana Robinson
d8e3d8e908 [svn-r26333] Eliminates gcc warnings due to -Wunsuffixed-float-constants.
- Adds 'F' suffixes for most float constants.

- A few constants MUST be of type double. These now receive the long
  double L suffix and are then cast to double. I do this via a new
  H5_DOUBLE() macro which was added to H5private.h.

Fixes: HDFFV-9148

Tested on: h5committest
2015-03-01 13:48:54 -05:00
Mohamad Chaarawi
a24e3e5c86 [svn-r25994] revert adding the has_mpi_atomicity feature flag and use the has_mpi
flag instead.
2015-01-21 13:57:55 -05:00
Mohamad Chaarawi
88fb6b1374 [svn-r25531] remove use of C99 PRI that failed on windows in dtypes.c
fix bugs where hid_t were assumed to be 32 bit ints or herr_t.
2014-08-11 14:13:45 -05:00
Mohamad Chaarawi
beb6f83cfd [svn-r25500] fix HDFFV-8888 - H5Ldelete_by_idx fails on non-existent group name.
tested Jam. minor change.
2014-07-31 14:26:19 -05:00
Quincey Koziol
33ea1ada24 [svn-r25496] Description:
Merge 64-bit ID changes from branch to trunk.  (Plus a few minor cleanups
that aren't on the branch)

Tested on:
    Mac OSX/64 10.9.4 (amazon) w/C++ & FORTRAN
    (h5committested on branch already for a week)
2014-07-30 15:55:14 -05:00
Quincey Koziol
61a411b02f [svn-r25450] Description:
Initial tweaks to align with VOL branch.

Tested on:
    Mac OSX/64 10.9.3 (amazon) w/gcc 4.9
    (h5committest not required, too small)
2014-07-21 11:05:04 -05:00
Quincey Koziol
2e4302818a [svn-r24864] Description:
Remove all traces of MPI-POSIX VFD and GPFS detection/code.

    Remove remaining traces of stream VFD.

    Remove testpar/t_posix_compliant test (it's not actually verifying anything).

    Clean up H5D__mpio_opt_possible() further.

    Moved environment variable that disables MPI collective operations into
MPI-IO VFD (instead of it being in src/H5S.c).

    A few other small code cleanups.

Tested on:
    Mac OSX/64 10.9.2 (amazon) w/parallel & serial
2014-03-21 18:02:24 -05:00
Quincey Koziol
0a506a625b [svn-r24476] Description:
Remove duplicate "intent" flags from top & shared file structures, leaving
    them only in the shared file structure.

Tested on:
    Mac OSX/64 10.9.0 (amazon) w/gcc 4.8, both parallel & serial
    (too minor to require h5committest)
2013-11-30 00:51:42 -05:00
Allen Byrne
a8c227e175 [svn-r23812] Added the HD prefix to the system functions used in the links.c file.
Tested: local linux
2013-06-24 15:02:42 -05:00
Quincey Koziol
0324f05566 [svn-r22915] Description:
Bring Coverity changes back to trunk:


r20399:
Change parse_command_line to free hand structure on error and only "leave()" at end of main.

r20400:
Purpose: Fix coverity issue 592

Description: Added void cast to call to H5F_sfile_assert_num() in
H5F_term)interface().  There is no need to check the return value of this
function in general, and there would be nothing to do even if it did fail.

r20401:
Added free(src_sizes) and free(src_offset). --gh


Tested on:
    Mac OSX/64 10.8.2 (amazon) w/C++, FORTRAN, threadsafe
    (too minor for h5committest)
2012-10-17 13:41:42 -05:00
Quincey Koziol
3d9e0b86ac [svn-r21923] Description:
Add FUNC_ENTER macros for package-private routines and begin process of
switching package routines to use them.  All H5G routines are currently
finished.

Tested on:
    Mac OSX/64 10.7.3 (amazon) w/debug, production & parallel
2012-02-09 21:16:52 -05:00
Raymond Lu
03cc051dde [svn-r20759] I commented out 2 test cases using H5_CANNOT_OPEN_TWICE because they open the same file twice. OpenVMS
can't do it.  Other systems still run them. 

Tested on jam. Simple change.
2011-05-05 15:09:49 -05:00
Neil Fortner
775c663acd [svn-r20694] Add description for new "external_open_twice" test.
Tested: jam
2011-05-02 10:28:34 -05:00
Neil Fortner
1a93a07867 [svn-r20691] Purpose: Fix problem exposed by external link cache
Description:
When closing an object that had two open id's, the library would previously fail
to account for the status of the "holding_file" field, potentially causing the
file's "nopen_objs" field to become inconsistent.  This caused problems when
opening the same object twice through an external link using th external file
cache.  Modified the library to properly account for the status of the
"holding_file" field when closing an object id, even when the underlying
"shared" object isn't closed.

Tested: jam, koala, heiwa (h5committest)
2011-05-01 23:12:47 -05:00
Quincey Koziol
9431c7a97e [svn-r20536] Description:
Clean up various warnings & code formatting issues.

	Bring changes from Coverity branch to trunk:

r20085:
Purpose: Fix coverity issue 793

Description: Modified H5S_hyper_project_simple_higher() to free the entire span
list in new_space on failure.


r20091:
This is a fix for coverity bug #1683.
Changed the two printfs to use %lu (unsigned long) for printing "dset_size".


r20162:
Purpose: Fix coverity issue 785

Description: Modified H5T_enum_nameof() to free "name" on failure if it was
allocated.  Also clarified some code in H5S_hyper_rebuild_helper().


r20189:
Addressed coverity defect 783.

H5SL_new_node() in H5SL.c was failing to free space allocated in its
first alloc if the second alloc failed.  Added a call to H5FL_FREE
to address this issue.

This is purely to keep coverity happy -- if this code is ever triggered,
we have much larger problems.

Note that this fix will trigger an unused return value complaint
from coverity next week.


r20190:
Fixed Coverity issues 1561 1565 and 1678 (UNUSED_VALUES) by moving checks of return values to after the function call.


r20191:
Fixed coverity issues 643 644 and 1678 (CHECKED_RETURN).


r20232:
Addressed coverity issues 923-925.  Replaced calls to sprintf with calls
to HDsnprintf.


r20233:
Fix coverity issue 662.  Don't try to sort 0 attributes in H5Aint.c.


r20234:
Fix coverity issue 664.  Check for NULL before dereferencing in H5Gdeprec.c.


r20271:
Purpose: Fix coverity issue 784

Description: Modified H5_debug_mask() to keep a list of files opened for use as
a debugging output stream, and modified H5_term_library to close these files on
exit.


r20272:
addressed coverity issues 838 & 955.  Issue was use of strcpy() -- existing
code was safe, but modified to use strncpy() to keep coverity happy.


r20273:
Addresed coverity issues 1388 and 1389.
Initialized sel_iter->type to NULL in H5S_select_iter_init.


r20275:
Purpose: Fix valgrind issue in mf.c

Description: Fixed bug (incomplete if statement) in test_mf_fs_alloc_free() so
the retrieved node gets freed.


Tested on:
        FreeBSD/32 6.3 (duty) in debug mode
        FreeBSD/64 6.3 (liberty) w/C++ & FORTRAN, in debug mode
        Linux/32 2.6 (jam) w/PGI compilers, w/default API=1.8.x,
                w/C++ & FORTRAN, w/threadsafe, in debug mode
        Linux/64-amd64 2.6 (amani) w/Intel compilers, w/default API=1.6.x,
                w/C++ & FORTRAN, in production mode
        Solaris/32 2.10 (linew) w/deprecated symbols disabled, w/C++ & FORTRAN,
                w/szip filter, w/threadsafe, in production mode
        Linux/PPC 2.6 (heiwa) w/C++ & FORTRAN, w/threadsafe, in debug mode
2011-04-17 13:57:07 -05:00
Neil Fortner
7610dd20af [svn-r20529] Purpose: Add testing for bug 1864
Description:
Added internal tesitng routines to traverse a file and verify that symbol table
information is *always* cached, whenever possible.  Added this check to the end
of many tests to check all the test files, right before the call to h5_cleanup.

Tested: jam, amani, heiwa (h5committest)
2011-04-15 17:05:23 -05:00
Neil Fortner
ce35ebecfb [svn-r20491] Rename H5Frelease_file_cache to H5Fclear_elink_file_cache.
Tested: Fedora (too minor for full committest)
2011-04-13 16:03:30 -05:00
Dana Robinson
c480a8c717 [svn-r20453] Reordered two expressions to avoid integer overflow (quiets a compiler warning). 2011-04-08 15:20:20 -05:00
Neil Fortner
0863d30372 [svn-r20064] Purpose: Implement external file cache
Description:
Implements a cache of files opened through external links.  Adds the public
functions H5Pset_elink_file_cache_size(), H5Pget_elink_file_cache_size(), and
H5Frelease_file_cache().

Tested: jam, amani, heiwa (h5committest), fedora 64.
2011-02-08 12:32:56 -05:00