Commit Graph

20251 Commits

Author SHA1 Message Date
David Young
f907b511d0 Oops, remove more C99 designated initializers for VS 2010 compatibility. 2019-11-25 17:30:08 -06:00
David Young
62208b056a Add an #include to get a function declaration. 2019-11-25 16:56:03 -06:00
David Young
d07aeef6ad Merge remote-tracking branch 'hdf5/develop' into add-werror-and-squash-some 2019-11-25 16:38:21 -06:00
David Young
f2f8a554e6 Don't use C99 designated initializers, they're not compatible with
Visual Studio 2010.
2019-11-25 15:43:56 -06:00
Chris Hogan
b8a56718e4 Merge pull request #2029 in HDFFV/hdf5 from ~CHOGAN/hdf5:feature/cx_lcpl to develop
* commit '4ce9c10c568ff81ebd4eb7585039cbe3c40d1718':
  Add documentation for H5CX_get_ohdr_flags
  Add object header flags to API context
  Use major error code of calling package
  Handle H5CX_state_t for lcpl
  Add character encoding to lcpl context
  Change LC property name from 'create_intermediate_group' to 'intermediate_group'
  Use API context to store/retrieve LCPL when creating intermediate groups
2019-11-25 11:39:04 -06:00
David Young
edd5297143 Quiet some more maybe-uninitialized warnings---each is a false positive,
*sigh*.  This is more code that may not compile with VS2010, *sigh
sigh*.
2019-11-22 15:31:00 -06:00
David Young
6d5ec83fc3 Always warn on maybe-uninitialized. -Wincompatible-pointer-types was not
available until GCC 5, so enable it only if that's the GCC version we're using.
2019-11-22 14:34:42 -06:00
David Young
fa1dfbbd8d Only promote maybe-uninitialized warnings to errors on GCC 8. Even on
GCC 8, there may be false positives at low optimization levels?  I need
to check.
2019-11-22 14:23:07 -06:00
David Young
dde718ad51 Only use -Werror=cast-function-type with GCC 8 and later. 2019-11-22 13:49:59 -06:00
David Young
edb6f34440 Put all of the -W options back into the order I found them in so that it's
easier to compare old and new config/gnu-flags.
2019-11-22 13:41:45 -06:00
David Young
456171651a Add new source files to CMakeLists.txt. 2019-11-20 16:56:00 -06:00
David Young
adb0c7bde5 Mention the -Werror= flags in libhdf5.settings.in. 2019-11-20 15:54:15 -06:00
David Young
559bcaf570 free -> HDfree 2019-11-20 15:53:46 -06:00
Neil Fortner
33d173d672 Merge pull request #2043 in HDFFV/hdf5 from ~NFORTNE2/hdf5_naf:seq_list_fix to develop
* commit 'c104f4cb87a1558ab6a772967887738dc9800f0d':
  Modify H5Ssel_iter_get_seq_list() to accept iterators that have reached the end of iteration (returning zero sequences).  Previously it could cause an assertion failure.
2019-11-20 12:02:46 -06:00
Allen Byrne
13456df8a4 Merge pull request #2048 in HDFFV/hdf5 from ~BYRN/hdf5_merge_adb:develop to develop
* commit 'efe234c832581d16d3da41fe71b50ef71fd44acc':
  Minor correction
  Update list of tested platforms
  Add VS2019 support
2019-11-19 15:48:06 -06:00
Allen Byrne
efe234c832 Minor correction 2019-11-18 15:32:19 -06:00
Allen Byrne
0f09287b19 Update list of tested platforms 2019-11-18 15:02:10 -06:00
Allen Byrne
265325fb9a Add VS2019 support 2019-11-18 14:58:06 -06:00
Richard Warren
3f9c7efbd9 Merge pull request #2047 in HDFFV/hdf5 from h5_private_prototype_fix to develop
* commit 'c440e05de82b224a0a6b042ec8a27accdc1e48ae':
  Fixed the H5_mpi_get_bigio_count function prototype
2019-11-18 14:18:55 -06:00
Richard Warren
c440e05de8 Fixed the H5_mpi_get_bigio_count function prototype 2019-11-18 15:04:35 -05:00
Neil Fortner
c104f4cb87 Modify H5Ssel_iter_get_seq_list() to accept iterators that have reached
the end of iteration (returning zero sequences).  Previously it could
cause an assertion failure.
2019-11-15 16:47:30 -06:00
Chris Hogan
4ce9c10c56 Add documentation for H5CX_get_ohdr_flags 2019-11-15 16:19:19 -06:00
Allen Byrne
3593b3d201 Merge pull request #2042 in HDFFV/hdf5 from ~BYRN/hdf5_merge_adb:develop to develop
* commit 'c2fd059704e9232a3d3221ddd0c84803256baec2':
  Correct file extension
2019-11-15 16:00:39 -06:00
Allen Byrne
c2fd059704 Correct file extension 2019-11-14 16:41:18 -06:00
Chris Hogan
a7b35b8584 Add object header flags to API context
Add missing DCPL to API context state
Replace a couple LCPL H5P_get calls with H5CX_get_*
2019-11-14 15:56:15 -06:00
David Young
29561bac95 Promote decleration-after-statement warnings to errors. 2019-11-13 14:39:12 -06:00
David Young
bf6b89c841 Quiet decleration-after-statement warnings. 2019-11-13 14:38:22 -06:00
David Young
7dcd36a37d Move a statement under some declarations since some vintages of Visual
Studio don't like declarations after statements.
2019-11-13 14:21:15 -06:00
David Young
3dd539473b Document H5D__chunk_mem_xfree_wrapper(). 2019-11-13 13:48:07 -06:00
David Young
bd77af437f Undo accidental test deletion. 2019-11-13 13:41:05 -06:00
David Young
305177a51f Oops, delete a debug printf that snuck in here. 2019-11-13 13:39:59 -06:00
David Young
b0dd6184bc Undo my changes to the HD macros, hadn't really intended those to be on
this branch....
2019-11-13 13:38:47 -06:00
David Young
560db03d66 Make errors of some more warnings. Move disabled warnings to
DEVELOPER_WARNING_CFLAGS.  Put just one warning option on a line, and
sort some of the options.
2019-11-13 13:33:46 -06:00
David Young
15f5a6980d Cast to the parameter type, H5VL_token_t *, instead of to unsigned char *.
(H5VL_token_t, too, probably should turn from a typedef for a
constant-length array to an array encapsulated in a struct.)
2019-11-13 13:31:51 -06:00
David Young
b505226ad5 Change hdset_reg_ref_t and H5R_ref_t from arrays of unsigned char to
structs containing those arrays.  Encapsulating the arrays in this way
makes it easier to write and think about pointers to these types, casts
to/from these types, etc.

An interesting side-effect that we probably should *not* rely on is
that the struct-encapsulation changes the alignment so that some GCC
warnings about casts that increase the alignment requirement of the
operand go away.  Warnings like that have to be taken seriously:  I will
add -Werror=cast-align to the default compiler flags so that they stop
the build quickly.

GCC warnings led me to some surprising casts in test/trefer.c. I found
that it was possible to make many simplifications after introducing the
struct-encapsulation that I described, above.
2019-11-13 13:29:59 -06:00
Neil Fortner
07b59c0b63 Merge pull request #2033 in HDFFV/hdf5 from ~NFORTNE2/hdf5_naf:public_spi to develop
* commit 'db6eab893e5f027f0b535316e0e7a9abe9ff8619':
  Implement public H5Sselect_project_intersection().  Updated internal algorithm to (optionally) avoid sharing selection data structures. Tested internal code (including with valgrind) by setting VDS code to avoid sharing selection, has since been changed to share selection for performance, so this code is not yet tested in regression tests.  API has not been tested.
2019-11-13 12:57:31 -06:00
Neil Fortner
db6eab893e Implement public H5Sselect_project_intersection(). Updated internal
algorithm to (optionally) avoid sharing selection data structures.
Tested internal code (including with valgrind) by setting VDS code to
avoid sharing selection, has since been changed to share selection for
performance, so this code is not yet tested in regression tests.  API
has not been tested.
2019-11-13 12:54:13 -06:00
David Young
695c62bafe In every instance, x is initialized by memcpy, but GCC isn't smart
enough to figure that out.  Quiet some warnings by always initializing
`x` to 0.
2019-11-13 12:06:01 -06:00
David Young
1e3d63dcdf same_file is assigned but never used. Delete it. 2019-11-13 12:05:16 -06:00
David Young
81a256b02e Don't assign a constant string to a pointer to non-constant character. 2019-11-13 12:04:42 -06:00
David Young
42cd35b717 GCC isn't smart enough to realize that fill_c is always initialized
and exclusively used in `datatype == H5T_COMPOUND` branches, so just
initialize it at its declaration so that GCC doesn't warn.
2019-11-13 12:03:18 -06:00
David Young
7bdf30738d I'm not sure what the previous code was trying to do, casting an array
of `hsize_t`, `start`, to `long long`, but I think the way that I have
rewritten it, it probably produces a more useful result?  As a bonus,
GCC has stopped warning about it.
2019-11-13 11:56:46 -06:00
David Young
dc0d3a3881 Quiet a warning about an unused variable. This code looks like it
should be heavily restructured to avoid the use of globals like `pass`,
but that's a project for another day and another person.
2019-11-13 11:50:11 -06:00
David Young
943e601b10 Straggler from previous commit: build and link the new .c files where I
moved some previously-static variables and functions that were causing
unused-variable/function warnings.
2019-11-13 11:49:15 -06:00
David Young
c5b8f3db3b Make many warnings about H5T_copy() calls that discard const qualifiers
into a few warnings in H5T_copy() itself.
2019-11-13 11:45:29 -06:00
David Young
19e3b93c81 Use FUNC_ENTER_STATIC_NOERR instead of FUNC_ENTER_STATIC for a function
that does not generate its own error, so GCC does not warn that
err_occurred (or whatever it is called) is unused or set and unused.
2019-11-13 11:42:50 -06:00
David Young
408d208710 Explicitly initialize type_flags; the compiler does not realize that
it is set before use by passing it as a reference to another function.
2019-11-13 11:41:25 -06:00
David Young
918e1a879d Initialize a couple of return values to avoid used-before-set warnings. 2019-11-13 11:39:24 -06:00
David Young
1937029354 Initialize a couple of variables that the compiler does not realize are
initialized when they're passed by reference to functions.
2019-11-13 11:37:14 -06:00
David Young
e2d9cc5584 To quiet a warning, initialize some struct timevals that the compiler
does not realize are always set before use by `gettimeofday`.
2019-11-13 11:35:36 -06:00