Code cleanup
Description:
Clean up a few loose ends and warnings for the 1.6 compatibility changes
to the error API.
Platforms tested:
FreeBSD 4.9 (sleipnir)
too minor to require h5committest
Refactored code
Description:
Moved duplicated "get_file_size()" function from a couple of tests into a
central location.
Platforms tested:
FreeBSD 4.8 (sleipnir)
h5committest
Small feature.
Description:
Change the wording for the use of HDF5_PARAPREFIX from Remark to hint.
Also made process 0 be the only one printing the hint rather all
processes duplicating the same hints.
Platforms tested:
Copper, both serial and parallel.
Did not do h5commit test since this is very localized and the above
tests covered both cases already.
Misc. update:
Feature change
Description:
HDF5_PARAPREFIX has been default to various values like /tmp,
/var/tmp, ... None of these solve all problems and all of them
created new problems. For LLNL GPFS, '.' is more appropriate since
they can do the build right inside gpfs. Same for NCSA Copper.
The special setting for Janus is still retained since that is a
one of a kind machine and the uses could use all the help.
Platforms tested:
h5committested (using sol instead of arabica) plus eirene(pp).
Misc. update:
Update
Description:
Updated the Copyright statement
Platforms tested:
Linux (This change is only in the comments, so I just check that the
modules still compile)
Misc. update:
New feature
Description:
If backing store for a core VFD file is turned on, remove the file created.
Platforms tested:
FreeBSD 4.6 (sleipnir) w and w/o parallel
Linux 2.2.x (eirene) w/FORTRAN & C++
Solaris 2.7 (arabica) w/FORTRAN
IRIX64 6.5 (modi4) w/FORTRAN & parallel
Code cleanup/More tests
Description:
Cleaned up some compiler warnings and wrote additional tests for space
allocation and storage size routines.
Platforms tested:
FreeBSD 4.6 (sleipnir) w/serial & parallel. Will be testing on IRIX64
6.5 (modi4) in serial & parallel shortly.
Feature Enhancement
Description:
We can now set the MPI_Info object to more than one key/value
pairing. By setting the HDF5_MPI_INFO environment variable to a
semicolon separated list of "key=value" pairs, we can set the
MPI_Info variable to them.
Platforms tested:
Linux
Feature
Description:
moved the routines of setting up and dumping MPI-info object to
test library so that it is avaiable for all tests too.
Platforms tested:
modi4(pp), eirene (serial)
Purpose:
windows support of socket function
Description:
gethostname is treated as socket function in windows and
it is defined at winsock.h.
for every windows socket function to be called, it must start
with WSAStartup and end with WSACleanup
Solution:
Add WSAstartup and WSACleanup with WIN32 macro.
Platforms tested:
windows 2000, confirmed at linux 2.2.18
New feature
Description:
Added h5_show_hostname to display the hostname of the host in
which the process runs. It can help identify location of process
in multiple processes or batch launching environments.
Platforms tested:
Eirene (pp)
Code cleanup
Description:
Platform dependent code related to the struct stat and fstat
calls polluted source codes. Hard to maintain.
Solution:
Platform dependent code are moved to H5private.h and then internal
code can #include H5private.h. Repeat those macro definition for
the stdio and multi drivers since they area examples for writing
a virtual file driver. They must not use any internal code.
Platforms tested:
eirene (parallel), modi4 (serial including gass driver.)
Backward Compatibility Fix
Description:
H5Pset_fapl_log's parameters have changed from a simple "verbosity" level
to bit-masked flags to enable various behaviors.
Solution:
Added in v1.4 compat stuff, on the unlikely chance that others are actually
using this code in some production way.
There are no C++ or FORTRAN wrappers for this call.
Platforms tested:
FreeBSD 4.4 (hawkwind)
Code cleanup
Description:
Changed the logging file driver to use bitmasked flags for features to
enable, instead of using a verbosity level.
Platforms tested:
Solaris 2.6 (baldric)
Code cleanup
Description:
Windows is generating hundreds of warnings from some of the practices in
the library. Mostly, they are because size_t is 32-bit and hsize_t is
64-bit on Windows and we were carelessly casting the larger values down to
the smaller ones without checking for overflow.
Also, some other small code cleanups,etc.
Solution:
Re-worked some algorithms to eliminate the casts and also added more
overflow checking for assignments and function parameters which needed
casts.
Kent did most of the work, I just went over his changes and fit them into
the the library code a bit better.
Platforms tested:
FreeBSD 4.4 (hawkwind)
Code cleanup for better compatibility with C++ compilers
Description:
C++ compilers are choking on our C code, for various reasons:
we used our UNUSED macro incorrectly when referring to pointer types
we used various C++ keywords as variables, etc.
we incremented enum's with the ++ operator.
Solution:
Changed variables, etc.to avoid C++ keywords (new, class, typename, typeid,
template)
Fixed usage of UNUSED macro from this:
char UNUSED *c
to this:
char * UNUSED c
Switched the enums from x++ to x=x+1
Platforms tested:
FreeBSD 4.4 (hawkwind)
Feature shift
Description:
Take out the v1.2.x compatibility stubs and put in the hooks for v1.4.x
compatibility when needed.
Platforms tested:
FreeBSD 4.3 (hawkwind)
Small Fix
Description:
Don't delete the /tmp/${USER,LOGIN} directory when we're done with
it. Also, only do the /tmp/${USER,LOGIN} if this is a parallel
configured library.
Solution:
Removed the removal of the /tmp/${USER,LOGIN} directory and added
checks to determine if we're in a parallel configured library before
munging the filename...
Platforms tested:
Linux
Feature Add
Description:
Added the feature (not a bug, a FEATURE!) that, if the person has the
env variables USER or LOGIN set, then it will place the temporary
files in the "/tmp/$USER" or "/tmp/$LOGIN" directory (in that order).
This is only if the prefix the user gives is the default one "/tmp".
After the tests are finished, it will remove the directory for the
user.
Platforms tested:
Linux
Update
Description:
Changed includes of the form:
#include <hdf5_file.h>
to
#include "hdf5_file.h"
so that gcc can pick them up easier without including the system
header files since we don't care about them.
Platforms tested:
Linux
Code cleanup
Description:
Code had ifdef's instead of using standard macro wrappers for getpid()
call.
Solution:
Took out ifdef's and changed to use standard H5getpid() macro.
Platforms tested:
FreeBSD 4.3 (hawkwind)
Clean up warnings
Description:
The "FAILED" macro is defined by Windows and is causing warnings and
potential errors when compiled on that platform.
Solution:
Change our macro from FAILED to H5_FAILED.
Platforms tested:
FreeBSD 4.2 (hawkwind)
Code cleanup.
Description:
Fixed _lots_ (I mean _tons_) of warnings spit out by the gcc with the
extra warnings. Including a few show-stoppers for compression on IRIX
machines.
Solution:
Changed lots of variables' types to more sensible and consistent types,
more range-checking, more variable typecasts, etc.
Platforms tested:
FreeBSD 4.2 (hawkwind), IRIX64-64 (modi4)
Backward compatibility code
Description:
Add in code to allow the library to emulate the v1.2 API and behavior.
Platforms tested:
FreeBSD 4.2 (hawkwind)
Bug fix
Description:
The predefined HDF5_PARAPREFIX has a trailing slash. The parallel
testfile names end up with two adjacent slashes that made some system
unhappy.
Solution:
Removed the trailing slash.
Platforms tested:
Arabica (solaris 2.7).
The "FILENAME" declared extern in h5test.h is not always used.
It was used in h5_cleanup to remove temporary files created
during tests. Not all tests codes have used this routine.
Indeed, quite a few of test programs do "#define FILENAME ".
Also, h5_cleanup needs to work in tandem with h5_fixname.
h5_fixname accepts an explicite base_name argument instead
of using the global variable FILENAME. That is cleaner.
Solution:
Added char *base_name[] as a new argument to h5_cleanup, in
the same style as h5_fixname. Removed "extern char *FILENAME..."
from use. Also, undo some unnecessary declaration of "char *FILENAME"
from some tests which don't use it at all (yet).
Platforms tested:
modi4-64(irix64), arabica(solari2.7), eirene(linux)
(arabica could not launch tests automatically. I had to hack
in LD_LIBRARY_PATH to make them run.)
serial and parallel test files are tested in different file systems.
Added the global variable, paraprefix, so that it can be set via
command line option.
** configure.in
** configure [REGENERATED]
** src/H5private.h
** src/H5public.h
** src/Makefile.in
Generates an H5pubconf.h file which is just like H5config.h except all
the preprocessor symbols have `H5_' prepended. This was done so that
the configuration results can be used in public header files without
polluting the namespace.
** src/H5.c
Added H5I_REFERENCE and H5I_VFL to the API tracing code so their names
are printed instead of just numbers.
** src/H5FDstdio.c
** tools/h5import.c
** tools/h5repart.c
** tools/pdb2hdf.c
Changed to use the `H5_' versions of configure results since these
files include only the public API.
** test/big.c
Removed a compiler warning.
** test/h5test.c
Removed unused code.
