Code cleanup
Description:
Tweak recent "forward compatibility" changes to the H5E* API (which allowed
for the old H5E API functions to remain unchanged) by allowing for the error
stack callback function (H5E_auto_t) to also remain unchanged from the 1.6
branch. This required changing the H5E{get|set}_auto routines to have the
old style H5E_auto_t type (which didn't have a stack ID parameter) and the new
H5E{get|set}_auto_stack routines to have a newer "H5E_auto_stack_t" type (which
has a stack ID parameter). This should make the H5E API changes as forwardly
compatible as possible.
One side-affect of this change was that it was impossible to determine if
the current auto error callback was the old style (H5E_auto_t) or the new style
(H5E_auto_stack_t) of callback, so a new API function (H5Eauto_is_stack) was
adde to query this.
Platforms tested:
FreeBSD 4.10 (sleipnir)
IRIX64 6.5 (modi4)
h5committest
Description:
H5T_conv_t (appears in H5Tregister description) -- changed datatype
of the nelmts parameter
H5Tconvert -- changed datatype of the nelmts parameter
Platforms tested:
Mozilla
New feature and Update.
Description:
1. Updated installhdf5lib.bat file so that libtest_fortran.lib and libtest_fortrand.lib will NOT be installed;
2. Updated the project settings for projects in HDF5 C examples:
To be consistant with other HDF5 windows project settings:
1) replaced zlib.lib in Object/library modules with environment variable HDF5_EXT_ZLIB
2) replaced szlib.lib in Object/library modules with environment variable HDF5_EXT_SZIP
Also, to prevent the compiler from failing to find hdf5.lib/hdf5d.lib when HDF5 library has been removed from the original folders, added the installed library hdf5lib path in the Additional library path.
3. Added a new batch file testExamples.bat under hdf5\examples directory for the purpose of testing HDF5 C examples. An expected C examples tests output file testExample_exp_output.txt was aslo added.
4. h5repack testing batch file repacktest.bat has a minor bug. This minor bug causes some HDF5 repack testing failures when only gzip is disabled.
The failure reasons is that we only checked whether szip or szip encoder is enabled for the following two tests:
h5repack test_deflate.h5 -f dset_deflate:SZIP=8,NN
h5repack test_szip.h5 -f dset_szip:GZIP=1
These two tests should also be skipped when gzip is disabled.
5. As HDF5 Fortran DLL does not work with DEC Fortran 6.0, so we do not need to build HDF5 Fortran DLL related projects anymore.
Solution:
Added Checking whether gzip is disabled for the above two h5repack tests. If gzip is disabled, skip these tests.
Modified hdf5build.bat batch file so HDF5 Fortran DLL related projects will not be built.
Platforms tested:
installhdf5lib.bat, hdf5build.bat, repacktest.bat and testExamples.bat batch files are same in branch 1.6 and 1.7. These batch files have already been tested in branch 1.6. So it is not necessary to test for branch 1.7 again.
For the HDF5 C examples, tested in Visual C++ 6.0 in Windows XP.
Misc. update:
Description: One place was left out for update after the Error API was modified.
Changed it from H5Eset_auto to H5Eset_auto_stack.
Platforms tested: sleipnir(with threadsafe) - simple change.
Fix configure bug that appears on SDSC DataStar.
Description:
Two cached "sizeof"s in ./config/powerpc-ibm-aix5.x cause builds
on SDSC Datastar to choke.
Solution:
Commented out the offending "sizeof"s. Included comments indicating
the reason for the change.
Platforms tested:
copper
Misc. update:
n/a
bug fix
Description:
The H5O_mtime_decode function was not handling properly the case for the
Code Warrior compiler
Solution:
Platforms tested:
Code Warrior
Misc. update:
new test for the native types test
Description:
on the Cray SV1 an INT type was wrongly converted to a SHORT type
by the get_native_integer function
Choose the type based on the precision; this is to support cases
like the Cray SV1, where the size of short is 8 but precision is 32
(e.g an INT (size 8, prec 64) would be converted to a SHORT
(size 8, prec 32) if the size was the deciding factor)
Solution:
Platforms tested:
linux
solaris
aix
Misc. update:
bug fix
Description:
on the Cray SV1 an INT type was wrongly converted to a SHORT type
by the get_native_integer function
Choose the type based on the precision; this is to support cases
like the Cray SV1, where the size of short is 8 but precision is 32
(e.g an INT (size 8, prec 64) would be converted to a SHORT
(size 8, prec 32) if the size was the deciding factor)
Solution:
Platforms tested:
linux
solaris
aix
Misc. update:
Description: A few items were left out when tried to restore the old Error API.
There are also a few minor bug fixes.
Platforms tested: arabica fuss h5committest.
bug fix
changed some datset names for h5repack etsts
Description:
Description:
the dataset region reference data was not portable between the Cray T3E and other machines
Solution:
this was due to the fact that the buffer to store the heap ID and index was using a sizeof(int) for its
size
4 is used instead of sizeof(int) to permit portability between
the Crays and other machines (the heap ID is always encoded as an int32 anyway)
Solution:
Platforms tested:
linux
aix
solaris
Misc. update:
bug fix
Description:
Description:
the dataset region reference data was not portable between the Cray T3E and other machines
Solution:
this was due to the fact that the buffer to store the heap ID and index was using a sizeof(int) for its
size
4 is used instead of sizeof(int) to permit portability between
the Crays and other machines (the heap ID is always encoded as an int32 anyway)
Solution:
Platforms tested:
linux
aix
solaris
Misc. update:
Purpose:
Shrink HDF5 parallel test
Description:
Previously the collective chunk IO tests created and opened four HDF5 files;
it turned out that all collective chunk IO tests can use one file for testing.
Solution:
To use one file for all collective chunk IO tests with trunc option to be set in H5Fcreate.
Platforms tested:
copper(no need to use h5committest)
Misc. update:
Code warrior support erased previous change of object settings, we need to resume the old change.
Description:
Xuan checked in the recent change for windows settings(many of them) on Sep. 1st and it was wiped out by code warrior support that used the old all.zip modified on Aug. 27th. In order to maintain the release for windows, we have to resume it.
Solution:
Platforms tested:
Misc. update:
added a new project file for CodeWarrior (the files in the library changed since the last version )
Description:
Solution:
Platforms tested:
Misc. update:
New feature.
Description:
Before this update, we use per_hdf_library convention to set environment variables for gzip and szip compression libraries, for example, HDF5_EXT_LIBS = zlib.lib szlib.lib.
As some of HDF5 dump and repack tests should be skipped when gzip/szip are disabled. But we found it was very complicated to check whether gzip/szip were disabled in Windows with the per_hdf_library convention. Using per_external_library naming convention makes the checking much easier. So we decide to convert to per_external_library naming convention.
A new environment variable H5_SZIP_CAN_ENCODE is added to check whether szip encoding is enabled.
dumptest.bat and repacktest.bat batch files are also updated so these tests which use gzip/szip filters will be skipped when gzip/szip are disabled and will be tested when gzip/szip are enabled.
Solution:
Now we should set the following environment variables:
HDF5_EXT_ZLIB = zlib.lib
HDF5_EXT_SZIP = szlib.lib
HDF5_EXT_ZLIB_DLL = c:\zlib114\dll\zlib.lib
HDF5_EXT_SZIP_DLL = szlibdll.lib
when we want to enable gzip/szip.
Set H5_SZIP_CAN_ENCODE as 1 when szip encoding is enabled and as 0 when szip encoding is disabled.
Platforms tested:
Visual C++ 6.0 on Windows 2000/XP.
(Will test with .NET after this check-in).
Misc. update:
Description: Restore 6 old error API functions back to the library to be backward
compatible with v1.6. They are H5Epush, H5Eprint, H5Ewalk, H5Eclear, H5Eset_auto,
H5Eget_auto. These functions do not have error stack as parameter.
Solution: Internally, these functions use default error stack.
Platforms tested: h5committest and fuss.
Misc. update: RELEASE.txt
Text display change
Description:
Changed the test names to much shorter strings for easier
use.
Platforms tested:
No h5committed test. Only test parallel in eirene.
Misc. update:
Bug fix.
Description:
There was a minor bug in the hdf5check.bat I checked in last night. We should check check_results.txt (not hdf5_results.txt) to find out whether there are any failed tests.
Solution:
Change hdf5_results.txt to check_results.txt.
Platforms tested:
Minor fix, Kent tested the fix on Windows XP.
Misc. update:
"bug fix" sort of.
Description:
The current mpicc at TG-NCSA recognizes uint64_t but not
int64_t. hdf5 code rightly assumes when the unsigned type
is defined, the corresponding signed type should be valid
too. So, when it detected uint64_t is valid, it went ahead
using int64_t which ended in compiling failure.
Solution:
Changed the detection to check on int64_t instead. This does
not change any logic, just goes around the mpicc compiler error
at TG-NCSA.
Platforms tested:
h5committested and tested at TG-NCSA (pp) too.
Misc. update:
Update.
Description:
Add HDF5 timing tests into hdf5check.bat batch file.
hdf5check.bat batch file will generate a new file tests_results under HDF5 directory to dispaly whether all HDF5 tests passed or not, if failed, which tests failed (the check_results.txt which includes detailed HDF5 libraries and tools tests results will also be generated at the same time).
Solution:
Platforms tested:
Windows 2000/XP.
Misc. update:
Bug fix.
Description:
$CXX_BASENAME was not set yet if $CXX was pre-set to g++. In turn,
CXX_flags are not picking up the g++ values.
Solution:
The correct solution should be done in configure which should have
setup CXX_BASENAME if $CC is set before sourcing this file.
Put a special patch here for g++ for now.
(Also added the recognization of icc as another name for Intel
compilers.)
Platforms tested:
No h5committest but tested in TG-NCSA since these changes affected
the IA64 platform only.
Misc. update:
New feature.
Description:
Before this update, to link HDF5 with zlib and szip libraries and DLLs,
zlib.lib szlib.lib were added into Object/library modules in more than
50 windows projects settings; c:\zlib114\dll\zlib.lib szlibdll.lib were
added into Object/library modules in hdf5dll project settings.
With the above settings, if we want to disable zlib and/or szip libraries
and DLLs from HDF5, we have to remove zlib.lib szlib.lib from Object/library
modules in more than 50 projects settings; c:\zlib114\dll\zlib.lib szlibdll.lib
also need to remove from hdf5dll project settings.
The above operations should be done for both release and debug versions.
So it is really very unconvenient to disable zlib and/or szip libraries and DLLs.
Solution:
Add HDF5_EXT_LIBS environment variable and replace zlib.lib szlib.lib
in Object/library modules with $(HDF5_EXT_LIBS)
Add HDF5_EXT_LIBS_DLL environment variable and replace c:\zlib114\dll\zlib.lib
szlibdll.lib in Oject/library modules with $(HDF5_EXT_LIBS_DLL).
If we want to enable both zlib and szip, set
HDF5_EXT_LIBS = zlib.lib szlib.lib
HDF5_EXT_LIBS_DLL = c:\zlib114\dll\zlib.lib szlibdll.lib
If we want to enable zlib and disable szip, set
HDF5_EXT_LIBS = zlib.lib
HDF5_EXT_LIBS_DLL = c:\zlib114\dll\zlib.lib
If we want to disable zlib and enable szip, set
HDF5_EXT_LIBS = szlib.lib
HDF5_EXT_LIBS_DLL = szlibdll.lib
If we want to disable both zlib and szip, set
HDF5_EXT_LIBS =
HDF5_EXT_LIBS_DLL =
Platforms tested:
Tested with Microsoft Visual C++ 6.0/DEC Fortran 6.0 and .NET on Windows XP and
Visual C++ 6.0/DEC Fortran 6.0 on Windows 2000 for all the possible 4 zlib/szip
enable/disable combinations:
1. Enable both
2. Enable zlib and disable szip
3. Disable zlib and enable szip
4. Disable both
Misc. update:
Bug fix (sorta)
Description:
Change reading of "missing" chunks from datasets with undefined fill
values to not overwrite the application buffer with random garbage from
memory. Note that this is almost the same, since whatever garbage the
application had in those locations will still be there...
Platforms tested:
FreeBSD 4.10 (sleipnir)
IRIX64 6.5 (modi4)
h5committested
Fix of bug/feature which caused testphdf5 to fail when run with more than
32 processes. This fix was originally applied to the 1.6 branch, and is
now ported to the 1.7 branch.
Description:
32 process limit was a hard coded constant.
Solution:
Modified most of the routines in t_mdset.c to adapt dynamically to
the current number of processes. In passing, I also tidied up a
few memory leaks.
Note that one new routine had been added to the 1.7 version of
t_mdset.c since the 1.6/1.7 split. I applied changes to this
routine as well.
Platforms tested:
h5committested
Tested on eirene with 4 and 8 processes. Couldn't go higher.
I would have like to repeat my 32 - 64 process tests on copper,
but was unable to do so as I don't have access to cu12t at
present. Perhaps I will be able to manage this in the next
few days. However, Albert wanted these changes checked in to
the 1.7 branch so he could work with them.
Misc. update:
h5repack test
Description:
modified a test file generation contents, for more easy debugging
(generated just one reference dataset and one region reference )
Solution:
Platforms tested:
linux
aix
solaris
Misc. update:
Code cleanup.
Removed bunch of old options (r,w,v,i,b,e) that are no longer valid
or useful after adopting the general test interface. Moved the test
of sizeof MPI_Offset into the test routine itself.
Platforms tested:
Eirene and Sol using pp mode.
Bug fix.
Description:
The return value of TestPrivateParser() was not tested, thus program
would keep on going incorrectly even if errors were detected in
TestPrivateParser.
Solution:
Check the return and exit accordingly.
Platforms tested:
Tested in Eirene and Sol in both serial and pp modes.
new test
Description:
added a test that generates and copies a file with a dataset with fill value
(this is to test the property list function H5Pequal)
Solution:
Platforms tested:
linux
solaris
aix
Misc. update:
Description:
The private function p_close was removed previously, but I
inadvertently put it back in a few places, while transferring
the changes from 1.6 branch. These are removed now.
Platforms tested:
SunOS 5.7 (arabica)
Linux 2.4 (eirene)
bug fix.
Description:
The test routines only print error messages but not all of them
return number of errors detected back to the main routine which
always exit with a 0 status. Thus make or shell commands could
not detect there were errors.
Solution:
Changed the test routines to return appropriate number of
errors to main routine which in turn exit with the appropriate
exit code if errors found.
Platforms tested:
Tested in Sol and eirene (pp).
Misc. update:
Description:
Updated various function headers for the RM as reviewing progresses.
Rearranged functions in header files for more sensible look of the RM.
Platforms tested:
SunOS 5.7 (arabica)
Linux 2.4 (eirene)
Description:
Added wrappers for H5Fget_name:
H5File::getFileName
H5Object::getFileName
Moved some functions from Group into the base class CommonFG for
H5File too.
Platforms tested:
SunOS 5.7 (arabica)
Linux 2.4 (eirene)
Description: Added PGI Fortran support for Linux64 systems (x86_64)
Solution:
Platforms tested: AMD Opteron box at AMD Sunnyvale and verbena
with PGI and gcc compilers.
Misc. update:
new feature
Description:
added a check that the chunk size must be smaller than pixels per block in SZIP request
prints a message and exits, if not met
Solution:
Platforms tested:
linux
aix
solaris
Misc. update:
Fix to config for ia64-linux (C++)
Description:
missing character in config file
Solution:
add the missing character
Platforms tested:
'hal'
Misc. update:
Description: In H5O_fill_new_decode and H5O_fill_new_encode, UINT32DECODE and
UINT32ENCODE were used to decode and encode message size, which is ssize_t.
Solution: Change to INT32DECODE and INT32ENCODE.
Platforms tested: fuss - very simple change.
Misc. update:
